And prefix every column in the query with a table alias. Remember, we have no idea what columns are in what tables.

Which table is "ID" in?

Which table is "NO_OF_PIN"...

mceventphoto (3/23/2016)

---

In reviewing the code I posted, I figured out that the second cursor is not needed. I simply replaced the portion of the where clause.

Where b.ITEMCODE = @itemCode

with

Where...

Sure, you can do it, but if you post the code it's extremely likely we here can re-work the entire method being used and make it much better.

create table #values...

The year, the 3-digit number and the incrementing number should all be stored as separate columns. You then use a computed column to construct the rptnum column. That...

Excellent article! My only additional suggestion would be to put your code in the master db, and start the proc name with sp_, so that the code can easily...

Hmm, overall vastly different qs, but if they are supposed to have experience, here's one q I love to ask ... but give them some time to...

Don't see anything better at a relatively quick look, although I would get rid of the double negative logic:

SELECT *

FROM #OrderDetails OD

WHERE OD.ActionCode = 'V' OR...

You can...

Phil Parkin (3/17/2016)

---

ScottPletcher (3/17/2016)

---

Phil Parkin (3/16/2016)

---

DATETIME is stored internally in SQL Server as the number of days since 1/1/1900 (the integer part) plus (I think) a decimal part representing the...

Phil Parkin (3/16/2016)

---

DATETIME is stored internally in SQL Server as the number of days since 1/1/1900 (the integer part) plus (I think) a decimal part representing the number of 300ths...

Jeff Moden (3/16/2016)

---

Sergiy (3/16/2016)

---

Jeff Moden (3/16/2016)

---

I strongly agree. NULL is not NOTHING. NOTHING...

You need to review the indexes from scratch. That is, analyze SQL's index usage stats, missing index stats and index operational stats. The longer time period you have...

You can reduce the effect on production by using "WITH (NOLOCK)" on the reads, unless you need an absolutely accurate copy of the data in test. If so, you'd...

I suggest creating the proc in the master db and marking it as a "system" proc. It will then work within the context of the current db, whatever that...

Maybe?:

SELECT CONVERT(varchar(8), DATEADD(SECOND, DATEDIFF(SECOND, ISNULL(QueueDate, StartDate), EndDate), 0), 8)