Why Early Code Review is Important for Database Deployments

  • Kendra Little

    SSC Enthusiast

    Points: 117

    Comments posted to this topic are about the item Why Early Code Review is Important for Database Deployments

  • roger.plowman

    SSChampion

    Points: 10210

    Code review is wonderful. Wish I could get it. Code review is impossible for lone wolf developers like me because there literally is no one else who can review my code. I'm the only programmer in the entire company.

    So I make due with TDD and quick fix roll-outs since another luxury I don't have is anyone who can beta test. Sigh. The reality of working for a company so lean it's almost anorexic.

    Lone wolves have to take the bad with the good I suppose. 🙂

  • Rod at work

    SSC-Dedicated

    Points: 33199

    I have never been fortunate enough to work for someone who does code reviews. Even in my current job, with lots of developers and 3 DBAs, there's no code review. Getting code reviews started is like pulling teeth.

    Kindest Regards, Rod Connect with me on LinkedIn.

  • David.Poole

    SSC Guru

    Points: 75308

    I think we have to ask what we want from a peer review.  I think there is value in someone validating the approach and the techniques.

    If you are looking for someone to find bugs then that is more what TDD/BDD is for.  There is an element of not being able to see the wood for the trees and a 2nd pair of eyes being useful but that depends on how detail orientated your peer reviewer is.

  • frederico_fonseca

    SSChampion

    Points: 14461

    ahhhh... who will code review my SP with 10k lines ..

  • Rod at work

    SSC-Dedicated

    Points: 33199

    You make a good point, David. I've wondered how much code makes a good code review. As Frederico suggests, reviewing a 10K stored procedure is probably too excessive. Whereas reviewing something like this, is silly

     

    int i = 0;

    Kindest Regards, Rod Connect with me on LinkedIn.

  • David.Poole

    SSC Guru

    Points: 75308

    I know, from working for a documentation company, that there are guidelines based on studies that say how much can be proofread within a given time period.

    I can't imagine that code reviews can be done properly any faster.

    I've found that linters help by enforcing code styling thus standardising what you be looking at.

  • frederico_fonseca

    SSChampion

    Points: 14461

    frederico_fonseca wrote:

    ahhhh... who will code review my SP with 10k lines ..

    Having said this in my shop some of the teams do do some level of code review - and on the teams that I work on I definitely do do it - both to see if my standards are followed and, mainly on the case of junior devs, to ensure that they didn't do anything "mad" or with potentially negative performance impact that needs to be reviewed/rewritten - and I do this when code is committed to SourceControl e.g. while still in dev mode.

  • Rod at work

    SSC-Dedicated

    Points: 33199

    David.Poole wrote:

    I know, from working for a documentation company, that there are guidelines based on studies that say how much can be proofread within a given time period.

    I can't imagine that code reviews can be done properly any faster.

    I've found that linters help by enforcing code styling thus standardising what you be looking at.

    I have no experience with linters. Where can I learn more about them?

    Kindest Regards, Rod Connect with me on LinkedIn.

  • David.Poole

    SSC Guru

    Points: 75308

    We use Flake8 for Python coding. It enforces a whole range of coding rules including coding style.

    I wouldn't call SQLPrompt a linter but its features achieve many of the same ends.

    Resharper, Stylecop etc works with C#.  Visual studio code has a number of linter plugins

Viewing 10 posts - 1 through 10 (of 10 total)

You must be logged in to reply to this topic. Login to reply