April 2, 2012 at 6:35 am
Either of the following will return the results you want. The second is the way I would do it and it has a much better execution plan cost.
;with calendar as
(select distinct calendarmonth, calendarYear, fiscalYear, fiscalMonth
from #calendar)
select c.calendarMonth,SUM(v.ChangeAmount)
from calendar c
LEFT JOIN #values v
on c.calendarMonth = v.Month and v.FiscalYear = @fiscalYear and v.type = @typeid
--WHERE v.FiscalYear = @fiscalYear
-- AND v.type = @typeID
group by c.calendarMonth, c.fiscalMonth
order by c.fiscalMonth
;with calendar as
(select calendarmonth, calendarYear, fiscalYear, fiscalMonth
from #calendar WHERE calendarDay = 1)
select c.calendarMonth,SUM(v.ChangeAmount)
from calendar c
LEFT JOIN #values v
on c.calendarMonth = v.Month and v.FiscalYear = @fiscalYear and v.type = @typeid
group by c.calendarMonth, c.fiscalMonth
order by c.fiscalMonth
I only included the first so you could easily see where you were going wrong.
My thought question: Have you ever been told that your query runs too fast?
My advice:
INDEXing a poor-performing query is like putting sugar on cat food. Yeah, it probably tastes better but are you sure you want to eat it?
The path of least resistance can be a slippery slope. Take care that fixing your fixes of fixes doesn't snowball and end up costing you more than fixing the root cause would have in the first place.
Need to UNPIVOT? Why not CROSS APPLY VALUES instead?[/url]
Since random numbers are too important to be left to chance, let's generate some![/url]
Learn to understand recursive CTEs by example.[/url]
[url url=http://www.sqlservercentral.com/articles/St
April 2, 2012 at 6:35 am
Just move the Where clause conditions into the join conditions, should do it.
;with calendar as
(select distinct calendarmonth, calendarYear, fiscalYear, fiscalMonth
from #calendar)
select
c.calendarMonth,
SUM(v.ChangeAmount)
from calendar c
LEFT JOIN #values v
on c.calendarMonth = v.Month
AND v.FiscalYear = @fiscalYear
AND v.type = @typeID
group by c.calendarMonth, c.fiscalMonth
order by c.fiscalMonth
Viewing 2 posts - 1 through 3 (of 3 total)
You must be logged in to reply to this topic. Login to reply