Copy results, update a few fields, reinsert

  • Matthew Cushing

    SSCrazy

    Points: 2898

    I'm trying to find an easier way of doing the following: We have a batch file that processes records into two tables, position, and position_detail. I'm trying to make a copy of the records entered, giving them new keys, update_date, and update_source columns. I've got it working using cursors with a few columns, but I need to get all of the columns for each table and one of the tables has almost 100 columns, so the cursor seemed to be getting huge.

    The added hitch is that the tables don't have autoincrementing for their pks, they have a stored proc they call to get the new id, and it gets recorded in another table.

    Here's the stored proc I have written that works pretty well, it's just going to get super unwieldy when I explode the cursor out to 100 fields.

    *had to take out the stored proc for work*

  • Gazareth

    One Orange Chip

    Points: 27737

    Hi Matthew,

    I'm guessing that the proc pace_master.dbo.GetUpLdNextInstance only works on one row at a time?

    Unless that can be changed you're stuck with the cursor, or a while loop, which won't really be any better.

  • Matthew Cushing

    SSCrazy

    Points: 2898

    Yeah, pretty much.

    I'm wondering if I can take the code in the stored proc and put it in a function that I can call?

    select a,b,fn(getNewIndex),d, e, f, getDate()

    plausible?

    Just seems there should be a way to copy the whole table and just replace a column.

  • Luis Cazares

    SSC Guru

    Points: 183587

    I'm sure there's a way to avoid the SPs to obtain the Next IDs, but here's a possible suggestion.

    I can't assure it will work, but it can give you an idea.

    --Removed

    EDIT: There was an unneeded SELECT

    Luis C.
    General Disclaimer:
    Are you seriously taking the advice and code from someone from the internet without testing it? Do you at least understand it? Or can it easily kill your server?

    How to post data/code on a forum to get the best help: Option 1 / Option 2
  • Gazareth

    One Orange Chip

    Points: 27737

    Like the idea Luis. Far as I can tell, it assumes the newly generated Id's are sequential?

  • Luis Cazares

    SSC Guru

    Points: 183587

    Yes, that's why I wanted to know what GetUpLdNextInstance is doing.

    I just noticed that I erased the first one on my code by accident. I'm putting it back on now.

    Luis C.
    General Disclaimer:
    Are you seriously taking the advice and code from someone from the internet without testing it? Do you at least understand it? Or can it easily kill your server?

    How to post data/code on a forum to get the best help: Option 1 / Option 2
  • Matthew Cushing

    SSCrazy

    Points: 2898

    I'm about to jump into a meeting, but I'll give it a shot when I get out.

    Essentially, you just got rid of the cursors, right?

  • Luis Cazares

    SSC Guru

    Points: 183587

    That's correct.

    It should perform much better, assuming the results are correct.

    Luis C.
    General Disclaimer:
    Are you seriously taking the advice and code from someone from the internet without testing it? Do you at least understand it? Or can it easily kill your server?

    How to post data/code on a forum to get the best help: Option 1 / Option 2
  • Matthew Cushing

    SSCrazy

    Points: 2898

    Going to give it a try now, but I'm unsure what this does:

    ROW_NUMBER() OVER( ORDER BY position_id) + @new_position_id - 1

  • Matthew Cushing

    SSCrazy

    Points: 2898

    I tried the code, but it's not giving each row it's own new id, it's giving all of the rows the same new id, and inserting them into the temp table, then throwing an error when I try to insert because it's a unique column. See attached.

  • Luis Cazares

    SSC Guru

    Points: 183587

    Matthew Cushing (8/30/2012)


    Going to give it a try now, but I'm unsure what this does:

    ROW_NUMBER() OVER( ORDER BY position_id) + @new_position_id - 1

    That's taking the new position_id and adding the Row Number minus 1 to avoid a gap between sets.

    I'm guessing your SP GetUpLdNextInstance is doing something like this:

    SELECT ISNULL( MAX( idcolumn), 0) + @Increment

    FROM IDsTable

    WHERE Table = @Table

    AND Column = @Column

    Am I correct?

    Are you sure the new_position_id is getting the same value on every row? Can you check what is it trying to insert?

    Luis C.
    General Disclaimer:
    Are you seriously taking the advice and code from someone from the internet without testing it? Do you at least understand it? Or can it easily kill your server?

    How to post data/code on a forum to get the best help: Option 1 / Option 2
  • Luis Cazares

    SSC Guru

    Points: 183587

    Please, review the code I sent as there are some errors I didn't see, mainly because I can't test the code. I hope you get the idea of what it's doing, so you can modify it and mantain it.

    For the repeating new id, could you please post the code you used?

    Luis C.
    General Disclaimer:
    Are you seriously taking the advice and code from someone from the internet without testing it? Do you at least understand it? Or can it easily kill your server?

    How to post data/code on a forum to get the best help: Option 1 / Option 2
  • Matthew Cushing

    SSCrazy

    Points: 2898

    Okay, I think I get it now. I moved things around so I'm using the Row_number() + @new_position_id to insert into the new_position_id field in the temp table, and it's incrementing beautifully. As an example, when I run it the first time, the new position id I'm getting is 920781 and the last one is 920813.

    The problem is, if I run it a second time, the first new position_id value it comes up with is 920782. I believe that the code that generates the new id's writes the id to a table so it knows what number to start with, so in our case, it's only generating one value.

    I'm wondering if it's as easy as just updating that table with the final value that I generate with your code.

    So:

    run stored proc to get new position id

    walk through the code to increment the code

    use the last position id to run an insert statement to the table we're keeping the max value in

    end

  • Luis Cazares

    SSC Guru

    Points: 183587

    I believe there's a problem with your insert trigger. It might be prepared for single row inserts. You might want to check it as it can be a general problem with your database.

    In a company where I worked we had something like that, however is was meant for something different.

    I hope that the table is not being used by several users at a time, because it will create a problem with duplicates.

    Luis C.
    General Disclaimer:
    Are you seriously taking the advice and code from someone from the internet without testing it? Do you at least understand it? Or can it easily kill your server?

    How to post data/code on a forum to get the best help: Option 1 / Option 2
  • Matthew Cushing

    SSCrazy

    Points: 2898

    I believe I got things working, but only partially. If I run it for today, it's fine. If I want to run it for a day last week or last month, it's checking the max value in the cursor, so it's not going to work.

    Essentially I either have to write two stored procs or rewrite this somehow. The problem comes in when I have a weekend or a holiday. Since I'm using the max value, that part is fine, as long as I am running today. If I go back and try to run a different day, the values it grabs won't be right, since it's a max function, it'll grab todays.

    I'm thinking of somehow putting in a conditional statement for the cursor select, or something along those lines. This seems like it should be so easy, but it really isn't. I'm just trying to copy two tables, give them new sequential id's, and insert the values with some updates along with them.

    *had to take out the stored proc.*

Viewing 15 posts - 1 through 15 (of 16 total)

You must be logged in to reply to this topic. Login to reply