You have a statement in there for printing the SQL string

print @lstr

Have a look at the statement it generates. You will see that there are quotes missing.

When you EXEC @lstr, it's executing in a different scope and the variables created in the body of the batch are not available to that scope.

Consider using sp_executesql, which supports...

It looks simple enough to get away with this, but check your performance:

INSERT INTO TableA

(ColA1,

ColA2,

ColA3)

SELECT ColB1,

SUM(ColB2) AS ColB2,

SUM(CASE WHEN ColB4 BETWEEN 0 AND 10 THEN ColB3 ELSE 0...

You would benefit from adopting table aliases. Really.

Before

INSERT INTO

dbo.tblClients(Client_Short_Name,Client_Long_Name,CountryCode,ClientID)

SELECT LEFT

(dbo.vwImportAllNewClientIDs.Client, 30),

dbo.vwImportAllNewClientIDs.Client,

dbo.vwImportAllNewClientIDs.CountryCode,

dbo.vwImportAllNewClientIDs.

ClientID

FROM dbo.vwImportAllNewClientIDs

After

INSERT INTO dbo.tblClients (Client_Short_Name, Client_Long_Name, CountryCode, ClientID)

SELECT LEFT(c.Client, 30), c.Client, c.CountryCode,...

It is a problem, which of course you can deal with because you've now read about the LEFT function in BOL.

So...

A Little Help Please (1/28/2009)

---

When I run you select statment I just get one row returned.

I think I found the issue, can you tell me how i would truncate the...

Yes - run this:SELECT convert(char(8),date) FROM DealbookV2.dbo.CheckDate

What happens when you run the stored...

Nobody has replied to this because it was difficult to read through all of the code. I've spent a few moments reformatting it, in particular putting in table aliases, and...

It's a problem with a subquery in the stored procedure dbo.procImportAllFiles.

Best post the sproc.

Thanks for the feedback David.

Grant Fritchey (1/27/2009)

---

As to writing coherently, I have a tendency to be thinking more about what I want to say rather than precisely how to say it. I've gone back...

GilaMonster (1/27/2009)

---

Bob Hovious (1/27/2009)

---

One more post towards 1000.... and close to the original topic here. How many people get annoyed by people who cut and paste data rather...

Bob Hovious (1/27/2009)

---

One more post towards 1000.... and close to the original topic here. How many people get annoyed by people who cut and paste data rather than...

ssetzer (1/27/2009)

---

Thank you both for your assistance. It appears that Mark's solution works well (and better than the loop solution I had attempted). Chris - your solution worked...

Use the WHERE clause instead?

DELETE b

FROM dbo.ADIM_ASSOCIATE_CONTRACTOR_RawImport b

INNER JOIN dbo.ADIM_ASSOCIATE_CONTRACTOR a

ON a.[EMPLOYEE_NUMBER] = b.[EMPLOYEE_NUMBER]

AND a.[ASSOCIATE_CONTRACTOR_FLAG] = b.[ASSOCIATE_CONTRACTOR_FLAG]

AND a.[DOM_INTL_IN] = b.[DOM_INTL_IN]

AND a.[CFC_NETWORK_ID] = b.[CFC_NETWORK_ID]

AND a.[NAME_PREFIX] = b.[NAME_PREFIX]

AND...