Website defect: Wrong post quoted when a post has been made since last page update.

  • When clicking quote to respond to a post when another post has occurred since you updated your page causes the wrong post to be quoted.

    Replication:

    1) Load a topic in browser with posts.

    2) Get another user to post on that comment in another browser.

    3) Click Quote button on one of the posts, but not the first, in the browser from Step 1 without refreshing the page.

    Result:

    Incorrect post quoted.

    Comment:

    This is not a huge issue, however, I and other posters have inadvertently quoted the wrong people as I did not check that the correct post was quoted. I am assuming the same is true for the others.

    Gaz

    -- Stop your grinnin' and drop your linen...they're everywhere!!!

  • This is commonly referred to around here as "the quote bug". It has been around a long time. I don't know if it is difficult to fix or just not a priority. As you said, it isn't that big of a deal but it is kind of annoying sometimes.

    _______________________________________________________________

    Need help? Help us help you.

    Read the article at http://www.sqlservercentral.com/articles/Best+Practices/61537/ for best practices on asking questions.

    Need to split a string? Try Jeff Modens splitter http://www.sqlservercentral.com/articles/Tally+Table/72993/.

    Cross Tabs and Pivots, Part 1 – Converting Rows to Columns - http://www.sqlservercentral.com/articles/T-SQL/63681/
    Cross Tabs and Pivots, Part 2 - Dynamic Cross Tabs - http://www.sqlservercentral.com/articles/Crosstab/65048/
    Understanding and Using APPLY (Part 1) - http://www.sqlservercentral.com/articles/APPLY/69953/
    Understanding and Using APPLY (Part 2) - http://www.sqlservercentral.com/articles/APPLY/69954/

  • Refiling with a bump. Not hopeful, but ever optimistic.

  • If I wasn't at a site with the ability to view the JavaScript and HTML restricted then I would have diagnosed the issue further. I might have been cheeky enough to have posted the fix 😉

    If I get a chance then I will have a further look at home. If I can provide any detailed information then I shall private message you Steve.

    Gaz

    -- Stop your grinnin' and drop your linen...they're everywhere!!!

  • Please do, though I'm not sure how easily it is to get a fix implemented. A few projects have taken everyone away for the time being.

  • I've had a brief look but without the code behind I cannot see anything obvious. Unsurprising really as if it was obvious then I am sure that one of your colleagues would have fixed it by now.

    I am happy to be flown around the world to look at it (no charge!!!) but I bet you'd have told me just to drop down the A14 to Cambridge 😉 (...or go somewhere else :-P)

    Gaz

    -- Stop your grinnin' and drop your linen...they're everywhere!!!

  • I suspect it's an issue in the query that grabs the post and renders the form rather than the JS.

  • Steve Jones - SSC Editor (9/11/2014)


    I suspect it's an issue in the query that grabs the post and renders the form rather than the JS.

    I'd put my money on the logic in the code behind basing it on the ASP.NET control # from the end.

    If they ever fix it I'd love to know what it was.

    Gaz

    -- Stop your grinnin' and drop your linen...they're everywhere!!!

  • Gary Varga (9/11/2014)


    Steve Jones - SSC Editor (9/11/2014)


    I suspect it's an issue in the query that grabs the post and renders the form rather than the JS.

    I'd put my money on the logic in the code behind basing it on the ASP.NET control # from the end.

    That's what I guessed too - counting from the end is just plain silly in very active thread, and a bit silly in any thread, unless the quote button (or equivalent) code holds a lock to prevent addition to the thread until it has copied the message being quoted.

    If they ever fix it I'd love to know what it was.

    So would I.

    Tom

  • My 2Cents and a workable workaround, always preview! Had few embarrassments in the past:blush:

    😎

  • TomThomson (9/25/2014)


    Gary Varga (9/11/2014)


    Steve Jones - SSC Editor (9/11/2014)


    I suspect it's an issue in the query that grabs the post and renders the form rather than the JS.

    I'd put my money on the logic in the code behind basing it on the ASP.NET control # from the end.

    That's what I guessed too - counting from the end is just plain silly in very active thread, and a bit silly in any thread, unless the quote button (or equivalent) code holds a lock to prevent addition to the thread until it has copied the message being quoted.

    If they ever fix it I'd love to know what it was.

    So would I.

    I have often guessed the code does some sort of counting of responses in the current thread. This seems completely strange. Why not just use the ThreadID. It is already on the page since each thread can be found using a permalink. The code behind should use that as the thread to retrieve when quoting. My guess is this issue has never been anywhere near the top of the list as the fix is likely pretty simple. 😛

    _______________________________________________________________

    Need help? Help us help you.

    Read the article at http://www.sqlservercentral.com/articles/Best+Practices/61537/ for best practices on asking questions.

    Need to split a string? Try Jeff Modens splitter http://www.sqlservercentral.com/articles/Tally+Table/72993/.

    Cross Tabs and Pivots, Part 1 – Converting Rows to Columns - http://www.sqlservercentral.com/articles/T-SQL/63681/
    Cross Tabs and Pivots, Part 2 - Dynamic Cross Tabs - http://www.sqlservercentral.com/articles/Crosstab/65048/
    Understanding and Using APPLY (Part 1) - http://www.sqlservercentral.com/articles/APPLY/69953/
    Understanding and Using APPLY (Part 2) - http://www.sqlservercentral.com/articles/APPLY/69954/

  • I couldn't imagine how this would be a problem, but there must be some counting.

    I've struggled with developers to fix it, which seems odd to me since it must be obvious what's wrong. Perhaps the code isn't simple to fix, but I suspect someone just doesn't want to break anything else.

  • Steve Jones - SSC Editor (9/25/2014)


    ...I suspect someone just doesn't want to break anything else.

    That is probably the biggest deal. Often times what seems like a simple fix causes enough changes to other related code that fixing it is a big can of worms. Especially if the code was not terribly well designed to handle as many enhancements as often happens. The "easy fix" might sometimes be hours and hours of refactoring other pieces. I only find this to happen every now and then. I usually try to make sure I am quoting the right response having been bitten by this in the past.

    _______________________________________________________________

    Need help? Help us help you.

    Read the article at http://www.sqlservercentral.com/articles/Best+Practices/61537/ for best practices on asking questions.

    Need to split a string? Try Jeff Modens splitter http://www.sqlservercentral.com/articles/Tally+Table/72993/.

    Cross Tabs and Pivots, Part 1 – Converting Rows to Columns - http://www.sqlservercentral.com/articles/T-SQL/63681/
    Cross Tabs and Pivots, Part 2 - Dynamic Cross Tabs - http://www.sqlservercentral.com/articles/Crosstab/65048/
    Understanding and Using APPLY (Part 1) - http://www.sqlservercentral.com/articles/APPLY/69953/
    Understanding and Using APPLY (Part 2) - http://www.sqlservercentral.com/articles/APPLY/69954/

  • Eirikur Eiriksson (9/25/2014)


    My 2Cents and a workable workaround, always preview! Had few embarrassments in the past:blush:

    😎

    ...or read what you are quoting!!!

    Gaz

    -- Stop your grinnin' and drop your linen...they're everywhere!!!

  • Gary Varga (9/25/2014)


    Eirikur Eiriksson (9/25/2014)


    My 2Cents and a workable workaround, always preview! Had few embarrassments in the past:blush:

    😎

    ...or read what you are quoting!!!

    Too much of an effort:-D

    😎

Viewing 15 posts - 1 through 15 (of 18 total)

You must be logged in to reply to this topic. Login to reply