Can post please be stored in nvarchar?

  • might be worth checking filenames of attachments - could also happen that someone adds a filename with special characters just in case it does not go through same code

  • frederico_fonseca wrote:

    might be worth checking filenames of attachments - could also happen that someone adds a filename with special characters just in case it does not go through same code

     

    Good call. I suppose an image / movie / whatever file could be named "👾.png". Thom, are you able to test that as well?

    Thanks, Solomon....

    SQL#https://SQLsharp.com/ ( SQLCLR library ofover 340 Functions and Procedures)
    Sql Quantum Lifthttps://SqlQuantumLift.com/ ( company )
    Sql Quantum Leaphttps://SqlQuantumLeap.com/ ( blog )
    Info sitesCollations     •     Module Signing     •     SQLCLR

  • Thom A wrote:

    Yep, I amended everything I could. Noticed no loss of characters, so it appears that everything does go through that one line that you highlighted for change.

    Thanks again!

     

    Excellent. I posted the PR last night:

    Prevent Unicode conversion to 8-bit code page in wp-db.php

     

    And I just checked the schema and can't find any columns of the following datatypes:

    • DATE
    • TIME
    • DATETIMEOFFSET
    • UNIQUEIDENTIFIER
    • SQL_VARIANT
    • DATETIME (all "timestamps" are stored as DATETIME2)

    There are only 11 date columns (technically 14, but 3 of them have a duplicate in GMT), and some appear to be non-updatable (e.g. "registered_date").

    So that reduces the number of potential issues.


    Looking at the schema I found other areas that should be tested, though I am not asking you, Thom, to do that as you have already tested a lot. I'm just listing them here (and will copy to the PR) as notes.

    Some dates that might not have been tested:

    1. Email User signing up / registering (signups table)
    2. User activating their registration (signups table)
    3. WordPress follower registration (registration_log table, I think)
    4. Updating a user (users table)
    5. Creating / Updating a link (links table)
    6. Updating blog metadata / appearance / layout / etc (blog_versions table)
    7. Creating / updating blogs on a multi-site installation (blogs table)

     

    Some string columns that might not have been tested:

    1. Terms (are these Categories? they have a "slug" and a taxonomy that includes a "description")  (terms and term_taxonomy tables)
    2. Comments:  "author" (comments table)
    3. Links: "name", "description", and "notes" (links table)
    4. Options? "name" (options table)
    5. Posts: "name" (different from "title"), "excerpt", "password" (posts table)
    6. Users: "login", "password", "nicename", "display_name" (users table)
    7. Signups (WordPress users, I think): "title" (their blog title, I think) (signups table)

     


    And, yer quite welcome 🙂 .

     

    Take care, Solomon...

    SQL#https://SQLsharp.com/ ( SQLCLR library ofover 340 Functions and Procedures)
    Sql Quantum Lifthttps://SqlQuantumLift.com/ ( company )
    Sql Quantum Leaphttps://SqlQuantumLeap.com/ ( blog )
    Info sitesCollations     •     Module Signing     •     SQLCLR

Viewing 3 posts - 16 through 18 (of 18 total)

You must be logged in to reply to this topic. Login to reply