SQL Clone
SQLServerCentral is supported by Redgate
 
Log in  ::  Register  ::  Not logged in
 
 
 


Syntax Error with Trigger


Syntax Error with Trigger

Author
Message
jdbrown239
jdbrown239
SSC Eights!
SSC Eights! (880 reputation)SSC Eights! (880 reputation)SSC Eights! (880 reputation)SSC Eights! (880 reputation)SSC Eights! (880 reputation)SSC Eights! (880 reputation)SSC Eights! (880 reputation)SSC Eights! (880 reputation)

Group: General Forum Members
Points: 880 Visits: 427
Hi
I have a syntax error I can't figure out. It's probably simple but I don't see it. Any suggestions?

[code = "sql"]CREATE TRIGGER Trigger_20321 ON FACT_CUST_GRP_ICM_MO
AFTER DELETE

AS
/* DELETE trigger on FACT_CUST_GRP_ICM_MO */
/* default body for Trigger_20321 */
BEGIN
DECLARE @numrows int,
@nullcnt int,
@validcnt int,
@INSFACT_GRP_PROD_ICM_MO_SK char(100),
@errno int,
@errmsg varchar(255)

SELECT @numrows = @@rowcount


RETURN
error:
raiserror (@errno, @errmsg)
rollback transaction
END

go [code]

Msg 102, Level 15, State 1, Procedure Trigger_20321, Line 21
Incorrect syntax near ')'.


The error is in line: raiserror (@errno, @errmsg)
Sean Lange
Sean Lange
SSC Guru
SSC Guru (62K reputation)SSC Guru (62K reputation)SSC Guru (62K reputation)SSC Guru (62K reputation)SSC Guru (62K reputation)SSC Guru (62K reputation)SSC Guru (62K reputation)SSC Guru (62K reputation)

Group: General Forum Members
Points: 62025 Visits: 17954
jdbrown239 (5/9/2014)
Hi
I have a syntax error I can't figure out. It's probably simple but I don't see it. Any suggestions?

[code = "sql"]CREATE TRIGGER Trigger_20321 ON FACT_CUST_GRP_ICM_MO
AFTER DELETE

AS
/* DELETE trigger on FACT_CUST_GRP_ICM_MO */
/* default body for Trigger_20321 */
BEGIN
DECLARE @numrows int,
@nullcnt int,
@validcnt int,
@INSFACT_GRP_PROD_ICM_MO_SK char(100),
@errno int,
@errmsg varchar(255)

SELECT @numrows = @@rowcount


RETURN
error:
raiserror (@errno, @errmsg)
rollback transaction
END

go [code]

Msg 102, Level 15, State 1, Procedure Trigger_20321, Line 21
Incorrect syntax near ')'.


The error is in line: raiserror (@errno, @errmsg)


What are you trying to do in this trigger? It looks like something that is partially started and never finished. What are all the variables? You do realize they are all NULL right? This has the look of being a trigger that is not designed to handle multiple rows. I am also scared when I see named code blocks. This is an indication you are planning on using a goto. We can handle errors far more gracefully than that these days. You might want to look at try-catch.

_______________________________________________________________

Need help? Help us help you.

Read the article at http://www.sqlservercentral.com/articles/Best+Practices/61537/ for best practices on asking questions.

Need to split a string? Try Jeff Modens splitter.

Cross Tabs and Pivots, Part 1 – Converting Rows to Columns
Cross Tabs and Pivots, Part 2 - Dynamic Cross Tabs
Understanding and Using APPLY (Part 1)
Understanding and Using APPLY (Part 2)
Go


Permissions

You can't post new topics.
You can't post topic replies.
You can't post new polls.
You can't post replies to polls.
You can't edit your own topics.
You can't delete your own topics.
You can't edit other topics.
You can't delete other topics.
You can't edit your own posts.
You can't edit other posts.
You can't delete your own posts.
You can't delete other posts.
You can't post events.
You can't edit your own events.
You can't edit other events.
You can't delete your own events.
You can't delete other events.
You can't send private messages.
You can't send emails.
You can read topics.
You can't vote in polls.
You can't upload attachments.
You can download attachments.
You can't post HTML code.
You can't edit HTML code.
You can't post IFCode.
You can't post JavaScript.
You can post emoticons.
You can't post or upload images.

Select a forum

































































































































































SQLServerCentral


Search