SQL Clone
SQLServerCentral is supported by Redgate
 
Log in  ::  Register  ::  Not logged in
 
 
 


Please assist dynamic selection of column not working


Please assist dynamic selection of column not working

Author
Message
masangombali2
masangombali2
Forum Newbie
Forum Newbie (9 reputation)Forum Newbie (9 reputation)Forum Newbie (9 reputation)Forum Newbie (9 reputation)Forum Newbie (9 reputation)Forum Newbie (9 reputation)Forum Newbie (9 reputation)Forum Newbie (9 reputation)

Group: General Forum Members
Points: 9 Visits: 32
ALTER PROCEDURE [dbo].[OtherCases]
@ctype NVARCHAR(24)

AS

BEGIN

declare @colname varchar(100);
declare @strQry Nvarchar(1000);


SET @colname = (SELECT COLUMN_NAME from INFORMATION_SCHEMA.COLUMNS
WHERE COLUMN_NAME like '%' + @ctype + '%'
AND COLUMN_NAME like '%Page_Count%');


SELECT @strQry = N'SELECT originalName, '+@colname +', contentRepoHandle
FROM dbo.CE_table y, dbo.DSObject_table x
WHERE x.handle_id =y.ce_key AND
contentRepoHandle like % '+@ctype+ '% AND contentRepoHandle like %pdf%';

exec sp_executesql @strQry;

END

I call the procedure

exec Othercases 'domestic'

Error : invalid character next to domestic

Thanks.
Gianluca Sartori
Gianluca Sartori
SSCrazy Eights
SSCrazy Eights (9.9K reputation)SSCrazy Eights (9.9K reputation)SSCrazy Eights (9.9K reputation)SSCrazy Eights (9.9K reputation)SSCrazy Eights (9.9K reputation)SSCrazy Eights (9.9K reputation)SSCrazy Eights (9.9K reputation)SSCrazy Eights (9.9K reputation)

Group: General Forum Members
Points: 9872 Visits: 13350
You're missing quotation marks around the second WHERE predicate:


contentRepoHandle like % '+@ctype+ '%



should be


contentRepoHandle like ''%'+@ctype+ '%''



The same applies to %pdf%

--Gianluca Sartori

How to post T-SQL questions
spaghettidba.com
@spaghettidba
Sean Lange
Sean Lange
One Orange Chip
One Orange Chip (26K reputation)One Orange Chip (26K reputation)One Orange Chip (26K reputation)One Orange Chip (26K reputation)One Orange Chip (26K reputation)One Orange Chip (26K reputation)One Orange Chip (26K reputation)One Orange Chip (26K reputation)

Group: General Forum Members
Points: 26129 Visits: 17539
And you need to parameterize your dynamic sql. What you are doing is directly executing a parameter to your proc. This is the text definition of sql injection.

See if this works for you.


SELECT @strQry = N'SELECT originalName, '+@colname +', contentRepoHandle
FROM dbo.CE_table y, dbo.DSObject_table x
WHERE x.handle_id =y.ce_key AND
contentRepoHandle like %''@ctype''% AND contentRepoHandle like ''%pdf%''';

exec sp_executesql @strQry, N'@ctype nvarchar(24)', @ctype;



_______________________________________________________________

Need help? Help us help you.

Read the article at http://www.sqlservercentral.com/articles/Best+Practices/61537/ for best practices on asking questions.

Need to split a string? Try Jeff Modens splitter.

Cross Tabs and Pivots, Part 1 – Converting Rows to Columns
Cross Tabs and Pivots, Part 2 - Dynamic Cross Tabs
Understanding and Using APPLY (Part 1)
Understanding and Using APPLY (Part 2)
masangombali2
masangombali2
Forum Newbie
Forum Newbie (9 reputation)Forum Newbie (9 reputation)Forum Newbie (9 reputation)Forum Newbie (9 reputation)Forum Newbie (9 reputation)Forum Newbie (9 reputation)Forum Newbie (9 reputation)Forum Newbie (9 reputation)

Group: General Forum Members
Points: 9 Visits: 32
Thanks. I will try it.
Go


Permissions

You can't post new topics.
You can't post topic replies.
You can't post new polls.
You can't post replies to polls.
You can't edit your own topics.
You can't delete your own topics.
You can't edit other topics.
You can't delete other topics.
You can't edit your own posts.
You can't edit other posts.
You can't delete your own posts.
You can't delete other posts.
You can't post events.
You can't edit your own events.
You can't edit other events.
You can't delete your own events.
You can't delete other events.
You can't send private messages.
You can't send emails.
You can read topics.
You can't vote in polls.
You can't upload attachments.
You can download attachments.
You can't post HTML code.
You can't edit HTML code.
You can't post IFCode.
You can't post JavaScript.
You can post emoticons.
You can't post or upload images.

Select a forum

































































































































































SQLServerCentral


Search