Click here to monitor SSC
SQLServerCentral is supported by Redgate
 
Log in  ::  Register  ::  Not logged in
 
 
 


Stored procedure working very slow


Stored procedure working very slow

Author
Message
Sean Lange
Sean Lange
SSCoach
SSCoach (16K reputation)SSCoach (16K reputation)SSCoach (16K reputation)SSCoach (16K reputation)SSCoach (16K reputation)SSCoach (16K reputation)SSCoach (16K reputation)SSCoach (16K reputation)

Group: General Forum Members
Points: 16673 Visits: 17032
huum (7/18/2013)
No no as you mentioned about un necessary repetative part of SP, thats what i meant


Ahh gotcha. ;-)

Consider this piece of code.


INSERT INTO @OfficeAccess (lOffice)
SELECT map.loffice
FROM map_PatientToOffice map
INNER JOIN map_PatientAtOfficeToCustodian mapc ON mapc.lpatient = map.lpatient
AND mapc.loffice = map.loffice
INNER JOIN @PhysiciansAccess PA ON PA.lphysician = mapc.lPhysician
WHERE map.lpatient = @lPatient
--and PA.lPhysician is not null

UNION

SELECT map.loffice
FROM map_PatientToOffice map
LEFT JOIN map_PatientAtOfficeToCustodian mapc ON mapc.lpatient = map.lpatient
AND mapc.loffice = map.loffice
WHERE map.lpatient = @lPatient
AND isNull(mapc.lPhysician, 0) <= 0



Those two queries are VERY similar. I am assuming that since you used UNION you want to exclude duplicates?

I don't have a table to work with to test but I THINK this should do the same thing.


INSERT INTO @OfficeAccess (lOffice)
SELECT map.loffice
FROM map_PatientToOffice map
INNER JOIN map_PatientAtOfficeToCustodian mapc ON mapc.lpatient = map.lpatient
AND mapc.loffice = map.loffice
left /*INNER JOIN*/ @PhysiciansAccess PA ON PA.lphysician = mapc.lPhysician
WHERE map.lpatient = @lPatient
and (PA.lPhysician is not null or isNull(mapc.lPhysician, 0) <= 0)
group by map.loffice



Assuming that returns the same data this would be a lot simpler. I think you could do something similar to the first insert/union too.

_______________________________________________________________

Need help? Help us help you.

Read the article at http://www.sqlservercentral.com/articles/Best+Practices/61537/ for best practices on asking questions.

Need to split a string? Try Jeff Moden's splitter.

Cross Tabs and Pivots, Part 1 – Converting Rows to Columns
Cross Tabs and Pivots, Part 2 - Dynamic Cross Tabs
Understanding and Using APPLY (Part 1)
Understanding and Using APPLY (Part 2)
Go


Permissions

You can't post new topics.
You can't post topic replies.
You can't post new polls.
You can't post replies to polls.
You can't edit your own topics.
You can't delete your own topics.
You can't edit other topics.
You can't delete other topics.
You can't edit your own posts.
You can't edit other posts.
You can't delete your own posts.
You can't delete other posts.
You can't post events.
You can't edit your own events.
You can't edit other events.
You can't delete your own events.
You can't delete other events.
You can't send private messages.
You can't send emails.
You can read topics.
You can't vote in polls.
You can't upload attachments.
You can download attachments.
You can't post HTML code.
You can't edit HTML code.
You can't post IFCode.
You can't post JavaScript.
You can post emoticons.
You can't post or upload images.

Select a forum

































































































































































SQLServerCentral


Search