## calculating ratios

 Author Message michaelmfranz Valued Member Group: General Forum Members Points: 67 Visits: 43 Hello, I am trying to calculate a ratio, i am pretty sure the problem is in the line * SUM([SUMTOTALVOLUME])) FROM #t) * I am trying to do the ratio by TradeHour, but judging by how small the ratio numbers in my result set [RatioVolume] (dont add up to 1.0) it looks like the SUM([SUMTOTALVOLUME]) is across all trade hours (TradeHour) rather than the trade hour I want it to be over. What changes do i need to make to fix that? TIASELECT TradeHour ,AVG([NumCodes]) as [AVGNUMCODES] ,[MCLower] ,[MCUpper] ,SUM([TotalVolume]) AS [SUMTOTALVOLUME] ,(SUM([TotalVolume]) / AVG([NumCodes]) ) as [AVGVOLUME]INTO #t FROM [dbo].[EODVolumeStats] GROUP BY TradeHour, [MCLower],[MCUpper]SELECT #t.TradeHour ,#t.[MCLower] ,#t.[MCUpper] ,CONVERT(DECIMAL(18,4),[SUMTOTALVOLUME]/(SELECT CONVERT(DECIMAL(18,4),SUM([SUMTOTALVOLUME])) FROM #t)) as [RatioVolume] FROM #t GROUP BY #t.TradeHour, #t.SUMTOTALVOLUME, #t.MCLower, #t.MCUpper DROP TABLE #t dwain.c SSC-Forever Group: General Forum Members Points: 44121 Visits: 6431 In looking at this, I don't think you need to use a temp table. However in order to show you how, you'd need to provide:- DDL for your [EODVolumeStats] table- Some consumable sample data- Expected resultsHaving said that, if the only issue you're facing is that the summary is occuring over all trade hours of the day, and you only want it over specific hours, perhaps something like this can be used to trim the time period down to an hour.`DATEADD(hour, DATEDIFF(hour, 0, TradeHour), 0)` My mantra: No loops! No CURSORs! No RBAR! Hoo-uh!My thought question: Have you ever been told that your query runs too fast?My advice:INDEXing a poor-performing query is like putting sugar on cat food. Yeah, it probably tastes better but are you sure you want to eat it?The path of least resistance can be a slippery slope. Take care that fixing your fixes of fixes doesn't snowball and end up costing you more than fixing the root cause would have in the first place.Need to UNPIVOT? Why not CROSS APPLY VALUES instead?Since random numbers are too important to be left to chance, let's generate some!Learn to understand recursive CTEs by example.Splitting strings based on patterns can be fast!My temporal SQL musings: Calendar Tables, an Easter SQL, Time Slots and Self-maintaining, Contiguous Effective Dates in Temporal Tables michaelmfranz Valued Member Group: General Forum Members Points: 67 Visits: 43 Thank you for your interest, much apreciated. Yes you are right about temp tables, but i am a mere mortal compared to some here! :-) TradeHour represents hours of the dayMCLower & MCUpper represent a range of Market capitalisations in millions, the ranges do not overlapVolume represents trading volume of sharesThe ratios I am trying to calculate use EOD data (both historial and intraday hour snapshots) and the number of shares a company has to calculate a ratio so elevated trading volume can be determined by mulitplicationSo i need a matrix of Tradehour, MC range and a ratio multiplierIn the morning i want to know if the current volume is unusual. I know by the end of the day(comparing one day to the next), but i want to work that out intraday. Thats why am gathering stats across the market to work out what is high/low trading, because activity isnt uniform throughout the day in each market segment (blue chip, microcpap etc)Im limited to EOD data , I have already done this with Course of Sales data (with great help from this forum BTW)I can do this easily in .net code, but not SQL

## Permissions

 You can't post new topics. You can't post topic replies. You can't post new polls. You can't post replies to polls. You can't edit your own topics. You can't delete your own topics. You can't edit other topics. You can't delete other topics. You can't edit your own posts. You can't edit other posts. You can't delete your own posts. You can't delete other posts. You can't post events. You can't edit your own events. You can't edit other events. You can't delete your own events. You can't delete other events. You can't send private messages. You can't send emails. You can read topics. You can't vote in polls. You can't upload attachments. You can download attachments. You can't post HTML code. You can't edit HTML code. You can't post IFCode. You can't post JavaScript. You can post emoticons. You can't post or upload images.

##### Select a forum
 SQL Server 2017      SQL Server 2017 - Administration      SQL Server 2017 - Development SQL Server 2016      SQL Server 2016 - Administration      SQL Server 2016 - Development and T-SQL SQL Server 2014      Administration - SQL Server 2014      Development - SQL Server 2014 SQL Server 2012      SQL 2012 - General      SQL Server 2012 - T-SQL SQL Server vNext      SQL Server 15 - Administration      SQL Server 15 - Development SQL Server 2008      SQL Server 2008 - General      T-SQL (SS2K8)      June 2007 CTP      Working with Oracle      July CTP      SQL Server Newbies      Security (SS2K8)      SQL Server 2008 High Availability      SQL Server 2008 Administration      Data Corruption (SS2K8 / SS2K8 R2)      SQL Server 2008 Performance Tuning Cloud Computing      SQL Azure - Development      SQL Azure - Administration      Amazon AWS and other cloud vendors      General Cloud Computing Questions      CosmosDB      Azure Data Lake      Azure Machine Learning Reporting Services      Reporting Services      Reporting Services 2005 Administration      Reporting Services 2005 Development      Reporting Services 2008/R2 Administration      Reporting Services 2008 Development      SSRS 2012      SSRS 2014      SSRS 2016 Programming      Connecting      General      SMO/RMO/DMO      XML      Service Broker      Powershell      Testing      TFS/Data Dude/DBPro      SSDT      Continuous Integration, Deployment, and Delivery      R Services and R Language Data Warehousing      Integration Services      Strategies and Ideas      Analysis Services      Data Transformation Services (DTS)      Performance Point      Data Mining      PowerPivot      R language      Machine Learning Database Design      Disaster Recovery      Design Ideas and Questions      Relational Theory      Hardware      Virtualization      Security and Auditing SQLServerCentral.com      Anything that is NOT about SQL!      Contests!      Editorials      SQLServerCentral.com Announcements      SQLServerCentral.com Website Issues      Suggestions      Tag Issues with Content      Podcast Feedback      SQLServerCentral.com Test Forum      Articles Requested SQL Server 2005      Administering      Backups      Business Intelligence      CLR Integration and Programming.      Data Corruption      Development      Working with Oracle      SQL Server 2005 Compact Edition      SQL Server 2005 General Discussion      SQL Server 2005 Security      SQL Server 2005 Strategies      SS2K5 Replication      SQL Server Express      SQL Server 2005 Performance Tuning      SQL Server 2005 Integration Services      T-SQL (SS2K5)      SQL Server Newbies SQL Server 7,2000      Administration      Backups      Data Corruption      General      Globalization      In The Enterprise      Working with Oracle      Security      Strategies      SQL Server Newbies      Service Packs      SQL Server CE      Performance Tuning      Replication      Sarbanes-Oxley      T-SQL      SQL Server Agent SQL Server and other platforms      MySQL      Oracle      PostgreSQL      DB2      SQL Server and Sharepoint Older Versions of SQL (v6.5, v6.0, v4.2)      Older Versions of SQL (v6.5, v6.0, v4.2) Career      Certification      Employers and Employees      Events      Job Postings      Resumes and Job Hunters      Presentations and Speaking      Retired Members Testing Center      SQL Server Security Skills      Question of the Day (QOD) Microsoft Access      Microsoft Access Products and Books      Third Party Products         SQLCentric         Extreme Technologies.         Innovartis         Embarcadero         SQL Sentry         Sonasoft         Golden Gate Software         Idera         Lumigent         Red Gate Software         ApexSQL         Quest Software         CA      Discussions about Books         Discuss Programming Books          Discuss XML Books          Discuss T-SQL Books          Discuss Data Warehousing Books          Discuss DTS Books          Discuss SQL Server 2000 Books         Discuss SQL Server 7.0 Books Notification Services      Administration Article Discussions Future Versions      SQL 12