SQL Clone
SQLServerCentral is supported by Redgate
 
Log in  ::  Register  ::  Not logged in
 
 
 


Conditional Delete not working


Conditional Delete not working

Author
Message
dwilliscp
dwilliscp
SSC Eights!
SSC Eights! (808 reputation)SSC Eights! (808 reputation)SSC Eights! (808 reputation)SSC Eights! (808 reputation)SSC Eights! (808 reputation)SSC Eights! (808 reputation)SSC Eights! (808 reputation)SSC Eights! (808 reputation)

Group: General Forum Members
Points: 808 Visits: 775
Why does this delete all my records, reguardless of company?

delete Plant_Master
where EXISTS(Select Plant_CD from Plant_Master where company like 'MSC')
Eugene Elutin
Eugene Elutin
SSCarpal Tunnel
SSCarpal Tunnel (5K reputation)SSCarpal Tunnel (5K reputation)SSCarpal Tunnel (5K reputation)SSCarpal Tunnel (5K reputation)SSCarpal Tunnel (5K reputation)SSCarpal Tunnel (5K reputation)SSCarpal Tunnel (5K reputation)SSCarpal Tunnel (5K reputation)

Group: General Forum Members
Points: 4964 Visits: 5478
dwilliscp (11/14/2012)
Why does this delete all my records, reguardless of company?

delete Plant_Master
where EXISTS(Select Plant_CD from Plant_Master where company like 'MSC')



does at least one row exist in Plant_Master where company = 'MSC'?
If so then EXISTS(Select Plant_CD from Plant_Master where company like 'MSC') evaluates to true and all records from Plant_Master are deleted.

If you want to delete records from Plant_Master where company = 'MCS' then you need to do :
delete Plant_Master
where company = 'MSC'

If you want to delete records from Plant_Master where company strats from 'MCS' then you need to do :
delete Plant_Master
where company LIKE 'MSC%'

If you want to delete records from Plant_Master where company contains 'MCS' then you need to do :
delete Plant_Master
where company LIKE '%MSC%'

_____________________________________________
"The only true wisdom is in knowing you know nothing"
"O skol'ko nam otkrytiy chudnyh prevnosit microsofta duh!":-D
(So many miracle inventions provided by MS to us...)

How to post your question to get the best and quick help
dwilliscp
dwilliscp
SSC Eights!
SSC Eights! (808 reputation)SSC Eights! (808 reputation)SSC Eights! (808 reputation)SSC Eights! (808 reputation)SSC Eights! (808 reputation)SSC Eights! (808 reputation)SSC Eights! (808 reputation)SSC Eights! (808 reputation)

Group: General Forum Members
Points: 808 Visits: 775
Hmm thought it would do a line by line check.. turns out that my thought process was off anyway. Given that we have data here that is not in SAP, I can not do any conditional deletes. I will have to use the update statement to update existing records, instead of deleting and re-loading.

However if the plan had not changed.. then the delete statement would still not have worked quite right. I still wonder how that would have worked. The idea was to have it select all records that existed and refresh only those... to get the list you would have to run the following SQL statement:

Select plant.Plant
from file_Plants as plant
left outer join Plant_Master as mas
on mas.Plant_CD = plant.Plant
where NOT(mas.Plant_CD is NULL)
Sean Lange
Sean Lange
One Orange Chip
One Orange Chip (25K reputation)One Orange Chip (25K reputation)One Orange Chip (25K reputation)One Orange Chip (25K reputation)One Orange Chip (25K reputation)One Orange Chip (25K reputation)One Orange Chip (25K reputation)One Orange Chip (25K reputation)

Group: General Forum Members
Points: 25897 Visits: 17517
dwilliscp (11/14/2012)
Hmm thought it would do a line by line check.. turns out that my thought process was off anyway. Given that we have data here that is not in SAP, I can not do any conditional deletes. I will have to use the update statement to update existing records, instead of deleting and re-loading.

However if the plan had not changed.. then the delete statement would still not have worked quite right. I still wonder how that would have worked. The idea was to have it select all records that existed and refresh only those... to get the list you would have to run the following SQL statement:

Select plant.Plant
from file_Plants as plant
left outer join Plant_Master as mas
on mas.Plant_CD = plant.Plant
where NOT(mas.Plant_CD is NULL)


Just my personal preference but I find this type of check to be far easier to read with a positive test.


where mas.Plant_CD IS NOT NULL



Of course in the case of this specific query why not just change the left join to an inner join since that is the result set you want to find. Cool

_______________________________________________________________

Need help? Help us help you.

Read the article at http://www.sqlservercentral.com/articles/Best+Practices/61537/ for best practices on asking questions.

Need to split a string? Try Jeff Modens splitter.

Cross Tabs and Pivots, Part 1 – Converting Rows to Columns
Cross Tabs and Pivots, Part 2 - Dynamic Cross Tabs
Understanding and Using APPLY (Part 1)
Understanding and Using APPLY (Part 2)
dwilliscp
dwilliscp
SSC Eights!
SSC Eights! (808 reputation)SSC Eights! (808 reputation)SSC Eights! (808 reputation)SSC Eights! (808 reputation)SSC Eights! (808 reputation)SSC Eights! (808 reputation)SSC Eights! (808 reputation)SSC Eights! (808 reputation)

Group: General Forum Members
Points: 808 Visits: 775
True, just a personal quirk. I find that when I am trying to think through something... I tend to code the thought process. Thus the outer join filtering where not NULL.


Sean Lange (11/14/2012)
dwilliscp (11/14/2012)
Hmm thought it would do a line by line check.. turns out that my thought process was off anyway. Given that we have data here that is not in SAP, I can not do any conditional deletes. I will have to use the update statement to update existing records, instead of deleting and re-loading.

However if the plan had not changed.. then the delete statement would still not have worked quite right. I still wonder how that would have worked. The idea was to have it select all records that existed and refresh only those... to get the list you would have to run the following SQL statement:

Select plant.Plant
from file_Plants as plant
left outer join Plant_Master as mas
on mas.Plant_CD = plant.Plant
where NOT(mas.Plant_CD is NULL)


Just my personal preference but I find this type of check to be far easier to read with a positive test.


where mas.Plant_CD IS NOT NULL



Of course in the case of this specific query why not just change the left join to an inner join since that is the result set you want to find. Cool

Eugene Elutin
Eugene Elutin
SSCarpal Tunnel
SSCarpal Tunnel (5K reputation)SSCarpal Tunnel (5K reputation)SSCarpal Tunnel (5K reputation)SSCarpal Tunnel (5K reputation)SSCarpal Tunnel (5K reputation)SSCarpal Tunnel (5K reputation)SSCarpal Tunnel (5K reputation)SSCarpal Tunnel (5K reputation)

Group: General Forum Members
Points: 4964 Visits: 5478
dwilliscp (11/14/2012)
True, just a personal quirk. I find that when I am trying to think through something... I tend to code the thought process. Thus the outer join filtering where not NULL.


Sean Lange (11/14/2012)
dwilliscp (11/14/2012)
Hmm thought it would do a line by line check.. turns out that my thought process was off anyway. Given that we have data here that is not in SAP, I can not do any conditional deletes. I will have to use the update statement to update existing records, instead of deleting and re-loading.

However if the plan had not changed.. then the delete statement would still not have worked quite right. I still wonder how that would have worked. The idea was to have it select all records that existed and refresh only those... to get the list you would have to run the following SQL statement:

Select plant.Plant
from file_Plants as plant
left outer join Plant_Master as mas
on mas.Plant_CD = plant.Plant
where NOT(mas.Plant_CD is NULL)


Just my personal preference but I find this type of check to be far easier to read with a positive test.


where mas.Plant_CD IS NOT NULL



Of course in the case of this specific query why not just change the left join to an inner join since that is the result set you want to find. Cool


I wouldn't call it "personal preference". It's wrong type of join, which can lead to worse performance.
That is exactly what INNER JOIN is for, so better to be written as

Select plant.Plant
from file_Plants as plant
inner join Plant_Master as mas
on mas.Plant_CD = plant.Plant

Now, as you select nothing from Plant_Master, you may find that the following will perform even better than INNER JOIN:

Select plant.Plant
from file_Plants as plant
where exists (select 1 from Plant_Master as mas
where mas.Plant_CD = plant.Plant)

Above two samples, can be actually called as "personal preference", but again, you may find that EXIST will give slightly better performance, as query processor will know that you need nothing from Plant_Master table.

_____________________________________________
"The only true wisdom is in knowing you know nothing"
"O skol'ko nam otkrytiy chudnyh prevnosit microsofta duh!":-D
(So many miracle inventions provided by MS to us...)

How to post your question to get the best and quick help
dwilliscp
dwilliscp
SSC Eights!
SSC Eights! (808 reputation)SSC Eights! (808 reputation)SSC Eights! (808 reputation)SSC Eights! (808 reputation)SSC Eights! (808 reputation)SSC Eights! (808 reputation)SSC Eights! (808 reputation)SSC Eights! (808 reputation)

Group: General Forum Members
Points: 808 Visits: 775
Ok.. but how do you put that select logic into a delete statement?
Sean Lange
Sean Lange
One Orange Chip
One Orange Chip (25K reputation)One Orange Chip (25K reputation)One Orange Chip (25K reputation)One Orange Chip (25K reputation)One Orange Chip (25K reputation)One Orange Chip (25K reputation)One Orange Chip (25K reputation)One Orange Chip (25K reputation)

Group: General Forum Members
Points: 25897 Visits: 17517
dwilliscp (11/15/2012)
Ok.. but how do you put that select logic into a delete statement?


Change the word "select" to "delete".

_______________________________________________________________

Need help? Help us help you.

Read the article at http://www.sqlservercentral.com/articles/Best+Practices/61537/ for best practices on asking questions.

Need to split a string? Try Jeff Modens splitter.

Cross Tabs and Pivots, Part 1 – Converting Rows to Columns
Cross Tabs and Pivots, Part 2 - Dynamic Cross Tabs
Understanding and Using APPLY (Part 1)
Understanding and Using APPLY (Part 2)
Sean Lange
Sean Lange
One Orange Chip
One Orange Chip (25K reputation)One Orange Chip (25K reputation)One Orange Chip (25K reputation)One Orange Chip (25K reputation)One Orange Chip (25K reputation)One Orange Chip (25K reputation)One Orange Chip (25K reputation)One Orange Chip (25K reputation)

Group: General Forum Members
Points: 25897 Visits: 17517
Eugene Elutin (11/14/2012)


I wouldn't call it "personal preference". It's wrong type of join, which can lead to worse performance.
That is exactly what INNER JOIN is for, so better to be written as



My preference I meant was to conditional check, I did point out that it should be an inner join.

The personal preference was to use

where mas.Plant_CD is NOT NULL



instead of


where NOT(mas.Plant_CD is NULL)



_______________________________________________________________

Need help? Help us help you.

Read the article at http://www.sqlservercentral.com/articles/Best+Practices/61537/ for best practices on asking questions.

Need to split a string? Try Jeff Modens splitter.

Cross Tabs and Pivots, Part 1 – Converting Rows to Columns
Cross Tabs and Pivots, Part 2 - Dynamic Cross Tabs
Understanding and Using APPLY (Part 1)
Understanding and Using APPLY (Part 2)
dwilliscp
dwilliscp
SSC Eights!
SSC Eights! (808 reputation)SSC Eights! (808 reputation)SSC Eights! (808 reputation)SSC Eights! (808 reputation)SSC Eights! (808 reputation)SSC Eights! (808 reputation)SSC Eights! (808 reputation)SSC Eights! (808 reputation)

Group: General Forum Members
Points: 808 Visits: 775
Ok, thanks for the help :-D
Go


Permissions

You can't post new topics.
You can't post topic replies.
You can't post new polls.
You can't post replies to polls.
You can't edit your own topics.
You can't delete your own topics.
You can't edit other topics.
You can't delete other topics.
You can't edit your own posts.
You can't edit other posts.
You can't delete your own posts.
You can't delete other posts.
You can't post events.
You can't edit your own events.
You can't edit other events.
You can't delete your own events.
You can't delete other events.
You can't send private messages.
You can't send emails.
You can read topics.
You can't vote in polls.
You can't upload attachments.
You can download attachments.
You can't post HTML code.
You can't edit HTML code.
You can't post IFCode.
You can't post JavaScript.
You can post emoticons.
You can't post or upload images.

Select a forum

































































































































































SQLServerCentral


Search