To tell the truth, I usually add logins in SQL Server Management Studio though I have created scripts using CREATE LOGIN. I haven't had any particular problem with it and I figured I might as well use the new stuff since sp_addlogin will go away in a future version (maybe SQL 2008?).