try taking the single quotes away from around your parameters

CREATE Procedure [dbo].[SetDefaultDatabase]

@LoginString NVARCHAR(50),

@DatabaseString NVARCHAR(50)

As

Begin

Set NoCount On

Exec sp_defaultdb @loginame=@LoginString, @defdb=@DatabaseString

End

GO