Interesting problem for the "Running Total/Quirky Update" method of removing cursors

SQLServerCentral is supported by Red Gate Software Ltd.

Popular Topics

Home

Members

Calendar

Who's On

Home » SQL Server 7,2000 » T-SQL » Interesting problem for the "Running...

14 posts, Page 1 of 2

1 2 »»

Interesting problem for the "Running Total/Quirky Update" method of removing cursors

Rate Topic

Display Mode

Topic Options

Author

Message

Robb Melancon

Posted Thursday, May 20, 2010 6:49 AM

Grasshopper

Group: General Forum Members
Last Login: Friday, March 25, 2011 3:26 PM
Points: 22, Visits: 80

This is an extension to another topic I had posted but I decided to split it off as the problem is different than the original problem of replacing the cursor/while loop with a faster method.
So I am stuck on a problem I am having using the "quirky update" method for replacing a cursor/while loop. The root of the issue is that the update compares row n to row n+1 and updates the contents of row n+1. What I need is a comparison of row n to row n+1 but then update the contents of row n.

Here is the code that displays the problem.

create table #DMVRunningPerformance (
	Symbol_vc varchar(255),
	DayID_in int,
	MV float,
	DailyPerf float null,
	RunningPerf float null)
		
	CREATE CLUSTERED INDEX [indexdown] ON #DMVRunningPerformance 
		(
			[Symbol_vc] ASC,
			[DayID_in] DESC
		)
	WITH (SORT_IN_TEMPDB = OFF, IGNORE_DUP_KEY = OFF, DROP_EXISTING = OFF, ONLINE = OFF) ON [PRIMARY]
			
insert into #DMVRunningPerformance 	
 values ('IBM',75006,201048.8987,NULL,NULL)
insert into #DMVRunningPerformance 	
 values ('IBM',75005,200841.5658,NULL,NULL)
insert into #DMVRunningPerformance 	
 values ('IBM',75004,200321.7043,NULL,NULL)
insert into #DMVRunningPerformance 	
 values ('IBM',75003,201120.0467,NULL,NULL)
insert into #DMVRunningPerformance 	
 values ('IBM',75002,201779.8805,NULL,NULL)
insert into #DMVRunningPerformance 	
 values ('IBM',75001,201651.3917,NULL,NULL)
insert into #DMVRunningPerformance 	
 values ('IBM',75000,201651.3917,NULL,NULL)
	
declare @NewGroup_bt bit=1,
		@DailyPerformance float,
		@RunningPerformance float,
		@NDMarketValue float
		
update #DMVRunningPerformance
	set 
		@DailyPerformance=CASE WHEN @NewGroup_bt=1 THEN 0 ELSE
							(@NDMarketValue-MV)/MV END,
		@RunningPerformance=CASE WHEN @NewGroup_bt=1 THEN 0 ELSE
							((1 + @RunningPerformance) * (1 + @DailyPerformance)) - 1 END,
		DailyPerf=@DailyPerformance,
		RunningPerf=@RunningPerformance,
		@NDMarketValue=MV,
		@NewGroup_bt=0
FROM #DMVRunningPerformance OPTION (MAXDOP 1)

select * from #DMVRunningPerformance

drop table #DMVRunningPerformance

Note that I can't change the order as it would completely change the performance numbers. I am trying to avoid having to roll through the set a second time to shift the numbers up. So to clarify, the MV of row n is compared to MV of row n+1 to get daily performance. This performance number (and the running performance) need to be stored in row n, not row n+ 1.

Thanks in advance,
Robb

Post #925065

Gopi Muluka

Posted Friday, May 21, 2010 6:48 AM

UDP Broadcaster

Group: General Forum Members
Last Login: Tuesday, August 07, 2012 6:19 PM
Points: 1,480, Visits: 262

Try this

create table #DMVRunningPerformance (
        Symbol_vc varchar(25),
        DayID_in int,
        MV float,
        DailyPerf float null,
        RunningPerf float null)
                
        CREATE CLUSTERED INDEX [indexdown] ON #DMVRunningPerformance 
                (
                        [Symbol_vc] ASC,
                        [DayID_in] DESC
                )
        WITH (SORT_IN_TEMPDB = OFF, IGNORE_DUP_KEY = OFF, DROP_EXISTING = OFF, ONLINE = OFF) ON [PRIMARY]
                        
insert into #DMVRunningPerformance      
 values ('IBM',75006,201048.8987,NULL,NULL)
insert into #DMVRunningPerformance      
 values ('IBM',75005,200841.5658,NULL,NULL)
insert into #DMVRunningPerformance      
 values ('IBM',75004,200321.7043,NULL,NULL)
insert into #DMVRunningPerformance      
 values ('IBM',75003,201120.0467,NULL,NULL)
insert into #DMVRunningPerformance      
 values ('IBM',75002,201779.8805,NULL,NULL)
insert into #DMVRunningPerformance      
 values ('IBM',75001,201651.3917,NULL,NULL)
insert into #DMVRunningPerformance      
 values ('IBM',75000,201651.3917,NULL,NULL)
        
declare @NewGroup_bt INT,
                @DailyPerformance float,
                @RunningPerformance float,
                @NDMarketValue float
set @NewGroup_bt =0;       
		set @RunningPerformance=0;

		update B 
        set 
			  	@NDMarketValue=B.MV,
				@DailyPerformance = (@NDMarketValue-C.MV)/C.MV 	,
				B.DailyPerf=@DailyPerformance,
				@RunningPerformance= ((1 + @DailyPerformance)*(1 + @RunningPerformance) ) - 1 ,
				@NewGroup_bt=@NewGroup_bt+1,
                B.RunningPerf=@RunningPerformance
				FROM #DMVRunningPerformance b 
				INNER JOIN #DMVRunningPerformance C
						ON b.DAYID_IN=C.DAYID_IN+1

select * from #DMVRunningPerformance


drop table #DMVRunningPerformance

Post #925912

ChrisM@Work

Posted Friday, May 21, 2010 7:43 AM

SSCertifiable

Group: General Forum Members
Last Login: Today @ 8:51 AM
Points: 5,608, Visits: 10,970

Robb, can you please confirm that you are running on SQL Server 7 or 2k?

^{“Write the query the simplest way. If through testing it becomes clear that the performance is inadequate, consider alternative query forms.” - Gail Shaw}

For fast, accurate and documented assistance in answering your questions, please read this article.
Understanding and using APPLY, (I) and (II) Paul White
Hidden RBAR: Triangular Joins / The "Numbers" or "Tally" Table: What it is and how it replaces a loop Jeff Moden
Exploring Recursive CTEs by Example Dwain Camps

Post #925954

Robb Melancon

Posted Friday, May 21, 2010 2:41 PM

Grasshopper

Group: General Forum Members
Last Login: Friday, March 25, 2011 3:26 PM
Points: 22, Visits: 80

Running SQL2008

Also Ten Centuries, your solution violates the rules of using the "Quirky Update" by using a Join. I'll add a link to the article on "Quirky Update".

[url]http://www.sqlservercentral.com/articles/T-SQL/68467/[\url]

I don't know that this method is ultimately what I will use as I am skeptical about using it in a production environment, but it is the quickest performing alternative to cursors that I have found.

Post #926283

Garadin

Posted Friday, May 21, 2010 3:54 PM

SSCommitted

Group: General Forum Members
Last Login: Wednesday, November 07, 2012 4:08 PM
Points: 1,525, Visits: 4,047

I'm still a little unclear on your requirements. Can you provide the results you are trying to get?

This is a guess and might be the whole thing you're trying to avoid, but what about changing the sort order to ASC on day_id and then using this:

update #DMVRunningPerformance
        set 
                @DailyPerformance=DailyPerf=CASE WHEN @NewGroup_bt=1 THEN 0 ELSE
                                                        (MV - @NDMarketValue)/ @NDMarketValue END,
                @RunningPerformance=RunningPerf=CASE WHEN @NewGroup_bt=1 THEN 0 ELSE
                                                        ((1 + @RunningPerformance) * (1 + @DailyPerformance)) - 1 END,
                @NDMarketValue=MV,
                @NewGroup_bt=0
FROM #DMVRunningPerformance OPTION (MAXDOP 1)

Seth Phelabaum

Consistency is only a virtue if you're not a screwup. Wink

Links: How to Post Sample Data :: Running Totals :: Tally Table :: Cross Tabs/Pivots :: String Concatenation

Post #926316

ChrisM@Work

Posted Monday, May 24, 2010 4:40 AM

SSCertifiable

Group: General Forum Members
Last Login: Today @ 8:51 AM
Points: 5,608, Visits: 10,970

Robb Melancon (5/21/2010)

Hi Robb

A recursive CTE will do the job. Like Seth, I'm unsure of which direction (relative to DayID_in) you wish to run the calculation for RunningPerf. Here's an example which should get you started:

;WITH Calculator AS (
	-- Anchor row, tr.Seq = 1
	SELECT thisrow.Seq, thisrow.Symbol_vc, thisrow.DayID_in, thisrow.MV, 
		DailyPerf = CAST((nextrow.MV-thisrow.MV)/thisrow.MV AS FLOAT), 
		RunningPerf = CAST(NULL AS FLOAT)
	FROM #OrderedData thisrow
	INNER JOIN #OrderedData nextrow ON nextrow.Seq = thisrow.Seq + 1
	WHERE thisrow.Seq = 1

	UNION ALL
	-- first recursion will be Seq = 2 (thisrow.Seq = 2, lastrow.Seq = 1)
	SELECT thisrow.Seq, thisrow.Symbol_vc, thisrow.DayID_in, thisrow.MV, 
		DailyPerf = CAST((nextrow.MV-thisrow.MV)/thisrow.MV AS FLOAT), 
		RunningPerf = lastrow.RunningPerf
	FROM Calculator lastrow
	INNER JOIN #OrderedData thisrow ON thisrow.Seq = lastrow.Seq + 1
	INNER JOIN #OrderedData nextrow ON nextrow.Seq = thisrow.Seq + 1 
)
SELECT Seq, Symbol_vc, DayID_in, MV, DailyPerf, RunningPerf 
FROM Calculator

Note that if you have a unique clustered index on the seq column, as in the example, the SELECT will run in a similar timeframe to a running totals update.
If you want to use the results of the SELECT to update another table, then you would be wise to run the results into another table rather than attempting an UPDATE FROM ... with the rCTE as a table source - performance can be poor.
The SELECT returns 6 of the 7 rows because of the INNER JOIN 'nextrow'. Logically you can't get a value for the last row in any case because it has no next row! However, you can make the row appear in your output by fiddling the join criteria.
Come back if you need help with this. The important point to remember about recursive CTE's is that only the result of the last iteration is 'exposed' to the next.

Cheers

ChrisM

^{“Write the query the simplest way. If through testing it becomes clear that the performance is inadequate, consider alternative query forms.” - Gail Shaw}

Post #926714

Robb Melancon

Posted Monday, May 24, 2010 8:20 AM

Grasshopper

Group: General Forum Members
Last Login: Friday, March 25, 2011 3:26 PM
Points: 22, Visits: 80

Thanks for the input guys. The rows need to be calculated in dayid desc order. Here are the expected results.

AssetID_in Symbol DayID_in MV DailyPerf RunningPerf
100 IBM 75006 NULL 201048.8987 0.001032321 0.001032321
100 IBM 75005 NULL 200841.5658 0.002595133 0.003630133
100 IBM 75004 NULL 200321.7043 -0.003969482 -0.000353759
100 IBM 75003 NULL 201120.0467 -0.003270067 -0.003622669
100 IBM 75002 NULL 201779.8805 0.000637183 -0.002987795
100 IBM 75001 NULL 201651.3917 0 -0.002987795
100 IBM 75000 NULL 201651.3917 0 -0.002987795

It's a bit odd because you need to start on the second row (Todays MV - Yesterdays MV divided by Yesterdays MV) to get the first rows performance but the running is done first row to second row. So 75006 Daily is (201047.8987-200841.5658)/200841.5658 and running is 1 + Current Running (which is 0 on day 75006) * 1 + Daily minus 1. I realize the Running Performance seems backwards meaning that the value for the entire period is actually stored on the first day of the period, but this is done for a reason which is more than you probably want to know about calculating market performance for periods.... anyway hope this calrifies a little more.

Post #926865

ChrisM@Work

Posted Monday, May 24, 2010 8:26 AM

SSCertifiable

Group: General Forum Members
Last Login: Today @ 8:51 AM
Points: 5,608, Visits: 10,970

Robb, looks straightforward - but can you please edit and if necessary correct correct the line beginning -
So 75006 Daily is...

Cheers

ChrisM

^{“Write the query the simplest way. If through testing it becomes clear that the performance is inadequate, consider alternative query forms.” - Gail Shaw}

Post #926870

Robb Melancon

Posted Monday, May 24, 2010 8:39 AM

Grasshopper

Group: General Forum Members
Last Login: Friday, March 25, 2011 3:26 PM
Points: 22, Visits: 80

Ok, so I got it. My question now is how does this perform relative to doing the same thing with fast forward read only cursors? I can answer that by implementing this in some more tests but just wondering if you guys have a guess...

Here is the completed code:

create table #DMVRunningPerformance (
	Seq int,
	LongPosition_bt bit null,
	AssetID_in int null,
	Symbol_vc varchar(255),
	DayID_in int,
	Status_vc varchar(255) null,
	MV float,
	DailyPerf float null,
	RunningPerf float null)
		
	CREATE CLUSTERED INDEX [indexdown] ON #DMVRunningPerformance 
		(
			[Seq] ASC,
			[LongPosition_bt] ASC,
			[AssetID_in] ASC,
			[DayID_in] DESC
		)
	WITH (SORT_IN_TEMPDB = OFF, IGNORE_DUP_KEY = OFF, DROP_EXISTING = OFF, ONLINE = OFF) ON [PRIMARY]
			
insert into #DMVRunningPerformance 	
 values (1,1,100,'IBM',75006,NULL,201048.8987,NULL,NULL)
insert into #DMVRunningPerformance 	
 values (2,1,100,'IBM',75005,NULL,200841.5658,NULL,NULL)
insert into #DMVRunningPerformance 	
 values (3,1,100,'IBM',75004,NULL,200321.7043,NULL,NULL)
insert into #DMVRunningPerformance 	
 values (4,1,100,'IBM',75003,NULL,201120.0467,NULL,NULL)
insert into #DMVRunningPerformance 	
 values (5,1,100,'IBM',75002,NULL,201779.8805,NULL,NULL)
insert into #DMVRunningPerformance 	
 values (6,1,100,'IBM',75001,NULL,201651.3917,NULL,NULL)
insert into #DMVRunningPerformance 	
 values (7,1,100,'IBM',75000,NULL,201651.3917,NULL,NULL)
	
declare @AssetID_in int=-1,
		@NDAssetID_in int=-1,
		@LongPosition_bt bit=0,
		@Status_vc varchar(255)=NULL,
		@NewGroup_bt bit=1,
		@DailyPerformance float,
		@RunningPerformance float,
		@NDMarketValue float
		
;WITH Calculator AS (
        -- Anchor row, tr.Seq = 1
        SELECT thisrow.Seq, thisrow.Symbol_vc, thisrow.DayID_in, thisrow.MV,
				DailyPerf=CAST((thisrow.MV-nextrow.MV)/nextrow.MV AS FLOAT),
                RunningPerf = CAST((thisrow.MV-nextrow.MV)/nextrow.MV AS FLOAT)
        FROM #DMVRunningPerformance thisrow
        INNER JOIN #DMVRunningPerformance nextrow ON nextrow.Seq = thisrow.Seq + 1
        WHERE thisrow.Seq = 1
        UNION ALL
        -- first recursion will be Seq = 2 (thisrow.Seq = 2, lastrow.Seq = 1)
        SELECT thisrow.Seq, thisrow.Symbol_vc, thisrow.DayID_in, thisrow.MV, 
                DailyPerf = CAST((thisrow.MV-nextrow.MV)/nextrow.MV AS FLOAT), 
                RunningPerf = ((1 + lastrow.RunningPerf) * (1 + CAST((thisrow.MV-nextrow.MV)/nextrow.MV AS FLOAT))) - 1
        FROM Calculator lastrow
        INNER JOIN #DMVRunningPerformance thisrow ON thisrow.Seq = lastrow.Seq + 1
        INNER JOIN #DMVRunningPerformance nextrow ON nextrow.Seq = thisrow.Seq + 1 
)
SELECT Seq, Symbol_vc, DayID_in, MV, DailyPerf, RunningPerf 
FROM Calculator

drop table #dmvrunningperformance

Post #926883

ChrisM@Work

Posted Monday, May 24, 2010 8:47 AM

SSCertifiable

Group: General Forum Members
Last Login: Today @ 8:51 AM
Points: 5,608, Visits: 10,970

Hi Robb

There were some performance comparisons posted here earlier in the year. IIRC the running totals update did a million rows in about 6 seconds, the rCTE method took a little less than twice that.

^{“Write the query the simplest way. If through testing it becomes clear that the performance is inadequate, consider alternative query forms.” - Gail Shaw}

Post #926887

« Prev Topic | Next Topic »

14 posts, Page 1 of 2

1 2 »»

Permissions