It should be a separate column and concatenated into the computed column that is displayed to the user.

I think thats the most important post in this discussion. I think one of the worst things you can do to a relational DB is to store MORE THEN ONE Information in a field. And if you "force" the field to become a wrong datatype it will even get worse.

Take the Year-Number example...

 SET @tmp_invoice_id = (SELECT MAX(SUBSTRING(invoice_id, 4, 5) + 1)
                        FROM Invoice WHERE (invoice_id LIKE @tmp_date + '%'))

To find all "Year entries" you can utilize an Index with "like '06%' after that you are using a function to find the maximum value of ALL Invoices for that year. That means in a "worst case" you have to do 99.999 times Substring ?

I think the overhead when creating the sequential Invoices can be negelected if you are using a sequence table... Also here is a small suggestion for the self updating of the sequence table. If I am faced with a the same problem, then i usually do it the "lazy way" Update the row i need to update, and if I get a rowcount of "0" then I know that i need to actually insert the row. Updating 0 Rows has no negative performace effect on SQL Server (Assuming correct indexes) and if I first check if the row exists, and then update, then i need to access the index 2 times... Once for checking and once for updating... So I can skip the 2nd Access to the index most of the times. And the Insert will automatically fierd when its needed.

But when the reporting season starts this (string) system will hurt you. It is not possible to generate a "good" index on these fields. and when you start running querries this will start to hurt you. It might only start with an concattinated Invoice Number... but in a current  application i am working with this started to run rampart... They needed to change the Datatype from Varchar to Binary to store all the "extra" information (Yes I tried to convice them that this is stupid... trust me I tried.. I am also looking for a Job now where ppl actually listen)

P.s: The suggested solution can still be valid if the number of Invoices remains small. You allways have to think about which compromise you can make...

Hehe...

I was refering to the Identity column with primary key constraint

Should you need this "sequencing" you can use the table and should you could care less about it use the Identity instead.

The sequence is very good to "reserve"  client side batches of candidate keys in one go

I am certaint that scalability is excellent if you apply all the remomendations I posted (I have !)

I was thinking a bit about the performance problem I mentioned above when creating a sequence.

The group by querry could be rewritten so it can correctly use the indexec.

The following querry would do the trick:

 SET @tmp_invoice_id = (SELECT top 1 (SUBSTRING(invoice_id, 4, 5) + 1)
                        FROM Invoice WHERE (invoice_id LIKE @tmp_date + '%')order by  invoive_id desc)

This will limit the querry to only retrieve one record and only do one substring and one implicit cast on the data.

I liked your revised approach of letting SQL pick proper index and help speed up performance.  The goal for this approach was totally eliminate the need to “maintain any sort of counters” and I think I have mentioned that the solution I proposed is for a small to medium size operation, believe it or not it always worked for me since about 8 years

I will give it another shot using CLR integration and see how much does it makes difference.

Regards,

Asif

Iron clad?

-- prepare test data
declare @test table (t varchar(50))

insert @test
select 'ov1' union all
select 'ov2' union all
select 'ov4' union all
select 'ov31' union all
select 'ssss1' union all
select 'ssss99'

-- show data before inserting new values
select * from @test

-- do the work
declare @prefix varchar(50)

select @prefix = 'ov' -- Throw anything in!

insert @test
select @prefix + convert(varchar, t.n + 1)
from (
select max(convert(int, substring(t, 1 + len(@prefix), 50))) n
from @test
where t like @prefix + '%'
and not substring(t, 1 + len(@prefix), 50) like '%[^0-9]%'
) t
where not @prefix like '%[0-9]%'
and not t.n like '%[^0-9]%'

-- show data after inserting new values
select * from @test