Click here to monitor SSC
SQLServerCentral is supported by Red Gate Software Ltd.
 
Log in  ::  Register  ::  Not logged in
 
 
 
        
Home       Members    Calendar    Who's On


Add to briefcase 12»»

how to insert datetime column into table Expand / Collapse
Author
Message
Posted Wednesday, March 20, 2013 8:00 AM
SSC Rookie

SSC RookieSSC RookieSSC RookieSSC RookieSSC RookieSSC RookieSSC RookieSSC Rookie

Group: General Forum Members
Last Login: Thursday, July 04, 2013 10:31 AM
Points: 25, Visits: 55
All,
I'm having strange issue trying to do the following which I thought was just going to be straight forward

select top 5 machine.name, machine.model, machine.scantime
'INSERT INTO [SMS_000].[dbo].[BMCMachines] ([ComputerName],[MachineModel],[stime]) VALUES (' + '''' + machine.name + ''',' + '''' + machine.model + ''',' + convert(datetime,machine.scantime,112) + ''')' from machine

when I run the query comes back with following error
Msg 241, Level 16, State 1, Line 1
Conversion failed when converting date and/or time from character string.

I can confirm that machine.scantime is "DateTime" column.

Post #1433229
Posted Wednesday, March 20, 2013 8:46 AM
Old Hand

Old HandOld HandOld HandOld HandOld HandOld HandOld HandOld Hand

Group: General Forum Members
Last Login: Thursday, October 31, 2013 3:44 AM
Points: 314, Visits: 4,128
denis.gendera (3/20/2013)
All,
I'm having strange issue trying to do the following which I thought was just going to be straight forward

select top 5 machine.name, machine.model, machine.scantime
'INSERT INTO [SMS_000].[dbo].[BMCMachines] ([ComputerName],[MachineModel],[stime]) VALUES (' + '''' + machine.name + ''',' + '''' + machine.model + ''',' + convert(datetime,machine.scantime,112) + ''')' from machine

when I run the query comes back with following error
Msg 241, Level 16, State 1, Line 1
Conversion failed when converting date and/or time from character string.

I can confirm that machine.scantime is "DateTime" column.



Take a closer look at your Convert function and be sure that is what you are actually wanting to do.
Post #1433265
Posted Monday, March 25, 2013 10:08 PM
Grasshopper

GrasshopperGrasshopperGrasshopperGrasshopperGrasshopperGrasshopperGrasshopperGrasshopper

Group: General Forum Members
Last Login: Thursday, March 27, 2014 8:39 PM
Points: 18, Visits: 78
Just confirm if scantime is date or date time ???

also if scantime is already date, why convert it again..
Post #1435250
Posted Tuesday, March 26, 2013 4:05 AM
Valued Member

Valued MemberValued MemberValued MemberValued MemberValued MemberValued MemberValued MemberValued Member

Group: General Forum Members
Last Login: Thursday, January 02, 2014 11:13 AM
Points: 51, Visits: 279
denis.gendera (3/20/2013)
All,
I'm having strange issue trying to do the following which I thought was just going to be straight forward

select top 5 machine.name, machine.model, machine.scantime
'INSERT INTO [SMS_000].[dbo].[BMCMachines] ([ComputerName],[MachineModel],[stime]) VALUES (' + '''' + machine.name + ''',' + '''' + machine.model + ''',' + convert(datetime,machine.scantime,112) + ''')' from machine

when I run the query comes back with following error
Msg 241, Level 16, State 1, Line 1
Conversion failed when converting date and/or time from character string.

I can confirm that machine.scantime is "DateTime" column.




The issue with the convert is that the 3rd arguement is the style and is used to set the style when you convert from a datetime to a varchar, not the other way around.

What is the datatype of the [BMCMachines].[stime] column because the other issue is that the convert style of 112 is for an ISO date with no time element to it??

Post #1435362
Posted Tuesday, March 26, 2013 6:30 AM


SSCommitted

SSCommittedSSCommittedSSCommittedSSCommittedSSCommittedSSCommittedSSCommittedSSCommitted

Group: General Forum Members
Last Login: Monday, April 14, 2014 11:50 PM
Points: 1,867, Visits: 2,275
please provide table structure


_______________________________________________________________
To get quick answer follow this link:
http://www.sqlservercentral.com/articles/Best+Practices/61537/
Post #1435429
Posted Tuesday, March 26, 2013 6:52 AM


SSCertifiable

SSCertifiableSSCertifiableSSCertifiableSSCertifiableSSCertifiableSSCertifiableSSCertifiableSSCertifiableSSCertifiable

Group: General Forum Members
Last Login: Today @ 9:33 AM
Points: 6,754, Visits: 12,854
Steve JP (3/26/2013)
[quote]...The issue with the convert is that the 3rd arguement is the style and is used to set the style when you convert from a datetime to a varchar, not the other way around....


It works both ways as documented in BOL under [b]CAST and CONVERT (Transact-SQL)
.

SELECT DateAsCharacter = CONVERT(VARCHAR(25),GETDATE(),100)
-- 'Mar 26 2013 12:49PM'
SELECT DateAsDate = CONVERT(DATETIME,'Mar 26 2013 12:49PM',100)
-- 2013-03-26 12:49:00.000



“Write the query the simplest way. If through testing it becomes clear that the performance is inadequate, consider alternative query forms.” - Gail Shaw

For fast, accurate and documented assistance in answering your questions, please read this article.
Understanding and using APPLY, (I) and (II) Paul White
Hidden RBAR: Triangular Joins / The "Numbers" or "Tally" Table: What it is and how it replaces a loop Jeff Moden
Exploring Recursive CTEs by Example Dwain Camps
Post #1435446
Posted Tuesday, March 26, 2013 6:58 AM


SSCertifiable

SSCertifiableSSCertifiableSSCertifiableSSCertifiableSSCertifiableSSCertifiableSSCertifiableSSCertifiableSSCertifiable

Group: General Forum Members
Last Login: Today @ 9:33 AM
Points: 6,754, Visits: 12,854
[b]select top 5 machine.name, machine.model, machine.scantime
'INSERT INTO [SMS_000].[dbo].[BMCMachines] ([ComputerName],[MachineModel],[stime]) VALUES (' + '''' + machine.name + ''',' + '''' + machine.model + ''',' + convert(datetime,machine.scantime,112) + ''')' from machine


This query is syntactically incorrect. Try putting a comma after machine.scantime. What is it that you are really trying to do? How about this?

INSERT INTO [SMS_000].[dbo].[BMCMachines] 
([ComputerName],[MachineModel],[stime])
SELECT top 5
machine.name,
machine.model,
machine.scantime
FROM machine



“Write the query the simplest way. If through testing it becomes clear that the performance is inadequate, consider alternative query forms.” - Gail Shaw

For fast, accurate and documented assistance in answering your questions, please read this article.
Understanding and using APPLY, (I) and (II) Paul White
Hidden RBAR: Triangular Joins / The "Numbers" or "Tally" Table: What it is and how it replaces a loop Jeff Moden
Exploring Recursive CTEs by Example Dwain Camps
Post #1435451
Posted Wednesday, March 27, 2013 4:43 AM
Valued Member

Valued MemberValued MemberValued MemberValued MemberValued MemberValued MemberValued MemberValued Member

Group: General Forum Members
Last Login: Thursday, January 02, 2014 11:13 AM
Points: 51, Visits: 279
SELECT DateAsCharacter = CONVERT(VARCHAR(25),GETDATE(),100)
-- 'Mar 26 2013 12:49PM'

SELECT DateAsDate = CONVERT(DATETIME,'Mar 26 2013 12:49PM',100)
-- 2013-03-26 12:49:00.000



Dont totally agree with this as the following will error which is as I expect because the style is not vailid
 -- Just to 100% prove the style is invalid
SELECT DateAsCharacter = CONVERT(VARCHAR(25),GETDATE(),25510)

Msg 281, Level 16, State 1, Line 1
25510 is not a valid style number when converting from datetime to a character string.


But the following seems to want to ignore the style arguement.

SELECT	[DateAsDate AM] = CONVERT(DATETIME,'Mar 26 2013 02:49AM' ) 
SELECT [DateAsDate PM] = CONVERT(DATETIME,'Mar 26 2013 02:49PM' )
SELECT [DateAsDate mm-dd-yy] = CONVERT(DATETIME,'Mar 26 2013 02:49PM' , 110 )
SELECT [DateAsDate yyyymmdd] = CONVERT(DATETIME,'Mar 26 2013 02:49PM' , 112 )
SELECT [DateAsDate No Such format] = CONVERT(DATETIME,'Mar 26 2013 02:49PM' ,25510) -- invalid style so Error? or Ignore?




DateAsDate AM = 2013-03-26 02:49:00.000

DateAsDate PM = 2013-03-26 14:49:00.000

DateAsDate mm-dd-yy = 2013-03-26 14:49:00.000

DateAsDate yyyymmdd = 2013-03-26 14:49:00.000

DateAsDate No Such format = 2013-03-26 14:49:00.000


Post #1435820
Posted Wednesday, March 27, 2013 5:06 AM


SSCertifiable

SSCertifiableSSCertifiableSSCertifiableSSCertifiableSSCertifiableSSCertifiableSSCertifiableSSCertifiableSSCertifiable

Group: General Forum Members
Last Login: Today @ 9:33 AM
Points: 6,754, Visits: 12,854
Steve JP (3/27/2013)
SELECT DateAsCharacter = CONVERT(VARCHAR(25),GETDATE(),100)
-- 'Mar 26 2013 12:49PM'

SELECT DateAsDate = CONVERT(DATETIME,'Mar 26 2013 12:49PM',100)
-- 2013-03-26 12:49:00.000



Dont totally agree with this as the following will error which is as I expect because the style is not vailid
 -- Just to 100% prove the style is invalid
SELECT DateAsCharacter = CONVERT(VARCHAR(25),GETDATE(),25510)

Msg 281, Level 16, State 1, Line 1
25510 is not a valid style number when converting from datetime to a character string.


- and your point is?





But the following seems to want to ignore the style arguement.

SELECT	[DateAsDate AM] = CONVERT(DATETIME,'Mar 26 2013 02:49AM' ) 
SELECT [DateAsDate PM] = CONVERT(DATETIME,'Mar 26 2013 02:49PM' )
SELECT [DateAsDate mm-dd-yy] = CONVERT(DATETIME,'Mar 26 2013 02:49PM' , 110 )
SELECT [DateAsDate yyyymmdd] = CONVERT(DATETIME,'Mar 26 2013 02:49PM' , 112 )
SELECT [DateAsDate No Such format] = CONVERT(DATETIME,'Mar 26 2013 02:49PM' ,25510) -- invalid style so Error? or Ignore?




DateAsDate AM = 2013-03-26 02:49:00.000

DateAsDate PM = 2013-03-26 14:49:00.000

DateAsDate mm-dd-yy = 2013-03-26 14:49:00.000

DateAsDate yyyymmdd = 2013-03-26 14:49:00.000

DateAsDate No Such format = 2013-03-26 14:49:00.000




The style argument for converting a date as string in the format 'Mar 26 2013 12:49PM' to a datetime data type using CONVERT() is 100. Other style arguments are likely to fail. I'm sorry but I still don't see your point. None of this appears to prove anything either way. Have a quick read of CAST and CONVERT in BOL, specifically CONVERT relating to dates. The explanation is quite good. If you're still unsure, post back.


“Write the query the simplest way. If through testing it becomes clear that the performance is inadequate, consider alternative query forms.” - Gail Shaw

For fast, accurate and documented assistance in answering your questions, please read this article.
Understanding and using APPLY, (I) and (II) Paul White
Hidden RBAR: Triangular Joins / The "Numbers" or "Tally" Table: What it is and how it replaces a loop Jeff Moden
Exploring Recursive CTEs by Example Dwain Camps
Post #1435826
Posted Wednesday, March 27, 2013 6:30 AM
Valued Member

Valued MemberValued MemberValued MemberValued MemberValued MemberValued MemberValued MemberValued Member

Group: General Forum Members
Last Login: Thursday, January 02, 2014 11:13 AM
Points: 51, Visits: 279
Steve JP (3/26/2013)
....

The issue with the convert is that the 3rd arguement is the style and is used to set the style when you convert from a datetime to a varchar, not the other way around.

...


ChrisM@Work (3/27/2013)
....
The style argument for converting a date as string in the format 'Mar 26 2013 12:49PM' to a datetime data type using CONVERT() is 100. Other style arguments are likely to fail. I'm sorry but I still don't see your point. None of this appears to prove anything either way. Have a quick read of CAST and CONVERT in BOL, specifically CONVERT relating to dates. The explanation is quite good. If you're still unsure, post back......



Chris, I thought my example was clear in that the style code ( of 25510 ) that I first used doesnt exist. I know this & you know this, but others may not, as this is the newbies section hence I posted the code. The next code block shows that the Style arguement is often ignored for a conversion from varchar to datetime. It also doesnt have any affect on the time. ie the 103 (which is English) will take a datetime to a varchar as only a date of format dd/mm/yyyy. But from a varchar to datetime will take the time element if it exists as well so can be a bit misleading for some. How many times have people asked how to truncate the time element from a datetime value.

If the style arguement doest exist but cant be applied then it will error. Other times like I have shown it will ignore the style arguement if the actual data contradicts the style.

One of the most reliable methods I have found to enter datetime is yyyy-mm-dd hh:mm:ss:mmm (or the full iso style)
Another option is to use SET DATEFORMAT, although I'm not certain what lifespan this has long term.


I havent got all day for these forums and can only post while jobs are running etc. So yes some of the time my comments are a bit too brief, but mainly I try and post a bit more than "go read the BOLs".
Post #1435859
« Prev Topic | Next Topic »

Add to briefcase 12»»

Permissions Expand / Collapse