Msg 245, Level 16, State 1, Line 1 Conversion failed when converting the varchar value 'Noida' to data type int.

SQLServerCentral is supported by Red Gate Software Ltd.

Popular Topics

Home

Members

Calendar

Who's On

Home » SQL Server 2008 » SQL Server Newbies » Msg 245, Level 16, State 1, Line 1 Conversion...

Msg 245, Level 16, State 1, Line 1 Conversion failed when converting the varchar value 'Noida' to data type int.

Rate Topic

Display Mode

Topic Options

Author

Message

kiran.vaichalkar

Posted Saturday, March 16, 2013 11:24 AM

Grasshopper

Group: General Forum Members
Last Login: Today @ 4:29 AM
Points: 16, Visits: 27

CREATE TABLE EMPLOYEE
(
EMP_ID INT PRIMARY KEY,
FIRSTNAME nvarchar(100),
LASTNAME nvarchar(100),
Salary INT,
CITY nvarchar(100)
)

insert INTO EMPLOYEE VALUES(2, Monu Rathor, 4789.00, Agra);
insert INTO EMPLOYEE VALUES(4, Rahul Saxena, 5567.00, London);
insert INTO EMPLOYEE VALUES(5, Prabhat Kumar, 4467.00, Bombay);

BEGIN TRANSACTION
Declare @B varchar(100)
SET @B = 'Nodia';
Declare @D varchar(100)
SET @D = 'Delhi'
Update employee
SET city =(
Case
WHEN city = 'Agra' THEN @B
WHEN city = 'London' THEN @D
ELSE 0
END)
END

The error faced was as present in the subject. Please help

I also tried the below way,

BEGIN TRANSACTION
Update employee
SET city =(
Case
WHEN city = 'Agra' THEN 'Delhi'
WHEN city = 'London' THEN 'Noida'
ELSE 0
END)
END

BUT I CAME ACCROSS:
Msg 102, Level 15, State 1, Line 9
Incorrect syntax near 'END'.

Please HELP

Post #1431924

opc.three

Posted Saturday, March 16, 2013 2:19 PM

SSCertifiable

Group: General Forum Members
Last Login: Today @ 8:26 AM
Points: 6,737, Visits: 11,791

Two definite issues:

1. You have to watch your data types. In your CASE expression your default case outputs a 0, which will default to an INT in SQL Server. Try putting the 0 in single quotes so SQL Server views it as a string-literal.
2. The ending command for an explicit transaction is not END, it is COMMIT TRANSACTION.

BEGIN TRANSACTION;
Declare @B varchar(100);
SET @B = 'Nodia';
Declare @D varchar(100);
SET @D = 'Delhi';
Update employee 
SET city =(Case 
                   WHEN city = 'Agra' THEN @B
                   WHEN city = 'London' THEN @D
                   ELSE '0'
                 END);
COMMIT TRANSACTION;

One potential issue:

1. Do you need a WHERE-clause? Your update statement will update all rows in the table. Are you sure that is what you want?

__________________________________________________________________________________________________
There are no special teachers of virtue, because virtue is taught by the whole community. --Plato

Believe you can and you're halfway there. --Theodore Roosevelt

Everything Should Be Made as Simple as Possible, But Not Simpler --Albert Einstein

The significant problems we face cannot be solved at the same level of thinking we were at when we created them. --Albert Einstein

1 apple is not exactly 1/8 of 8 apples. Because there are no absolutely identical apples. --Giordy

Post #1431943

kiran.vaichalkar

Posted Sunday, March 17, 2013 4:09 AM

Grasshopper

Group: General Forum Members
Last Login: Today @ 4:29 AM
Points: 16, Visits: 27

Thanks A Lot!!!! Smile

That worked perfectly. Yes were are only two records in the table as of now.
Where i wanted to swap the city details to some desired.

Well do u meant to use 'Where' clause for tuning/Performance? Faster transactions?

Post #1431968

opc.three

Posted Sunday, March 17, 2013 5:26 AM

SSCertifiable

Group: General Forum Members
Last Login: Today @ 8:26 AM
Points: 6,737, Visits: 11,791

kiran.vaichalkar (3/17/2013)

Thanks A Lot!!!! Smile

You're welcome Smile

Thank you for the feedback.

Just one more note about the use of an explicit transaction. By default SQL Server will auto-commit statements unless the database option IMPLICIT_TRANSACTIONS is ON or if the statements appear within an explicit transaction block, i.e. after a BEGIN TRANSACTION; and before a COMMIT TRANSACTION; statement as you have shown. What this means for you is that if all you need to do is issue the UPDATE statement then you do not need to open an explicit transaction, i.e. you could delete the BEGIN TRANSACTION; and COMMIT TRANSACTION statements from your batch and it would function exactly the same way.

Well do u meant to use 'Where' clause for tuning/Performance? Faster transactions?

Performance yes, and possibly correctness. The update statement you showed did not appear to be something one would typically issue in a production scenario and leaving off a WHERE-clause is a mistake that is sometimes very hard to recover from. Ideally you want to focus on limiting the number of rows the database engine would need to evaluate in order to get the correct result, and only ask the engine to do as little work as necessary. In a production scenario where you might have hundreds or thousands of queries needing to run per second every little bit of performance advantage helps.

__________________________________________________________________________________________________
There are no special teachers of virtue, because virtue is taught by the whole community. --Plato

Believe you can and you're halfway there. --Theodore Roosevelt

Everything Should Be Made as Simple as Possible, But Not Simpler --Albert Einstein

The significant problems we face cannot be solved at the same level of thinking we were at when we created them. --Albert Einstein

1 apple is not exactly 1/8 of 8 apples. Because there are no absolutely identical apples. --Giordy

Post #1431973

« Prev Topic | Next Topic »

Permissions