Click here to monitor SSC
SQLServerCentral is supported by Redgate
 
Log in  ::  Register  ::  Not logged in
 
 
 


passing a column name to function


passing a column name to function

Author
Message
Prakash-485822
Prakash-485822
SSC Rookie
SSC Rookie (28 reputation)SSC Rookie (28 reputation)SSC Rookie (28 reputation)SSC Rookie (28 reputation)SSC Rookie (28 reputation)SSC Rookie (28 reputation)SSC Rookie (28 reputation)SSC Rookie (28 reputation)

Group: General Forum Members
Points: 28 Visits: 124
Dear All
I have the following function that the returns the value with comma delimitor

ex:
FormCode ITem-Code
RS-001 IT-0001,IT-0002,IT-003


CREATE FUNCTION dbo.ItemList_fn
( @FormId int )
RETURNS varchar(1000)
AS
BEGIN
DECLARE @TempOEDetails table
( FormCodeDetails varchar(1000) )
DECLARE @FormCodeList varchar(1000)
DECLARE @TempFormCodeList varchar(1000)
SET @FormCodeList = ''

INSERT INTO @TempOEDetails
SELECT Items.ITemCode
FROM MainTable
Inner Join Items on MainTable .FormId = Items.FormId
WHERE MainTable.FormId = @FormId
And Items.StuffingId is not null
IF @@ROWCOUNT > 0
UPDATE @TempOEDetails
SET @FormCodeList = ( @FormCodeList + FormCodeDetails + ', ' )
IF(len(@FormCodeList)>0 )
BEGIN
Set @TempFormCodeList= substring( @FormCodeList, 1, ( len( @FormCodeList ) - 1 ))
END
ELSE
BEGIN
SET @TempFormCodeList = ''
END
RETURN @TempFormCodeList
END


But now i want to have pass the column name to the function
eg: if i passes the to function

select Formid,dbo.dbo.ItemList_fn (FormId,'Color') Item Name
it should return me
FormCode ITem-Code
RS-001 Bule,Green,Yellow

and

select Formid,dbo.dbo.ItemList_fn (FormId,'Quantity') Item Name
it should return me
FormCode ITem-Code
RS-001 5,10,15

Please help me to solve this .
Jeff Moden
Jeff Moden
SSC-Forever
SSC-Forever (45K reputation)SSC-Forever (45K reputation)SSC-Forever (45K reputation)SSC-Forever (45K reputation)SSC-Forever (45K reputation)SSC-Forever (45K reputation)SSC-Forever (45K reputation)SSC-Forever (45K reputation)

Group: General Forum Members
Points: 45020 Visits: 39887
First, the function you have uses a cursor/while loop and it's going to be relatively slow. See the following for a couple of tips how to do it another way while avoiding some common pitfalls...

http://www.sqlservercentral.com/articles/Test+Data/61572/

Second, to make the column a parameter would require the use of Dynamic SQL. That requires an EXEC in one form or another and only extended stored procedures can be executed with EXEC from within a function. In English, what you ask cannot be done in a function.

--Jeff Moden

RBAR is pronounced ree-bar and is a Modenism for Row-By-Agonizing-Row.
First step towards the paradigm shift of writing Set Based code:
Stop thinking about what you want to do to a row... think, instead, of what you want to do to a column.
Although they tell us that they want it real bad, our primary goal is to ensure that we dont actually give it to them that way.
Although change is inevitable, change for the better is not.
Just because you can do something in PowerShell, doesnt mean you should. Wink

Helpful Links:
How to post code problems
How to post performance problems
Forum FAQs
Go


Permissions

You can't post new topics.
You can't post topic replies.
You can't post new polls.
You can't post replies to polls.
You can't edit your own topics.
You can't delete your own topics.
You can't edit other topics.
You can't delete other topics.
You can't edit your own posts.
You can't edit other posts.
You can't delete your own posts.
You can't delete other posts.
You can't post events.
You can't edit your own events.
You can't edit other events.
You can't delete your own events.
You can't delete other events.
You can't send private messages.
You can't send emails.
You can read topics.
You can't vote in polls.
You can't upload attachments.
You can download attachments.
You can't post HTML code.
You can't edit HTML code.
You can't post IFCode.
You can't post JavaScript.
You can post emoticons.
You can't post or upload images.

Select a forum

































































































































































SQLServerCentral


Search