SQL Clone
SQLServerCentral is supported by Redgate
 
Log in  ::  Register  ::  Not logged in
 
 
 


Finding the Next Business Day Recursively


Finding the Next Business Day Recursively

Author
Message
Rob Scholl
Rob Scholl
SSC Journeyman
SSC Journeyman (81 reputation)SSC Journeyman (81 reputation)SSC Journeyman (81 reputation)SSC Journeyman (81 reputation)SSC Journeyman (81 reputation)SSC Journeyman (81 reputation)SSC Journeyman (81 reputation)SSC Journeyman (81 reputation)

Group: General Forum Members
Points: 81 Visits: 354
Comments posted to this topic are about the content posted at http://www.sqlservercentral.com/columnists/rScholl/findingthenextbusinessdayrecursively.asp
Phil Paxton
Phil Paxton
Valued Member
Valued Member (74 reputation)Valued Member (74 reputation)Valued Member (74 reputation)Valued Member (74 reputation)Valued Member (74 reputation)Valued Member (74 reputation)Valued Member (74 reputation)Valued Member (74 reputation)

Group: General Forum Members
Points: 74 Visits: 17

I have to quibble a bit on the definition of recursion and the article provides a hint to support this.

"Way back when", recursion was taught as "a function which calls itself with parameters|data|whatever in a simpler version of themselves [compared to what was passed in]. Eventually, you will reach a base or termination case which will cause the recursion to unravel itself and provide a solution.


Andre Araujo-272450
Andre Araujo-272450
SSC Journeyman
SSC Journeyman (77 reputation)SSC Journeyman (77 reputation)SSC Journeyman (77 reputation)SSC Journeyman (77 reputation)SSC Journeyman (77 reputation)SSC Journeyman (77 reputation)SSC Journeyman (77 reputation)SSC Journeyman (77 reputation)

Group: General Forum Members
Points: 77 Visits: 17

Rob,

for some reason your function didn't work for me. I changed it a bit to get it working here and changed basically two things:

1) As we are using recursion there is no need for an explicit loop inside the function. The iteration is done using the consecutive calls to the function.

2) I get rid of the HH:MM:SS of the startDate in order to compare with the dates on the Holiday table. Otherwise the comparison would be like '2005-11-07 16:41:03' = '2005-11-07 00:00:00', which would evaluate to FALSE.

Below is the code with the changes.

Cheers,

Andre

create function fnGetNextBusinessDay (@startDate smalldatetime)
returns smalldatetime as

Begin
Declare @nextBusDay smalldatetime
Declare @weekDay tinyInt

set @nextBusDay = convert(datetime,left(convert(varchar,@startDate + 1,120),10),120) -- first get the raw next day

SET @weekDay =((@@dateFirst+datePart(dw,@nextBusDay)-2) % 7) + 1

if @weekDay in (6, 7) or exists (select 1 from holiday where holidayDate = @nextBusDay)
set @nextBusDay = dbo.fnGetNextBusinessDay(@nextBusDay)

return (@nextBusDay)

End


Hugo Kornelis
Hugo Kornelis
SSC-Insane
SSC-Insane (21K reputation)SSC-Insane (21K reputation)SSC-Insane (21K reputation)SSC-Insane (21K reputation)SSC-Insane (21K reputation)SSC-Insane (21K reputation)SSC-Insane (21K reputation)SSC-Insane (21K reputation)

Group: General Forum Members
Points: 21293 Visits: 12471

Hi Rob,

While the function uses some nifty tricks (I particularly like the trick to get correct results regardless of datefirst setting; this is a new trick for me), I'd never recommend using this function to anyone.

There are other ways to achieve this. Ways that are, in my opinion, better. Check out http://www.aspfaq.com/show.asp?id=2519, and especially the section titled "Pre-determine delivery dates".

Best, Hugo




Hugo Kornelis, SQL Server MVP
Visit my SQL Server blog: http://sqlblog.com/blogs/hugo_kornelis
Ian Yates
Ian Yates
SSCertifiable
SSCertifiable (5.7K reputation)SSCertifiable (5.7K reputation)SSCertifiable (5.7K reputation)SSCertifiable (5.7K reputation)SSCertifiable (5.7K reputation)SSCertifiable (5.7K reputation)SSCertifiable (5.7K reputation)SSCertifiable (5.7K reputation)

Group: General Forum Members
Points: 5682 Visits: 445

Elegant solution (I too like the trick to get the correct day regardless of datefirst! Clever!). BUT... recursion in SQL is limited to 32 calls (XMAS holidays in schools, for example, go a lot longer than this) - it could easily have been done with a simple loop, or better yet, a simple select statement...

In our software where we have to keep track of days a clinic is open for business, rather than messing around with such procedures, we just have a dates table with one value for each day and a bit flag representing opened or closed... Makes reporting VERY easy and you can join to the table easily to group days together efficiently, etc. For similar ideas and more info on why just storing the data in a table can be efficient, look up "numbers table" on this site - Adam Machanic has quite a bit written about them.

But I still like that modulus trick!!





Mark Firth-200666
Mark Firth-200666
Valued Member
Valued Member (69 reputation)Valued Member (69 reputation)Valued Member (69 reputation)Valued Member (69 reputation)Valued Member (69 reputation)Valued Member (69 reputation)Valued Member (69 reputation)Valued Member (69 reputation)

Group: General Forum Members
Points: 69 Visits: 31

Cute, but I agree with Ian, if you are using a table why not maintain the correct dates in the table, it is MUCH easier to work with.

I did not know the 32 levels of recursion limitation, thanks


Mark Hickin
Mark Hickin
Old Hand
Old Hand (335 reputation)Old Hand (335 reputation)Old Hand (335 reputation)Old Hand (335 reputation)Old Hand (335 reputation)Old Hand (335 reputation)Old Hand (335 reputation)Old Hand (335 reputation)

Group: General Forum Members
Points: 335 Visits: 156

One thing to note.

@@Datefirst is affected by things like the defaultlanguage property of your language.

I believe that for the US @@Datefirst defaults to 7, whereas if you set up your login to use British English, as we brits often do, it will be 1.

This will affect what Datepart(weekday, getdate()) returns.

Just something to be aware of, I've had problems with this before.


David Jackson
David Jackson
SSCommitted
SSCommitted (1.7K reputation)SSCommitted (1.7K reputation)SSCommitted (1.7K reputation)SSCommitted (1.7K reputation)SSCommitted (1.7K reputation)SSCommitted (1.7K reputation)SSCommitted (1.7K reputation)SSCommitted (1.7K reputation)

Group: General Forum Members
Points: 1722 Visits: 2034

Paul Cresham posted an elegant solution for this including working out holidays on the fly, albeit for the UK. It did contain a nifty Easter algorithm, as well as tackling the @@DATEFIRST problem. see

http://www.sqlservercentral.com/forums/shwmessage.aspx?forumid=23&messageid=110259

I documented it with an example of how we use it at

http://glossopian.co.uk/pmwiki.php?n=Main.WorkingDays

Dave Jackson




http://glossopian.co.uk/
"I don't know what I don't know."
Mike C
Mike C
SSCertifiable
SSCertifiable (7.8K reputation)SSCertifiable (7.8K reputation)SSCertifiable (7.8K reputation)SSCertifiable (7.8K reputation)SSCertifiable (7.8K reputation)SSCertifiable (7.8K reputation)SSCertifiable (7.8K reputation)SSCertifiable (7.8K reputation)

Group: General Forum Members
Points: 7765 Visits: 1172

Here's another version of the Easter Calculation algorithm:

http://sqlservercentral.com/cs/blogs/michael_coles/archive/2005/07/16/49.aspx

And something for calculating "floating" American holidays:

http://sqlservercentral.com/cs/blogs/michael_coles/archive/2005/07/17/52.aspx


mdolan1959
mdolan1959
SSC Veteran
SSC Veteran (239 reputation)SSC Veteran (239 reputation)SSC Veteran (239 reputation)SSC Veteran (239 reputation)SSC Veteran (239 reputation)SSC Veteran (239 reputation)SSC Veteran (239 reputation)SSC Veteran (239 reputation)

Group: General Forum Members
Points: 239 Visits: 15

Rob- I like this example. It will work for our business because we don't take long holidays

Thanks, Matt




Matt Dolan

Go


Permissions

You can't post new topics.
You can't post topic replies.
You can't post new polls.
You can't post replies to polls.
You can't edit your own topics.
You can't delete your own topics.
You can't edit other topics.
You can't delete other topics.
You can't edit your own posts.
You can't edit other posts.
You can't delete your own posts.
You can't delete other posts.
You can't post events.
You can't edit your own events.
You can't edit other events.
You can't delete your own events.
You can't delete other events.
You can't send private messages.
You can't send emails.
You can read topics.
You can't vote in polls.
You can't upload attachments.
You can download attachments.
You can't post HTML code.
You can't edit HTML code.
You can't post IFCode.
You can't post JavaScript.
You can post emoticons.
You can't post or upload images.

Select a forum

































































































































































SQLServerCentral


Search