Unless your database is case-sensitive, you don't need the UPPERs.
Also you should always qualify your tables with their schema.
So I've rewritten your query a little to account for the above.
select Number_of_Leaves = (
when f.newact = 'N'
when f.newact = 'R'
from dbo.finacle_upload_detail f
join dbo.cheque_master c on c.schemecode = f.schcd
,Tot = s.Number_of_Leaves + s.Strt_Ser
from Sub1 s
Help us to help you. For better, quicker and more-focused answers to your questions, consider following the advice in this
If the answer to your question can be found with a brief Google search, please perform the search yourself, rather than expecting one of the SSC members to do it for you.
Please surround any code or links you post with the appropriate IFCode formatting tags. It helps readability a lot.