SQL Clone
SQLServerCentral is supported by Redgate
 
Log in  ::  Register  ::  Not logged in
 
 
 


Getting It Right First Time. Almost?


Getting It Right First Time. Almost?

Author
Message
quackhandle1975
quackhandle1975
Hall of Fame
Hall of Fame (3.3K reputation)Hall of Fame (3.3K reputation)Hall of Fame (3.3K reputation)Hall of Fame (3.3K reputation)Hall of Fame (3.3K reputation)Hall of Fame (3.3K reputation)Hall of Fame (3.3K reputation)Hall of Fame (3.3K reputation)

Group: General Forum Members
Points: 3277 Visits: 1240
Comments posted to this topic are about the item Getting It Right First Time. Almost?

Who looks outside, dreams; who looks inside, awakes. – Carl Jung.
Gary Varga
Gary Varga
SSCoach
SSCoach (16K reputation)SSCoach (16K reputation)SSCoach (16K reputation)SSCoach (16K reputation)SSCoach (16K reputation)SSCoach (16K reputation)SSCoach (16K reputation)SSCoach (16K reputation)

Group: General Forum Members
Points: 16955 Visits: 6534
Code reviews are essential. I am not stipulating the amount of code reviewed or the frequency but I have found that a team that employs code reviews encourages everyone to review their code before checking in (OK, I admit it: I am coming at this from a developers perspective). Having said that I believe that reviewing anything that can be reviewed is applicable.

As for code reviews, I am always the slowest person from when then code is development completed to checked in. The reason? I review each and every file change before check in. The downside is that I have to start to complete my tasks before most others. The upside is that I have less check in issues such as debugging code, missing implementation with comment to complete or file added to project files but not to source control.

I may have called it something else but in principle, yes, Check & Test!!!

Gaz

-- Stop your grinnin' and drop your linen...they're everywhere!!!
quackhandle1975
quackhandle1975
Hall of Fame
Hall of Fame (3.3K reputation)Hall of Fame (3.3K reputation)Hall of Fame (3.3K reputation)Hall of Fame (3.3K reputation)Hall of Fame (3.3K reputation)Hall of Fame (3.3K reputation)Hall of Fame (3.3K reputation)Hall of Fame (3.3K reputation)

Group: General Forum Members
Points: 3277 Visits: 1240
Possibly for many Devs/DBAs/etc the phrase "Test & Check-In" is more apt (ie Source/Version Control).

Gary Varga (8/5/2014)
I review each and every file change before check in.


You'd be surprised (or maybe not) at how many IT companies don't bother with this procedure. And yet they wonder why mistakes happen. Blink

qh

Who looks outside, dreams; who looks inside, awakes. – Carl Jung.
Gary Varga
Gary Varga
SSCoach
SSCoach (16K reputation)SSCoach (16K reputation)SSCoach (16K reputation)SSCoach (16K reputation)SSCoach (16K reputation)SSCoach (16K reputation)SSCoach (16K reputation)SSCoach (16K reputation)

Group: General Forum Members
Points: 16955 Visits: 6534
quackhandle1975 (8/5/2014)
Possibly for many Devs/DBAs/etc the phrase "Test & Check-In" is more apt (ie Source/Version Control).

Gary Varga (8/5/2014)
I review each and every file change before check in.


You'd be surprised (or maybe not) at how many IT companies don't bother with this procedure. And yet they wonder why mistakes happen. Blink

qh


Most developers I have worked with (including good ones and DB Devs - good or otherwise) complete their testing then check in ANY CHANGES without reviewing what they have done. People who do this should be made to maintain their own code for two years after release alongside developers who say "I don't need to comment my code because I named everything well and used simple well named methods so it is all obvious".

Gaz

-- Stop your grinnin' and drop your linen...they're everywhere!!!
lshanahan
lshanahan
SSChasing Mays
SSChasing Mays (648 reputation)SSChasing Mays (648 reputation)SSChasing Mays (648 reputation)SSChasing Mays (648 reputation)SSChasing Mays (648 reputation)SSChasing Mays (648 reputation)SSChasing Mays (648 reputation)SSChasing Mays (648 reputation)

Group: General Forum Members
Points: 648 Visits: 436
On a slightly different note, I wonder how much fiscal "constraints" play into this. Think of rather small businesses who are unable (or probably more correctly unwilling) to procure adequate infrastructure to support truly good testing and QA.

I can imagine managers and directors saying, "What? You want another SQL Server license just for testing?"

Yes, it's a matter of "how can you afford not to" and the advent of better hardware and VMs has made this less of an excuse, but management and the bean counters don't always see that. They tend to have a bit of bottom line tunnel vision.

____________
Just my $0.02 from over here in the cheap seats of the peanut gallery - please adjust for inflation and/or your local currency.
sborgman
sborgman
Forum Newbie
Forum Newbie (3 reputation)Forum Newbie (3 reputation)Forum Newbie (3 reputation)Forum Newbie (3 reputation)Forum Newbie (3 reputation)Forum Newbie (3 reputation)Forum Newbie (3 reputation)Forum Newbie (3 reputation)

Group: General Forum Members
Points: 3 Visits: 75
This is a great policy. If you can stand up an exact duplicate of your environment then you can really get a good idea of what will happen. However the financial constraints typically trump a good test environment. In that case, perfection is expected and the business side doesn't understand why mistakes happen. Most people typically learn this only after they have made one of those big career changing mistakes.
Gary Varga
Gary Varga
SSCoach
SSCoach (16K reputation)SSCoach (16K reputation)SSCoach (16K reputation)SSCoach (16K reputation)SSCoach (16K reputation)SSCoach (16K reputation)SSCoach (16K reputation)SSCoach (16K reputation)

Group: General Forum Members
Points: 16955 Visits: 6534
lshanahan (8/5/2014)
...I can imagine managers and directors saying, "What? You want another SQL Server license just for testing?"
...


Sometimes Express editions can be useful for functional testing. Obviously, this is not the solution for performance testing.

Gaz

-- Stop your grinnin' and drop your linen...they're everywhere!!!
quackhandle1975
quackhandle1975
Hall of Fame
Hall of Fame (3.3K reputation)Hall of Fame (3.3K reputation)Hall of Fame (3.3K reputation)Hall of Fame (3.3K reputation)Hall of Fame (3.3K reputation)Hall of Fame (3.3K reputation)Hall of Fame (3.3K reputation)Hall of Fame (3.3K reputation)

Group: General Forum Members
Points: 3277 Visits: 1240
lshanahan (8/5/2014)
I can imagine managers and directors saying, "What? You want another SQL Server license just for testing?"


Yep, been there many times. Thankfully there are Eval/Developer/Express editions.


qh

Who looks outside, dreams; who looks inside, awakes. – Carl Jung.
Jim P.
Jim P.
SSC Eights!
SSC Eights! (947 reputation)SSC Eights! (947 reputation)SSC Eights! (947 reputation)SSC Eights! (947 reputation)SSC Eights! (947 reputation)SSC Eights! (947 reputation)SSC Eights! (947 reputation)SSC Eights! (947 reputation)

Group: General Forum Members
Points: 947 Visits: 2215
lshanahan (8/5/2014)
I can imagine managers and directors saying, "What? You want another SQL Server license just for testing?"

I've always have gotten the reading from our legal staff that setting up a server for dev or testing was considered legal and free as far as licensing is concerned. But it has to be in a separate domain.

Have they all been wrong?



----------------
Jim P.

A little bit of this and a little byte of that can cause bloatware.
Jeff Moden
Jeff Moden
SSC Guru
SSC Guru (90K reputation)SSC Guru (90K reputation)SSC Guru (90K reputation)SSC Guru (90K reputation)SSC Guru (90K reputation)SSC Guru (90K reputation)SSC Guru (90K reputation)SSC Guru (90K reputation)

Group: General Forum Members
Points: 90437 Visits: 41148
Jim P. (8/5/2014)
lshanahan (8/5/2014)
I can imagine managers and directors saying, "What? You want another SQL Server license just for testing?"

I've always have gotten the reading from our legal staff that setting up a server for dev or testing was considered legal and free as far as licensing is concerned. But it has to be in a separate domain.

Have they all been wrong?


From my understanding, it's not actually free. It should be the Developer's Edition and each chair should have a license for it. In quantity, they can be as low as 30 bucks from a good MS authorized dealer.

--Jeff Moden

RBAR is pronounced ree-bar and is a Modenism for Row-By-Agonizing-Row.
First step towards the paradigm shift of writing Set Based code:
Stop thinking about what you want to do to a row... think, instead, of what you want to do to a column.
If you think its expensive to hire a professional to do the job, wait until you hire an amateur. -- Red Adair

Helpful Links:
How to post code problems
How to post performance problems
Forum FAQs
Go


Permissions

You can't post new topics.
You can't post topic replies.
You can't post new polls.
You can't post replies to polls.
You can't edit your own topics.
You can't delete your own topics.
You can't edit other topics.
You can't delete other topics.
You can't edit your own posts.
You can't edit other posts.
You can't delete your own posts.
You can't delete other posts.
You can't post events.
You can't edit your own events.
You can't edit other events.
You can't delete your own events.
You can't delete other events.
You can't send private messages.
You can't send emails.
You can read topics.
You can't vote in polls.
You can't upload attachments.
You can download attachments.
You can't post HTML code.
You can't edit HTML code.
You can't post IFCode.
You can't post JavaScript.
You can post emoticons.
You can't post or upload images.

Select a forum

































































































































































SQLServerCentral


Search