Click here to monitor SSC
SQLServerCentral is supported by Redgate
 
Log in  ::  Register  ::  Not logged in
 
 
 


Gauging slackerness via code samples


Gauging slackerness via code samples

Poll
Do you feel it's possible to gauge a person's work ethic by looking at code they've written?

30% - 3 votes Yes
30% 3 votes
70% - 7 votes No
70% 7 votes
Member votes: 10, Guest votes: 0. You don't have permission to vote in this poll
Author
Message
RP_DBA
RP_DBA
Right there with Babe
Right there with Babe (767 reputation)Right there with Babe (767 reputation)Right there with Babe (767 reputation)Right there with Babe (767 reputation)Right there with Babe (767 reputation)Right there with Babe (767 reputation)Right there with Babe (767 reputation)Right there with Babe (767 reputation)

Group: General Forum Members
Points: 767 Visits: 1068
I was reading Steve's article on Productivity and Accountability and his observation "that people that don't want to work hard, don't" reminded me of a discussion I was in a couple weeks ago: "is it possible to gauge work ethic based on a random sampling of someone's code?" Curious to see which way people lean on this.

_____________________________________________________________________
- Nate

@nate_hughes
Evil Kraig F
Evil Kraig F
SSCertifiable
SSCertifiable (5.7K reputation)SSCertifiable (5.7K reputation)SSCertifiable (5.7K reputation)SSCertifiable (5.7K reputation)SSCertifiable (5.7K reputation)SSCertifiable (5.7K reputation)SSCertifiable (5.7K reputation)SSCertifiable (5.7K reputation)

Group: General Forum Members
Points: 5695 Visits: 7660
I would say no. Random code samples are a poor method, simply because a lot of what we do *is* simple and doesn't need a lot of exposition or intricate algorithsm.

I'm more interested in how often their code has to come back from QA for technical (not business oops we meant this) reasons, or if the DBAs know their name and groan because of the lack of effort put into optimizations.


- Craig Farrell

Never stop learning, even if it hurts. Ego bruises are practically mandatory as you learn unless you've never risked enough to make a mistake.

For better assistance in answering your questions | Forum Netiquette
For index/tuning help, follow these directions. |Tally Tables

Twitter: @AnyWayDBA
Sean Lange
Sean Lange
SSCoach
SSCoach (16K reputation)SSCoach (16K reputation)SSCoach (16K reputation)SSCoach (16K reputation)SSCoach (16K reputation)SSCoach (16K reputation)SSCoach (16K reputation)SSCoach (16K reputation)

Group: General Forum Members
Points: 16540 Visits: 16993
I would say that "it depends". I do think to that to some extent you can tell a lot about a person by their code. I don't however think you can tell about their work ethic. I know plenty of people who work really hard and produce incredibly sloppy and poor performing code. I know others that hardly work but their code is super fast and pretty enough to hang in a museum. I know which person I prefer to follow when I have to debug stuff though. :-)

_______________________________________________________________

Need help? Help us help you.

Read the article at http://www.sqlservercentral.com/articles/Best+Practices/61537/ for best practices on asking questions.

Need to split a string? Try Jeff Moden's splitter.

Cross Tabs and Pivots, Part 1 – Converting Rows to Columns
Cross Tabs and Pivots, Part 2 - Dynamic Cross Tabs
Understanding and Using APPLY (Part 1)
Understanding and Using APPLY (Part 2)
RP_DBA
RP_DBA
Right there with Babe
Right there with Babe (767 reputation)Right there with Babe (767 reputation)Right there with Babe (767 reputation)Right there with Babe (767 reputation)Right there with Babe (767 reputation)Right there with Babe (767 reputation)Right there with Babe (767 reputation)Right there with Babe (767 reputation)

Group: General Forum Members
Points: 767 Visits: 1068
Evil Kraig F (3/8/2013)
...the DBAs know their name and groan because of the lack of effort...

Funny, this is what prompted the discussion.

Sean Lange (3/8/2013)
I would say that "it depends". I do think to that to some extent you can tell a lot about a person by their code. I don't however think you can tell about their work ethic.

Maybe work ethic was the wrong word choice.

The discussion I was involved in didn't key on messy, poorly performing code but rather on routinely taking shortcuts and not following best practices. Things like data types not matching underlying tables, using "SELECT * INTO #TblName", and omitting even the simplest of comments in multi-step processes (pet peeve). Repeat offenders raise a red flag as lazy coders to me.

_____________________________________________________________________
- Nate

@nate_hughes
Evil Kraig F
Evil Kraig F
SSCertifiable
SSCertifiable (5.7K reputation)SSCertifiable (5.7K reputation)SSCertifiable (5.7K reputation)SSCertifiable (5.7K reputation)SSCertifiable (5.7K reputation)SSCertifiable (5.7K reputation)SSCertifiable (5.7K reputation)SSCertifiable (5.7K reputation)

Group: General Forum Members
Points: 5695 Visits: 7660
RP_DBA (3/8/2013)

The discussion I was involved in didn't key on messy, poorly performing code but rather on routinely taking shortcuts and not following best practices.

Depends on the best practice. I routinely omit RI for example because I find it frustrating down the road a lot of times. I use it only when it's absolutely required.

However...

Things like data types not matching underlying tables,


Okay, THAT'S lazy.

using "SELECT * INTO #TblName"

Guilty, depending on circumstances

, and omitting even the simplest of comments in multi-step processes (pet peeve).

Also guilty. Most T-SQL is self explanatory. The only time I put in comments is when I feel the code doesn't explain the reason. Most of my comments are about the business reasons really odd algorithms are required, not about the code itself. If I'm breaking established patterns or obvious coding techniques I'll also comment for the reasons so if someone inherits it they don't just remove it when I did it for optimization, not clarity.


- Craig Farrell

Never stop learning, even if it hurts. Ego bruises are practically mandatory as you learn unless you've never risked enough to make a mistake.

For better assistance in answering your questions | Forum Netiquette
For index/tuning help, follow these directions. |Tally Tables

Twitter: @AnyWayDBA
Jeff Moden
Jeff Moden
SSC-Forever
SSC-Forever (44K reputation)SSC-Forever (44K reputation)SSC-Forever (44K reputation)SSC-Forever (44K reputation)SSC-Forever (44K reputation)SSC-Forever (44K reputation)SSC-Forever (44K reputation)SSC-Forever (44K reputation)

Group: General Forum Members
Points: 44977 Visits: 39869
I've found that it's gross ignorance in that people haven't been trained as to all the reasons why you should format your code and include thoughtful/meaningful comments.

I've found that it's gross incompetence usually caused by gross ignorance that amplifies the problem.

I've also found some real live brainwashing caused by a grossly incorrect interpretations of things like the "Agile Manifesto" and Knuth's famous words about pre-optimization being the root of all evil. That brainwashing also includes stupid things like hitting the schedule no matter if the code is right or not.

But I've not found it's because of "slackerness" because it takes a hell of a lot of energy to fight that hard against doing it right. ;-)

--Jeff Moden

RBAR is pronounced ree-bar and is a Modenism for Row-By-Agonizing-Row.
First step towards the paradigm shift of writing Set Based code:
     Stop thinking about what you want to do to a row... think, instead, of what you want to do to a column.
Although they tell us that they want it real bad, our primary goal is to ensure that we dont actually give it to them that way.
Although change is inevitable, change for the better is usually not.
Just because you can do something in PowerShell, doesnt mean you should. Wink

Helpful Links:
How to post code problems
How to post performance problems
Forum FAQs
Go


Permissions

You can't post new topics.
You can't post topic replies.
You can't post new polls.
You can't post replies to polls.
You can't edit your own topics.
You can't delete your own topics.
You can't edit other topics.
You can't delete other topics.
You can't edit your own posts.
You can't edit other posts.
You can't delete your own posts.
You can't delete other posts.
You can't post events.
You can't edit your own events.
You can't edit other events.
You can't delete your own events.
You can't delete other events.
You can't send private messages.
You can't send emails.
You can read topics.
You can't vote in polls.
You can't upload attachments.
You can download attachments.
You can't post HTML code.
You can't edit HTML code.
You can't post IFCode.
You can't post JavaScript.
You can post emoticons.
You can't post or upload images.

Select a forum

































































































































































SQLServerCentral


Search