sql trigger problem

  • I am trying to write my first trigger on a sql server 2008 r2 database.

    I keep getting a procedure error the 'INSERT INTO [dbo].[RPT_Trans_Audit]

    (Package_ID, Received_Date, Download_Date)' statement listed below. I do

    not know what is wrong. Can you tell me what I need to change?

    USE DEV2

    GO

    CREATE TRIGGER [dbo].[RPT_Trans_Audit] ON [RPT_Trans]

    AFTER INSERT, UPDATE, DELETE

    AS

    BEGIN

    SET NOCOUNT ON;

    BEGIN TRY

    INSERT INTO [dbo].[RPT_Trans_Audit] (Package_ID, Received_Date, Download_Date)

    SELECT Package_ID, Received_Date, Download_Date

    FROM INSERTED

    END TRY

    GO

  • Hi,

    the trigger is missing a begin catch & end catch block.

    --------------------------------------------------------------------------------------
    Hai Ton
    My Db4Breakfast blog.

  • You were also missing the END that matched the opening BEGIN. If you do not plan on doing any custom error handling, e.g. enriching the error message, in the trigger then I would recommend completely removing the TRY/CATCH and go with something simple like this:

    USE DEV2

    GO

    CREATE TRIGGER [dbo].[RPT_Trans_Audit] ON [RPT_Trans]

    AFTER INSERT, UPDATE, DELETE

    AS

    BEGIN

    SET NOCOUNT ON;

    INSERT INTO [dbo].[RPT_Trans_Audit]

    (

    Package_ID,

    Received_Date,

    Download_Date

    )

    SELECT Package_ID,

    Received_Date,

    Download_Date

    FROM INSERTED;

    END

    GO

    There are no special teachers of virtue, because virtue is taught by the whole community.
    --Plato

  • The sql you gave me works correctly. I just submitted the query in a general query window. My problem is I do not know where the database trigger is located at.

    I looked for the trigger under the database triggers and I can not find it. Thus do I need to do one of the following:

    1. Make certain I have access to the trigger- correct permissions?

    2. should I run the query as ' create a database trigger' in sql server management sutdio?

    3. Do you have anyt other suggestions?

  • wendy elizabeth (1/27/2013)


    The sql you gave me works correctly. I just submitted the query in a general query window. My problem is I do not know where the database trigger is located at.

    I looked for the trigger under the database triggers and I can not find it. Thus do I need to do one of the following:

    1. Make certain I have access to the trigger- correct permissions?

    2. should I run the query as ' create a database trigger' in sql server management sutdio?

    3. Do you have anyt other suggestions?

    Try expanding the table and you'll see a TRIGGERS branch there. It will be under that.


    My mantra: No loops! No CURSORs! No RBAR! Hoo-uh![/I]

    My thought question: Have you ever been told that your query runs too fast?

    My advice:
    INDEXing a poor-performing query is like putting sugar on cat food. Yeah, it probably tastes better but are you sure you want to eat it?
    The path of least resistance can be a slippery slope. Take care that fixing your fixes of fixes doesn't snowball and end up costing you more than fixing the root cause would have in the first place.

    Need to UNPIVOT? Why not CROSS APPLY VALUES instead?[/url]
    Since random numbers are too important to be left to chance, let's generate some![/url]
    Learn to understand recursive CTEs by example.[/url]
    [url url=http://www.sqlservercentral.com/articles/St

  • I'm sure this is not the case, but thought I should mention: make certain the ID column in your audit table is not a identity column.

    ----------------------------------------------------

Viewing 6 posts - 1 through 5 (of 5 total)

You must be logged in to reply to this topic. Login to reply