marcia.j.wilson (5/7/2015)
Eric M Russell (2/10/2012)
Another scenario is where the developer includes un-needed table joins and returns additional columns that are never referenced by the application or reporting tool. I've even seen procedures that query an interim result into a temp table, which is then never used. This is often the result of a developer wrting a new stored procedure by copy/pasting from an existing stored procedure, and then failing to remove those table joins, columns, and code that arn't needed.Copy/paste is a great way to avoid unnecessary work and I use it often. But it does require someone smart enough to figure out what's really needed in the new code and what should be dropped. Unfortunately, some people are too lazy to do that.
Another thing that irks me is when someone copies/pastes from code I've created, including header comments, and then leaves my name as the creator on their code. Especially when it's code I would never have created.
On a similar note, what irritates me is when I've inherited the job of maintaining a 5,000 line legacy stored procedure and the original developer never bothered to comment their code in the header. I always make a header notation, including date, my name, and TFS ticket number. So it now looks like I created the damn thing.
Sometimes when I make my first modification, I'll start the header off with a notation (disclaimer really :-P) that includes the name of the orignal developer and the approximate date it was first deployed to production, even if that developer has since moved on to other things more in line with their skillset and ambitions (like roadside sign flipping :-P).
"Do not seek to follow in the footsteps of the wise. Instead, seek what they sought." - Matsuo Basho