Evil Kraig F (6/3/2014)

---

Sorry, ;WITH is ingrained into my head at this point. You're stuck with it if you chase me in my code.

I agree with a decent amount of what's been said here. I personally trail my commas.

Personal pet peeves not already stated:

not using AS when you define your field names/table aliases. Drives me NUTS because now I'm looking at forumulas not aliasing.

Indent your damned CASE trees/IF trees/whatevers intelligently and consistently. I expect to be able to page down a few times and see, clearly, where that cursor from hell you built ends. I don't expect to have to dig through 6 ENDs to figure out which one is the trailer for the thing when I'm prepping to gut it.

INDEX (0). Particularly without comment(s).

SSIS: Using Row Redirection on bad rows without creating an error trap table to deal with them.

SSIS: Not understanding what a configuration is. How to use it I can train, not knowing it's there is on you.

SSIS: Crappy naming methods for your data sources. You're connecting this thing to a database and you're going to push it through environments. It doesn't need to be named "Martha's stuff in a table". Name it after the database. And for the love of god if I see one more 'Textfile 1', 'Textfile 2' I may shoot someone. At the very LEAST: Inbound CSV from Client, Outbound Flatfile to GL. Or something.

SSIS: Trying to create some form of alternate error logging and delivery system other than what's built in. Because yes, everyone should learn YOUR bloody mess of a system instead of the two that's documented and already included (SSIS logging and step logging in the job).

SSIS: Scoping variables at very low levels, and then re-using the name elsewhere. I get scope. I get why it's used in PROGRAMMING. I don't expect to have to click on EVERY object on the screen to figure out where the hell you scoped something. Global them.