Syntax Error with Trigger

  • Hi

    I have a syntax error I can't figure out. It's probably simple but I don't see it. Any suggestions?

    CREATE TRIGGER Trigger_20321 ON FACT_CUST_GRP_ICM_MO

    AFTER DELETE

    AS

    /* DELETE trigger on FACT_CUST_GRP_ICM_MO */

    /* default body for Trigger_20321 */

    BEGIN

    DECLARE @numrows int,

    @nullcnt int,

    @validcnt int,

    @INSFACT_GRP_PROD_ICM_MO_SK char(100),

    @errno int,

    @errmsg varchar(255)

    SELECT @numrows = @@rowcount

    RETURN

    error:

    raiserror (@errno, @errmsg)

    rollback transaction

    END

    go

    Msg 102, Level 15, State 1, Procedure Trigger_20321, Line 21

    Incorrect syntax near ')'.

    The error is in line: raiserror (@errno, @errmsg)

  • jdbrown239 (5/9/2014)


    Hi

    I have a syntax error I can't figure out. It's probably simple but I don't see it. Any suggestions?

    CREATE TRIGGER Trigger_20321 ON FACT_CUST_GRP_ICM_MO

    AFTER DELETE

    AS

    /* DELETE trigger on FACT_CUST_GRP_ICM_MO */

    /* default body for Trigger_20321 */

    BEGIN

    DECLARE @numrows int,

    @nullcnt int,

    @validcnt int,

    @INSFACT_GRP_PROD_ICM_MO_SK char(100),

    @errno int,

    @errmsg varchar(255)

    SELECT @numrows = @@rowcount

    RETURN

    error:

    raiserror (@errno, @errmsg)

    rollback transaction

    END

    go

    Msg 102, Level 15, State 1, Procedure Trigger_20321, Line 21

    Incorrect syntax near ')'.

    The error is in line: raiserror (@errno, @errmsg)

    What are you trying to do in this trigger? It looks like something that is partially started and never finished. What are all the variables? You do realize they are all NULL right? This has the look of being a trigger that is not designed to handle multiple rows. I am also scared when I see named code blocks. This is an indication you are planning on using a goto. We can handle errors far more gracefully than that these days. You might want to look at try-catch.

    _______________________________________________________________

    Need help? Help us help you.

    Read the article at http://www.sqlservercentral.com/articles/Best+Practices/61537/ for best practices on asking questions.

    Need to split a string? Try Jeff Modens splitter http://www.sqlservercentral.com/articles/Tally+Table/72993/.

    Cross Tabs and Pivots, Part 1 – Converting Rows to Columns - http://www.sqlservercentral.com/articles/T-SQL/63681/
    Cross Tabs and Pivots, Part 2 - Dynamic Cross Tabs - http://www.sqlservercentral.com/articles/Crosstab/65048/
    Understanding and Using APPLY (Part 1) - http://www.sqlservercentral.com/articles/APPLY/69953/
    Understanding and Using APPLY (Part 2) - http://www.sqlservercentral.com/articles/APPLY/69954/

Viewing 2 posts - 1 through 1 (of 1 total)

You must be logged in to reply to this topic. Login to reply