Home Forums SQL Server 2008 SQL Server 2008 - General SQL Function takes more than 2 hours to return a table.. RE: SQL Function takes more than 2 hours to return a table..

  • February 6, 2013 at 1:03 pm

    #1585113

    k.srikalyan (2/6/2013)

    Try to create a primary key/unique key on your table variable, and it is always better to go as a stored proc using temp tables and while loop instead of cursors and try building a clustered index on the temp table which will definitely improve your performance.

    bobie (2/6/2013)

    Not really looking in detail but

    I think it should be a store procedure.

    And I quite sure we can eliminated the cursor using temp table and update and set variables in a single query.

    Absolutely not. Temp table/While loop replacements for cursors is like smoking a pipe to quit cigars. They're essential identical and a well written firehose cursor (read only, forward only) is frequently faster than the Temp Table/While loop combination. To wit, replacing cursors with While Loops does little to help the situation and will sometimes cause even worse performance because most people aren't good at writing either. 😉

    Please don't make such recommendations in the future because it's a myth and a general bad recommedation to replace cursors with Temp Tables/While loops.

    --Jeff Moden

    RBAR is pronounced "ree-bar" and is a "Modenism" for Row-By-Agonizing-Row.
    First step towards the paradigm shift of writing Set Based code:
    ________Stop thinking about what you want to do to a ROW... think, instead, of what you want to do to a COLUMN.

    Change is inevitable... Change for the better is not.

    Helpful Links:
    How to post code problems
    How to Post Performance Problems
    Create a Tally Function (fnTally)