bicky1980 (1/2/2013)
Hi AllI am just after a bit of clarification. I am writing a procedure which inserts data from one table (Source) into another (Destination) using certain criteria. (E.g. People Aged 50+)
insert into destination select * from source where age>49
I then want to set a variable using the numbers of records I have just appended into this table (Destination) - select @totalrecs=count(*) from destination
The Next step is to peform a calculation (2000-[no of records inserted into destination table])
select @totalrecs=2000-@totalrecs
Then I want to insert into the destination, using the result of the calculation,
insert into destination select top @totalrecs from source where [criteria] order by newid()
Now I am trying to do all this in one fluent procedure - could someone advise me of the best way to do this?
I am currently attempting to do this in the following manner:
declare @sql nvarchar(1000),
@totalrecs int
set @sql='insert into source select * from destination where age>49
select @totalrecs=count(*) from destination
set @totalrecs=2000-@totalrecs
insert into destination
select top '+CONVERT(NVARCHAR(10),@TOTALRECS)+' * from source
where age<50'
Print @sql
Exec(@sql)
Nothing is returned to the screen (from the print command) and the query is not executed - Anybody have an idea why and maybe suggest a better way to perform this
Thanks
Here's my two cents worth:
1. As an earlier responder pointed out, this doesn't need to be dynamic SQL because you can run:
insert into destination
select top (expr) * from source
where age<50'
Where expr is a query like:
select @totalrecs=2000-count(*) from destination
2. What do you expect to happen when more than 2000 records are INSERTed into destination in the first query? In other words, 2000-count(*) is negative.
My thought question: Have you ever been told that your query runs too fast?
My advice:
INDEXing a poor-performing query is like putting sugar on cat food. Yeah, it probably tastes better but are you sure you want to eat it?
The path of least resistance can be a slippery slope. Take care that fixing your fixes of fixes doesn't snowball and end up costing you more than fixing the root cause would have in the first place.
Need to UNPIVOT? Why not CROSS APPLY VALUES instead?[/url]
Since random numbers are too important to be left to chance, let's generate some![/url]
Learn to understand recursive CTEs by example.[/url]
[url url=http://www.sqlservercentral.com/articles/St