A couple thoughts...perhaps the empty space string contains more (or less than one space) and also what happens when the souce column is null ?

Perhaps try....

civilianYears == "--" || TRIM(civilianYears) == "" || ISNULL (civilianYears) ? NULL(DT_I4) : (DT_I4)civilianYears