January 26, 2008 at 11:40 pm
Hi,
Most of the SPs in our db written in a old format style and i dont thing that is the best way of write a query.
eg:
1) in where criteria
where 1=1
and ....
I dont think 1=1 is necessary in where criteria. is it affect performance?
2) all sps are written with RETURN stt. I dont think this RETURN required.
can you also suggest some best approach/practice to write a query?
January 27, 2008 at 10:38 am
Even if you don't explicitly state a return value, all stored procedures have one. I prefer to do something along these lines in 2005 (similar, but different error handling, in 2000).
CREATE MyProc
AS
BEGIN TRY
... write the query
END TRY
BEGIN CATCH
...more error handling as necessary
RETURN ERROR_NUMBER();
END CATCH
RETURN 0;
"The credit belongs to the man who is actually in the arena, whose face is marred by dust and sweat and blood"
- Theodore Roosevelt
Author of:
SQL Server Execution Plans
SQL Server Query Performance Tuning
January 27, 2008 at 10:59 am
Balaji (1/26/2008)
I dont think 1=1 is necessary in where criteria. is it affect performance?
Not necessary at all. It shouldn't affect performance. The optimiser should be smart enough to ignore it. however, better be safe and take it out.
Gail Shaw
Microsoft Certified Master: SQL Server, MVP, M.Sc (Comp Sci)
SQL In The Wild: Discussions on DB performance with occasional diversions into recoverability
January 31, 2008 at 4:24 am
Balaji (1/26/2008)
1) in where criteriawhere 1=1
and ....
The only time I've seen this done is in generated queries. That is, a query is built from selecting various options where any combination may occur.sqlstring = "SELECT ... WHERE 1=1"
if (opt1) then sqlstring = sqlstring + " AND (...)"
if (opt2) then sqlstring = sqlstring + " AND (...)"
if (op33) then sqlstring = sqlstring + " AND (...)"
If the queries are 'hardcoded' then you may as well clean them up.
Balaji (1/26/2008)
can you also suggest some best approach/practice to write a query?
Write it so it returns the right results:)
Seriously... I've found that, although it doesn't affect performance, consistent good formatting helps keep track of what's going on. If your db has all the foreign keys defined properly, then SSMS' view creation is a good way to start; I then edit the SQL to include aliases (otherwise it's far too messy) and finallly switch to a query window to get the formatting right as the layout generated by SSMS is pretty unreadable.
Derek.
Derek
Viewing 4 posts - 1 through 3 (of 3 total)
You must be logged in to reply to this topic. Login to reply