|
|
|
SSCommitted
      
Group: Moderators
Last Login: Monday, August 13, 2012 1:06 PM
Points: 1,928,
Visits: 224
|
|
|
|
|
|
Forum Newbie
      
Group: General Forum Members
Last Login: Sunday, January 13, 2013 9:22 AM
Points: 1,
Visits: 14
|
|
Hi Brian, In trying to run the MSforEachTrigger script in 2005 I'm getting errors - any idea what's going on?? Thanks, Simon Msg 16950, Level 16, State 2, Procedure sp_MSforeach_worker, Line 27 The variable '@local_cursor' does not currently have a cursor allocated to it. Msg 16950, Level 16, State 2, Procedure sp_MSforeach_worker, Line 32 The variable '@local_cursor' does not currently have a cursor allocated to it. Msg 16950, Level 16, State 2, Procedure sp_MSforeach_worker, Line 153 The variable '@local_cursor' does not currently have a cursor allocated to it. Msg 16916, Level 16, State 1, Procedure sp_MSforeach_worker, Line 155 A cursor with the name 'hCForEachDatabase' does not exist.
|
|
|
|
|
SSCrazy
      
Group: General Forum Members
Last Login: 2 days ago @ 11:37 AM
Points: 2,551,
Visits: 7,201
|
|
And the 4 "foreach" links at the bottom of the page are dead.
|
|
|
|
|
SSC Rookie
      
Group: General Forum Members
Last Login: Sunday, August 05, 2012 9:18 PM
Points: 39,
Visits: 56
|
|
Just came across the error myself.
Msg 16950, Level 16, State 2, Procedure sp_MSforeach_worker, Line 31 The variable '@local_cursor' does not currently have a cursor allocated to it. The statement has been terminated.
The sp's [sp_MSforeachtable] and [sp_MSforeach_worker] have been changed, for a start they now belong to the sys schema (no longer prefixed dbo, but I think SQL finds the sys schema copy anyway) and the cursor sp_MSforeachtable uses when it calls sp_MSforeach_worker is "hCForEachTable" (or "hCForEachDatabase" for databases) instead of "hCForEach". They've also added another variable to distinguish for each database and each table. The error message you get is because the new cursor name doesn't match the old name (which is in the sp's in the original article).
Just follow the original instructions to alter the current sp_MSforeachtable to create the new ones, you could try fixing the originals but easier to start again.
Cheers Fred
|
|
|
|
|
Forum Newbie
      
Group: General Forum Members
Last Login: Friday, February 15, 2013 2:25 PM
Points: 5,
Visits: 55
|
|
Just had a go at this myself, ran into some errors, thought I'd post what needed to be done for SQL 2008 R2 to hopefully help the next guy get through it a bit faster.
The key, as mentioned above, is the changed procedure. After that, it's important to change SET QUOTED IDENTIFIER OFF - not ON, as in the original article code. Took me a minute (and a helpful blog from a fellow in Romania) to get that. 
USE MASTER GO
if exists (select name from sysobjects where name = 'sp_MSforeachview' AND type = 'P') drop procedure sp_MSforeachview GO
SET QUOTED_IDENTIFIER OFF GO SET ANSI_NULLS ON GO
create proc sp_MSforeachview @command1 nvarchar(2000), @replacechar nchar(1) = N'?', @command2 nvarchar(2000) = null, @command3 nvarchar(2000) = null, @whereand nvarchar(2000) = null, @precommand nvarchar(2000) = null, @postcommand nvarchar(2000) = null as /* This proc returns one or more rows for each table (optionally, matching @where), with each table defaulting to its own result set */ /* @precommand and @postcommand may be used to force a single result set via a temp table. */
/* Preprocessor won't replace within quotes so have to use str(). */ declare @mscat nvarchar(12) select @mscat = ltrim(str(convert(int, 0x0002)))
if (@precommand is not null) exec(@precommand)
/* Create the select */ exec(N'declare hCForEachTable cursor global for select ''['' + REPLACE(schema_name(syso.schema_id), N'']'', N'']]'') + '']'' + ''.'' + ''['' + REPLACE(object_name(o.id), N'']'', N'']]'') + '']'' from dbo.sysobjects o join sys.all_objects syso on o.id = syso.object_id ' + N' where OBJECTPROPERTY(o.id, N''IsView'') = 1 ' + N' and o.category & ' + @mscat + N' = 0 ' + @whereand) declare @retval int select @retval = @@error if (@retval = 0) exec @retval = sys.sp_MSforeach_worker @command1, @replacechar, @command2, @command3, 0
if (@retval = 0 and @postcommand is not null) exec(@postcommand)
return @retval
GO SET ANSI_NULLS ON GO
|
|
|
|
|
SSCrazy Eights
        
Group: General Forum Members
Last Login: Saturday, May 04, 2013 11:13 AM
Points: 9,855,
Visits: 9,374
|
|
|
|
|