Click here to monitor SSC
SQLServerCentral is supported by Red Gate Software Ltd.
 
Log in  ::  Register  ::  Not logged in
 
 
 
        
Home       Members    Calendar    Who's On


Add to briefcase

Syntax Error with Trigger Expand / Collapse
Author
Message
Posted Friday, May 9, 2014 12:10 PM


SSC-Enthusiastic

SSC-EnthusiasticSSC-EnthusiasticSSC-EnthusiasticSSC-EnthusiasticSSC-EnthusiasticSSC-EnthusiasticSSC-EnthusiasticSSC-Enthusiastic

Group: General Forum Members
Last Login: Thursday, September 4, 2014 8:05 AM
Points: 133, Visits: 283
Hi
I have a syntax error I can't figure out. It's probably simple but I don't see it. Any suggestions?

[code = "sql"]CREATE TRIGGER Trigger_20321 ON FACT_CUST_GRP_ICM_MO
AFTER DELETE

AS
/* DELETE trigger on FACT_CUST_GRP_ICM_MO */
/* default body for Trigger_20321 */
BEGIN
DECLARE @numrows int,
@nullcnt int,
@validcnt int,
@INSFACT_GRP_PROD_ICM_MO_SK char(100),
@errno int,
@errmsg varchar(255)

SELECT @numrows = @@rowcount


RETURN
error:
raiserror (@errno, @errmsg)
rollback transaction
END

go [code]

Msg 102, Level 15, State 1, Procedure Trigger_20321, Line 21
Incorrect syntax near ')'.


The error is in line: raiserror (@errno, @errmsg)
Post #1569406
Posted Friday, May 9, 2014 12:23 PM


SSChampion

SSChampionSSChampionSSChampionSSChampionSSChampionSSChampionSSChampionSSChampionSSChampionSSChampion

Group: General Forum Members
Last Login: Yesterday @ 2:34 PM
Points: 13,481, Visits: 12,342
jdbrown239 (5/9/2014)
Hi
I have a syntax error I can't figure out. It's probably simple but I don't see it. Any suggestions?

[code = "sql"]CREATE TRIGGER Trigger_20321 ON FACT_CUST_GRP_ICM_MO
AFTER DELETE

AS
/* DELETE trigger on FACT_CUST_GRP_ICM_MO */
/* default body for Trigger_20321 */
BEGIN
DECLARE @numrows int,
@nullcnt int,
@validcnt int,
@INSFACT_GRP_PROD_ICM_MO_SK char(100),
@errno int,
@errmsg varchar(255)

SELECT @numrows = @@rowcount


RETURN
error:
raiserror (@errno, @errmsg)
rollback transaction
END

go [code]

Msg 102, Level 15, State 1, Procedure Trigger_20321, Line 21
Incorrect syntax near ')'.


The error is in line: raiserror (@errno, @errmsg)


What are you trying to do in this trigger? It looks like something that is partially started and never finished. What are all the variables? You do realize they are all NULL right? This has the look of being a trigger that is not designed to handle multiple rows. I am also scared when I see named code blocks. This is an indication you are planning on using a goto. We can handle errors far more gracefully than that these days. You might want to look at try-catch.


_______________________________________________________________

Need help? Help us help you.

Read the article at http://www.sqlservercentral.com/articles/Best+Practices/61537/ for best practices on asking questions.

Need to split a string? Try Jeff Moden's splitter.

Cross Tabs and Pivots, Part 1 – Converting Rows to Columns
Cross Tabs and Pivots, Part 2 - Dynamic Cross Tabs
Understanding and Using APPLY (Part 1)
Understanding and Using APPLY (Part 2)
Post #1569411
« Prev Topic | Next Topic »

Add to briefcase

Permissions Expand / Collapse