Click here to monitor SSC
SQLServerCentral is supported by Red Gate Software Ltd.
 
Log in  ::  Register  ::  Not logged in
 
 
 
        
Home       Members    Calendar    Who's On


Add to briefcase 12»»

Ok, so it sort of is about SQL.... Expand / Collapse
Author
Message
Posted Thursday, April 18, 2013 9:43 AM


SSCommitted

SSCommittedSSCommittedSSCommittedSSCommittedSSCommittedSSCommittedSSCommittedSSCommitted

Group: General Forum Members
Last Login: Wednesday, August 20, 2014 5:29 PM
Points: 1,787, Visits: 5,693
...but this made me laugh today...

Seen in some production code:

	LEFT OUTER JOIN Northwind.dbo.orders_actioned ON scheme.opheadm.order_no = Northwind.dbo.orders_actioned.order_no

...just WOW!


MM


  • MMGrid Addin
  • MMNose Addin


  • Forum Etiquette: How to post Reporting Services problems
  • Forum Etiquette: How to post data/code on a forum to get the best help - by Jeff Moden
  • How to Post Performance Problems - by Gail Shaw

  • Post #1443958
    Posted Thursday, April 18, 2013 3:07 PM


    Hall of Fame

    Hall of FameHall of FameHall of FameHall of FameHall of FameHall of FameHall of FameHall of FameHall of Fame

    Group: General Forum Members
    Last Login: Yesterday @ 5:29 PM
    Points: 3,513, Visits: 7,565
    I was just going to post about some nonsense I've heard an seen in my new job (and it's only my second day)

    I'm changing the code, but I leave the basic idea of what made me say WTF
    TRUNCATE TABLE Temp_Table

    INSERT INTO Temp_Table
    SELECT period_id,
    1 AS country_id,
    column_x,
    column_y,
    column_z
    FROM SomeCountryDB..SomeTable

    DELETE FROM Temp_Table
    WHERE period_id BETWEEN @start_period AND @end_period
    AND country_id = 2

    INSERT INTO Temp_Table
    SELECT period_id,
    2 AS country_id,
    column_x,
    column_y,
    column_z
    FROM OtherCountryDB..SomeTable

    DELETE FROM Temp_Table
    WHERE period_id BETWEEN @start_period AND @end_period
    AND country_id = 3


    ---And so on with 7 tables

    Maybe some rows appeared out of nowhere, we'll better delete them.

    And the quote that made my day:
    I'm not sure if it's using a LEFT JOIN or an LEFT OUTER JOIN, I'll have to check



    Luis C.
    Are you seriously taking the advice and code from someone from the internet without testing it? Do you at least understand it? Or can it easily kill your server?

    Forum Etiquette: How to post data/code on a forum to get the best help
    Post #1444161
    Posted Thursday, April 18, 2013 3:26 PM


    SSChampion

    SSChampionSSChampionSSChampionSSChampionSSChampionSSChampionSSChampionSSChampionSSChampionSSChampion

    Group: General Forum Members
    Last Login: Yesterday @ 3:13 PM
    Points: 13,282, Visits: 12,116
    Luis Cazares (4/18/2013)
    I was just going to post about some nonsense I've heard an seen in my new job (and it's only my second day)


    Maybe you should keep that resume handy? That is really scary!!! There are so many things wrong with that it is hard to know where to start. Let's start with a permanent table named temp_table. WTF??? Then of course there is the insanity of what originally made your eyes bleed.


    _______________________________________________________________

    Need help? Help us help you.

    Read the article at http://www.sqlservercentral.com/articles/Best+Practices/61537/ for best practices on asking questions.

    Need to split a string? Try Jeff Moden's splitter.

    Cross Tabs and Pivots, Part 1 – Converting Rows to Columns
    Cross Tabs and Pivots, Part 2 - Dynamic Cross Tabs
    Understanding and Using APPLY (Part 1)
    Understanding and Using APPLY (Part 2)
    Post #1444171
    Posted Thursday, April 18, 2013 4:02 PM
    SSCarpal Tunnel

    SSCarpal TunnelSSCarpal TunnelSSCarpal TunnelSSCarpal TunnelSSCarpal TunnelSSCarpal TunnelSSCarpal TunnelSSCarpal TunnelSSCarpal Tunnel

    Group: General Forum Members
    Last Login: Tuesday, August 19, 2014 3:37 PM
    Points: 4,389, Visits: 9,522
    But...what if truncate doesn't actually remove everything that was there before? Don't we have to be sure we delete it before we insert?

    Jeffrey Williams
    Problems are opportunites brilliantly disguised as insurmountable obstacles.

    How to post questions to get better answers faster
    Managing Transaction Logs
    Post #1444184
    Posted Thursday, April 18, 2013 10:18 PM


    Hall of Fame

    Hall of FameHall of FameHall of FameHall of FameHall of FameHall of FameHall of FameHall of FameHall of Fame

    Group: General Forum Members
    Last Login: Yesterday @ 5:29 PM
    Points: 3,513, Visits: 7,565
    Sean Lange (4/18/2013)


    Maybe you should keep that resume handy? That is really scary!!! There are so many things wrong with that it is hard to know where to start. Let's start with a permanent table named temp_table. WTF??? Then of course there is the insanity of what originally made your eyes bleed.


    Well the names aren't actually the real ones, I changed them. But it's still a permanent table used as stage table. However, the worst part is that I've seen a permanent table named something like Accounts_Movements_2008_temp that is still used to store all the information from 2006 to the current date.

    Seems like I have bad luck with companies's databases. However, I hope to make some changes for the better or I'll be looking for a new job really soon.



    Luis C.
    Are you seriously taking the advice and code from someone from the internet without testing it? Do you at least understand it? Or can it easily kill your server?

    Forum Etiquette: How to post data/code on a forum to get the best help
    Post #1444224
    Posted Friday, April 19, 2013 7:04 AM
    SSCrazy

    SSCrazySSCrazySSCrazySSCrazySSCrazySSCrazySSCrazySSCrazy

    Group: General Forum Members
    Last Login: Yesterday @ 12:23 PM
    Points: 2,548, Visits: 3,789
    Ha ha ha ha. Using Northwind.

    I had someone ask me about Northwind a few years ago. It looked like such a good database layout that a manager actually thought about using it.
    I explained to them that it was intended only for practice. The response was something along the lines of why bother designing a database when one was already there. It would cost time and money to not use it.

    I should should follow up with the company and see if they did use Northwind.

    Post #1444370
    Posted Friday, April 19, 2013 2:46 PM


    SSChampion

    SSChampionSSChampionSSChampionSSChampionSSChampionSSChampionSSChampionSSChampionSSChampionSSChampion

    Group: General Forum Members
    Last Login: Yesterday @ 3:13 PM
    Points: 13,282, Visits: 12,116
    I had to dig around a bit to find this one. One of our legacy tables replicated from the Main Frame has a table that nobody really knows it is for but...

    There is a column ConstantC char(1).

    Anyone want to take a guess what value you will find in all 1.2 million rows???

    Not only do we have 1.2 million copies of the same value, just using the column is 9 or 10 extra keystrokes than just using the actual constant from the keyboard.


    _______________________________________________________________

    Need help? Help us help you.

    Read the article at http://www.sqlservercentral.com/articles/Best+Practices/61537/ for best practices on asking questions.

    Need to split a string? Try Jeff Moden's splitter.

    Cross Tabs and Pivots, Part 1 – Converting Rows to Columns
    Cross Tabs and Pivots, Part 2 - Dynamic Cross Tabs
    Understanding and Using APPLY (Part 1)
    Understanding and Using APPLY (Part 2)
    Post #1444616
    Posted Friday, April 19, 2013 3:28 PM


    SSCommitted

    SSCommittedSSCommittedSSCommittedSSCommittedSSCommittedSSCommittedSSCommittedSSCommitted

    Group: General Forum Members
    Last Login: Wednesday, August 20, 2014 5:29 PM
    Points: 1,787, Visits: 5,693
    Sean Lange (4/19/2013)
    I had to dig around a bit to find this one. One of our legacy tables replicated from the Main Frame has a table that nobody really knows it is for but...

    There is a column ConstantC char(1).

    Anyone want to take a guess what value you will find in all 1.2 million rows???

    Not only do we have 1.2 million copies of the same value, just using the column is 9 or 10 extra keystrokes than just using the actual constant from the keyboard.


    Please tell me there is an index on it as well!


    MM


  • MMGrid Addin
  • MMNose Addin


  • Forum Etiquette: How to post Reporting Services problems
  • Forum Etiquette: How to post data/code on a forum to get the best help - by Jeff Moden
  • How to Post Performance Problems - by Gail Shaw

  • Post #1444624
    Posted Friday, April 19, 2013 3:48 PM


    SSC-Insane

    SSC-InsaneSSC-InsaneSSC-InsaneSSC-InsaneSSC-InsaneSSC-InsaneSSC-InsaneSSC-InsaneSSC-InsaneSSC-InsaneSSC-Insane

    Group: General Forum Members
    Last Login: Yesterday @ 3:27 PM
    Points: 21,631, Visits: 15,289
    Jeffrey Williams 3188 (4/18/2013)
    But...what if truncate doesn't actually remove everything that was there before? Don't we have to be sure we delete it before we insert?


    Obviously truncate means randomly delete data iif you feel like it.




    Jason AKA CirqueDeSQLeil
    I have given a name to my pain...
    MCM SQL Server


    SQL RNNR

    Posting Performance Based Questions - Gail Shaw
    Posting Data Etiquette - Jeff Moden
    Hidden RBAR - Jeff Moden
    VLFs and the Tran Log - Kimberly Tripp
    Post #1444629
    Posted Monday, April 22, 2013 7:31 AM


    SSChampion

    SSChampionSSChampionSSChampionSSChampionSSChampionSSChampionSSChampionSSChampionSSChampionSSChampion

    Group: General Forum Members
    Last Login: Yesterday @ 3:13 PM
    Points: 13,282, Visits: 12,116
    mister.magoo (4/19/2013)
    Sean Lange (4/19/2013)
    I had to dig around a bit to find this one. One of our legacy tables replicated from the Main Frame has a table that nobody really knows it is for but...

    There is a column ConstantC char(1).

    Anyone want to take a guess what value you will find in all 1.2 million rows???

    Not only do we have 1.2 million copies of the same value, just using the column is 9 or 10 extra keystrokes than just using the actual constant from the keyboard.


    Please tell me there is an index on it as well!


    No the table is a heap!!! I have been asking around and nobody knows what the table is even used for.


    _______________________________________________________________

    Need help? Help us help you.

    Read the article at http://www.sqlservercentral.com/articles/Best+Practices/61537/ for best practices on asking questions.

    Need to split a string? Try Jeff Moden's splitter.

    Cross Tabs and Pivots, Part 1 – Converting Rows to Columns
    Cross Tabs and Pivots, Part 2 - Dynamic Cross Tabs
    Understanding and Using APPLY (Part 1)
    Understanding and Using APPLY (Part 2)
    Post #1444982
    « Prev Topic | Next Topic »

    Add to briefcase 12»»

    Permissions Expand / Collapse