<a href="http://g.adspeed.net/ad.php?do=clk&zid=15220&wd=468&ht=60&pair=as" target="_blank"><img style="border:0px;" src="http://g.adspeed.net/ad.php?do=img&zid=15220&wd=468&ht=60&pair=as" alt="i" width="468" height="60"/></a>
Log in
::
Register
::
Not logged in
Home
Tags
Articles
Editorials
Stairways
Forums
Scripts
Videos
Blogs
QotD
Books
Ask SSC
SQL Jobs
Training
Authors
About us
Contact us
Newsletters
Write for us
<a href="http://g.adspeed.net/ad.php?do=clk&zid=15491&wd=120&ht=300&pair=as" target="_top"><img style="border:0px;" src="http://g.adspeed.net/ad.php?do=img&zid=15491&wd=120&ht=300&pair=as" alt="i" width="120" height="300"/></a>
Recent Posts
Recent Posts
Popular Topics
Popular Topics
Home
Search
Members
Calendar
Who's On
Home
»
Article Discussions
»
Article Discussions by Author
»
Discuss content posted by Harsha Majety
»
Fix all orphaned users in a database
15 posts, Page 1 of 2
1
2
»»
Fix all orphaned users in a database
Rate Topic
Display Mode
Topic Options
Author
Message
harsha.majety
harsha.majety
Posted Tuesday, November 23, 2010 9:34 PM
Forum Newbie
Group: General Forum Members
Last Login: Friday, May 17, 2013 1:28 PM
Points: 6,
Visits: 396
Comments posted to this topic are about the item
Fix all orphaned users in a database
Post #1025649
Julien.Chappel
Julien.Chappel
Posted Tuesday, November 23, 2010 9:48 PM
Grasshopper
Group: General Forum Members
Last Login: Monday, April 18, 2011 8:08 PM
Points: 10,
Visits: 44
I ran the piece of code published under the title: "Fix all orphaned users in a database". It came back with a number of syntax errors. I fiddled with it and managed to run it. The environment I am using Windows 2008 R2 Server, SQL Server 2008 R2. And this is not the first time happening that SQLServerCentral.com publishes "bugy" codes. It would be nice that scripts or solutions published on the SQLServerCentral.com are debugged before publication.
regards
Julien
PS: The majority of the SQL Server solutions are good and I got a lot of help in taking many of these ideas into my solution. Only those are the annoying minorities...
Post #1025652
Rudy Panigas
Rudy Panigas
Posted Wednesday, November 24, 2010 6:54 AM
Old Hand
Group: General Forum Members
Last Login: Yesterday @ 5:32 PM
Points: 306,
Visits: 1,013
Thanks for the code! I've been using a script created by Gregory A. Larsen which I have modified to better suite my needs.
As for "buggy" code. Sometime we write scripts that work well in our own environments and it may not run properly in others. This is not the responsibility of this site to see if ALL the code provide works perfectly. It would take them too long and need more staff to verify everything.
Here is my recommendation. Use the scripts and modify it to suite your environment. It's free so really you can't complain. As a good DBA, you should try to modify the code so that 1) you better understand it, 2) you make it personalized to your environment and 3) you can help by provide your code here for others to see.
If you don't like the script you can also rate it here. You can even submit your own code/articles for others to see and criticize. It's not easy publishing anything as you will always find someone who hates it.
Thanks to everyone who submits code, articles, and help as these things make this site the best in the SQL world!
Just my 2 cents worth.
Rudy
Post #1025864
harsha.majety
harsha.majety
Posted Wednesday, November 24, 2010 7:26 AM
Forum Newbie
Group: General Forum Members
Last Login: Friday, May 17, 2013 1:28 PM
Points: 6,
Visits: 396
thanks rudy
Post #1025906
harsha.majety
harsha.majety
Posted Wednesday, November 24, 2010 7:27 AM
Forum Newbie
Group: General Forum Members
Last Login: Friday, May 17, 2013 1:28 PM
Points: 6,
Visits: 396
@julien : i ran the script on sql server 2008, worked fine for me.
Post #1025907
Rudy Panigas
Rudy Panigas
Posted Wednesday, November 24, 2010 7:58 AM
Old Hand
Group: General Forum Members
Last Login: Yesterday @ 5:32 PM
Points: 306,
Visits: 1,013
No thanks needed as I'm not defending anyone. One thing I don't mention is that when submitting code the author should do his/her best to ensure that it is working.
Now back the this code. Your script will re add users that are orphaned but what if they don't exist? Would your script remove them from the database?
I would modify your script so that it checks if the login exists. If not it should be removed from the database.
Thanks,
Rudy
Post #1025932
Patrick2525
Patrick2525
Posted Wednesday, November 24, 2010 9:19 AM
SSC-Enthusiastic
Group: General Forum Members
Last Login: Monday, April 01, 2013 10:16 AM
Points: 117,
Visits: 180
It would be helpful if the Author added comments to the article and code, including what version he/she created this on and on what versions it is known to work. In this case its a pretty simple script, yet what
sp_change_users_login
does and how it works is still kind of vague. Of course I can google it, but it would be good if the Author addressed that, since its the backbone of the script.
BTW... msdn states that
sp_change_users_login
will not be used in future releases and advises not to include in new dev work
Post #1025989
Rudy Panigas
Rudy Panigas
Posted Wednesday, November 24, 2010 9:57 AM
Old Hand
Group: General Forum Members
Last Login: Yesterday @ 5:32 PM
Points: 306,
Visits: 1,013
Good points Patrick
Post #1026021
rVadim
rVadim
Posted Wednesday, November 24, 2010 11:11 AM
SSC Eights!
Group: General Forum Members
Last Login: Yesterday @ 1:36 PM
Points: 887,
Visits: 2,062
I use Mike Tutor's script. If someone interested it's here:
http://www.sqlservercentral.com/scripts/users/69523/
Post #1026074
john.moreno
john.moreno
Posted Wednesday, November 24, 2010 11:19 AM
Old Hand
Group: General Forum Members
Last Login: Tuesday, May 14, 2013 10:31 PM
Points: 339,
Visits: 950
Patrick2525 (11/24/2010)
It would be helpful if the Author added comments to the article and code, including what version he/she created this on and on what versions it is known to work. In this case its a pretty simple script, yet what
sp_change_users_login
does and how it works is still kind of vague. Of course I can google it, but it would be good if the Author addressed that, since its the backbone of the script.
BTW... msdn states that
sp_change_users_login
will not be used in future releases and advises not to include in new dev work
sp_change_users_login isn't something that you would include in your work, it is something you would use to DO your work.
That said, if you're running 2005 SP2 or latter, you might want to use ALTER USER [user] WITH LOGIN = [user].
Post #1026081
« Prev Topic
|
Next Topic »
15 posts, Page 1 of 2
1
2
»»
Permissions
You
cannot
post new topics.
You
cannot
post topic replies.
You
cannot
post new polls.
You
cannot
post replies to polls.
You
cannot
edit your own topics.
You
cannot
delete your own topics.
You
cannot
edit other topics.
You
cannot
delete other topics.
You
cannot
edit your own posts.
You
cannot
edit other posts.
You
cannot
delete your own posts.
You
cannot
delete other posts.
You
cannot
post events.
You
cannot
edit your own events.
You
cannot
edit other events.
You
cannot
delete your own events.
You
cannot
delete other events.
You
cannot
send private messages.
You
cannot
send emails.
You
may
read topics.
You
cannot
rate topics.
You
cannot
vote within polls.
You
cannot
upload attachments.
You
may
download attachments.
You
cannot
post HTML code.
You
cannot
edit HTML code.
You
cannot
post IFCode.
You
cannot
post JavaScript.
You
cannot
post EmotIcons.
You
cannot
post or upload images.
Copyright © 2002-2013 Simple Talk Publishing. All Rights Reserved.
Privacy Policy.
Terms of Use.
Report Abuse.
