InstantForum.NET v2.9.0SQLServerCentralhttp://www.sqlservercentral.com/Forums/notifications@sqlservercentral.comWed, 22 May 2013 22:36:23 GMT20http://www.sqlservercentral.com/Forums/Topic1428661-61-1.aspxI've found that it's gross ignorance in that people haven't been trained as to all the reasons why you should format your code and include thoughtful/meaningful comments.I've found that it's gross incompetence usually caused by gross ignorance that amplifies the problem.I've also found some real live brainwashing caused by a grossly incorrect interpretations of things like the "Agile Manifesto" and Knuth's famous words about pre-optimization being the root of all evil. That brainwashing also includes stupid things like hitting the schedule no matter if the code is right or not.But I've not found it's because of "slackerness" because it takes a hell of a lot of energy to fight that hard against doing it right. ;-)Fri, 08 Mar 2013 21:37:33 GMTJeff Modenhttp://www.sqlservercentral.com/Forums/Topic1428661-61-1.aspx[quote][b]RP_DBA (3/8/2013)[/b][hr]The discussion I was involved in didn't key on messy, poorly performing code but rather on routinely taking shortcuts and not following best practices. [/quote]Depends on the best practice. I routinely omit RI for example because I find it frustrating down the road a lot of times. I use it only when it's absolutely required.However...[quote]Things like data types not matching underlying tables,[/quote] Okay, THAT'S lazy.[quote]using "SELECT * INTO #TblName"[/quote]Guilty, depending on circumstances[quote], and omitting even the simplest of comments in multi-step processes (pet peeve). [/quote]Also guilty. Most T-SQL is self explanatory. The only time I put in comments is when I feel the code doesn't explain the reason. Most of my comments are about the business reasons really odd algorithms are required, not about the code itself. If I'm breaking established patterns or obvious coding techniques I'll also comment for the reasons so if someone inherits it they don't just remove it when I did it for optimization, not clarity.Fri, 08 Mar 2013 15:16:52 GMTEvil Kraig Fhttp://www.sqlservercentral.com/Forums/Topic1428661-61-1.aspx[quote][b]Evil Kraig F (3/8/2013)[/b][hr]...the DBAs know their name and groan because of the lack of effort...[/quote]Funny, this is what prompted the discussion.[quote][b]Sean Lange (3/8/2013)[/b][hr]I would say that "it depends". I do think to that to some extent you can tell a lot about a person by their code. I don't however think you can tell about their work ethic.[/quote]Maybe work ethic was the wrong word choice.The discussion I was involved in didn't key on messy, poorly performing code but rather on routinely taking shortcuts and not following best practices. Things like data types not matching underlying tables, using "SELECT * INTO #TblName", and omitting even the simplest of comments in multi-step processes (pet peeve). Repeat offenders raise a red flag as lazy coders to me.Fri, 08 Mar 2013 14:21:56 GMTRP_DBAhttp://www.sqlservercentral.com/Forums/Topic1428661-61-1.aspxI would say that "it depends". I do think to that to some extent you can tell a lot about a person by their code. I don't however think you can tell about their work ethic. I know plenty of people who work really hard and produce incredibly sloppy and poor performing code. I know others that hardly work but their code is super fast and pretty enough to hang in a museum. I know which person I prefer to follow when I have to debug stuff though. :-)Fri, 08 Mar 2013 13:17:26 GMTSean Langehttp://www.sqlservercentral.com/Forums/Topic1428661-61-1.aspxI would say no. Random code samples are a poor method, simply because a lot of what we do *is* simple and doesn't need a lot of exposition or intricate algorithsm.I'm more interested in how often their code has to come back from QA for technical (not business oops we meant this) reasons, or if the DBAs know their name and groan because of the lack of effort put into optimizations.Fri, 08 Mar 2013 12:24:53 GMTEvil Kraig Fhttp://www.sqlservercentral.com/Forums/Topic1428661-61-1.aspxI was reading Steve's article on [url=http://www.sqlservercentral.com/Forums/Topic1427798-263-1.aspx][b]Productivity and Accountability[/b][/url] and his observation "that people that don't want to work hard, don't" reminded me of a discussion I was in a couple weeks ago: "is it possible to gauge work ethic based on a random sampling of someone's code?" Curious to see which way people lean on this.Fri, 08 Mar 2013 09:45:15 GMTRP_DBA