InstantForum.NET v2.9.0SQLServerCentralhttp://www.sqlservercentral.com/Forums/notifications@sqlservercentral.comTue, 21 May 2013 10:04:27 GMT20http://www.sqlservercentral.com/Forums/Topic497615-359-1.aspx[quote][b]K. Brian Kelley (5/10/2008)[/b][hr]The problem is that CREATE LOGIN and ALTER LOGIN won't take the variable. The way around this is to use Dynamic SQL. For instance:[code]CREATE PROCEDURE dbo.Create_Login @username sysnameASBEGIN SET NOCOUNT ON DECLARE @SQL NVARCHAR(4000); SET @SQL = 'CREATE LOGIN ' + @username + ' WITH PASSWORD = ''12345'', DEFAULT_DATABASE=[dbname], DEFAULT_LANGUAGE=[British], CHECK_EXPIRATION=OFF, CHECK_POLICY=ON'; EXECUTE(@SQL); EXEC sys.sp_addsrvrolemember @loginame = @username, @rolename = N'sysadmin'; SET @SQL = 'ALTER LOGIN ' + @username + ' DISABLE'; EXECUTE(@SQL);END;[/code][/quote]Brian, now I realise why I could not get your script working I for got the brackets in "EXECUTE(@SQL);".Fri, 13 Apr 2012 14:17:18 GMTManie Versterhttp://www.sqlservercentral.com/Forums/Topic497615-359-1.aspxHi guys,Sorry for never giving feedback here but work has been hectic taking all my free time but no, sorry Brian I could not get your script going and was strapped for time at the time and got a different script and here it is.[code="sql"]declare @userid sysname = 'jon', @password sysname = 'password', @sqlstr nvarchar(250) exec sp_addlogin @loginame = @userid, @passwd = @password, @defdb = 'ToolboxDB', @deflanguage = [British], @sid = null, @encryptopt= null EXEC sys.sp_addsrvrolemember @userid, @rolename = N'sysadmin'USE [ToolboxDB]set @sqlstr = 'CREATE USER '+@userid+' FOR LOGIN '+@useridEXECUTE sp_executesql @sqlstr[/code]Allow me to explain. The top part creates a login in sql server (not the database). You will see a security folder just below the database folder as follows:[code="sql"]exec sp_addlogin @loginame = @userid, @passwd = @password, @defdb = 'ToolboxDB', @deflanguage = [British], @sid = null, @encryptopt= null[/code]The following part adds the login to a server role. I have sysadmin here but you can change that according to your own needs.[code="sql"] EXEC sys.sp_addsrvrolemember @userid, @rolename = N'sysadmin'[/code]You can also add it to more than one role if needed. The following part maps your login to a specific database and here you can also use more than one database just put the code in for each database.[code="sql"]USE [ToolboxDB]set @sqlstr = 'CREATE USER '+@userid+' FOR LOGIN '+@useridEXECUTE sp_executesql @sqlstr[/code]Check out the link below for more on sp_executesql but the reason why I used this is because when I used Brian's script I kept getting "Cannot find the stored procedure ..........".[url=http://http://www.mssqltips.com/sqlservertip/1160/execute-dynamic-sql-commands-in-sql-server/][/url]Fri, 13 Apr 2012 14:13:09 GMTManie Versterhttp://www.sqlservercentral.com/Forums/Topic497615-359-1.aspxI'm looking for a similar thing but can't get this to work.Can anyone think of a reason why this won't work in 2008 R2?Does it need any alterations to work properly?Thu, 12 Apr 2012 04:15:43 GMTrichardmgreen1http://www.sqlservercentral.com/Forums/Topic497615-359-1.aspx[quote][b]david.griffiths 57552 (11/29/2010)[/b][hr]Can this script be amended so it will read a spreadsheet with a list ofUsername, password database access?[/quote]You can create a stored procedure that accepts username, password, etc..Then in another column of your excel file using concatenate function create the sql statement for each onsomethin Like =CONCATENATE("EXEC usp_CreateLogin @username='",A2,"', @Password = '",B2,"' … ")Then copy the cell and paste it all the way down until a statement per username is created, after that copy the whole column and paste it in the SQL Management StudioThis should create all the usersTue, 07 Jun 2011 14:43:22 GMTAristides Rapozohttp://www.sqlservercentral.com/Forums/Topic497615-359-1.aspxCan this script be amended so it will read a spreadsheet with a list ofUsername, password database access?Mon, 29 Nov 2010 06:11:38 GMTdavid.griffiths 57552http://www.sqlservercentral.com/Forums/Topic497615-359-1.aspxYes, you need to use dynamic SQL to do this. Which means that whoever causes the stored procedure to execute needs the appropriate permissions to create logins, modify database users, grant permissions, etc. So unless this is just a convenience for people who are in the SysAdmin role, you will want to look at the solution referenced in the first reply o your post (which does use dynamic SQL for CREATE LOGIN).Repeating the link:http://blogs.msdn.com/lcris/archive/2005/06/15/sql-server-2005-procedure-signing-demo.aspxThu, 17 Dec 2009 12:05:02 GMTDLathrophttp://www.sqlservercentral.com/Forums/Topic497615-359-1.aspxK Brian Kelly, you are a star! I am defeinitely going to try this and I am sure it will work. This is the best answer I got do far! :P:D:):w00t:Wed, 14 May 2008 00:36:17 GMTManie Versterhttp://www.sqlservercentral.com/Forums/Topic497615-359-1.aspxThe problem is that CREATE LOGIN and ALTER LOGIN won't take the variable. The way around this is to use Dynamic SQL. For instance:[code]CREATE PROCEDURE dbo.Create_Login @username sysnameASBEGIN SET NOCOUNT ON DECLARE @SQL NVARCHAR(4000); SET @SQL = 'CREATE LOGIN ' + @username + ' WITH PASSWORD = ''12345'', DEFAULT_DATABASE=[dbname], DEFAULT_LANGUAGE=[British], CHECK_EXPIRATION=OFF, CHECK_POLICY=ON'; EXECUTE(@SQL); EXEC sys.sp_addsrvrolemember @loginame = @username, @rolename = N'sysadmin'; SET @SQL = 'ALTER LOGIN ' + @username + ' DISABLE'; EXECUTE(@SQL);END;[/code]Sat, 10 May 2008 06:14:32 GMTK. Brian Kelleyhttp://www.sqlservercentral.com/Forums/Topic497615-359-1.aspxShould you add OUTPUT ASCREATE PROCEDURE dbo.Create_Login ( @username varchar(50) [b]OUTPUT[/b] )AS...?Fri, 09 May 2008 14:34:30 GMTSQL ORACLEhttp://www.sqlservercentral.com/Forums/Topic497615-359-1.aspxHi Manie,take a look at this:[url=http://blogs.msdn.com/lcris/archive/2005/06/15/sql-server-2005-procedure-signing-demo.aspx]http://blogs.msdn.com/lcris/archive/2005/06/15/sql-server-2005-procedure-signing-demo.aspx[/url]Fri, 09 May 2008 01:46:08 GMTTorsten Schüßler-406123http://www.sqlservercentral.com/Forums/Topic497615-359-1.aspxI have the following stored procedure to create a login on SQL Server 2005. As is it works perfectly but I want to pass a parameter for the login name but keeps getting incorrect syntax errors. The script looks as follows:CREATE PROCEDURE dbo.Create_LoginASBEGIN SET NOCOUNT ONCREATE LOGIN [johnny] WITH PASSWORD = '12345', DEFAULT_DATABASE=[dbname], DEFAULT_LANGUAGE=[British], CHECK_EXPIRATION=OFF, CHECK_POLICY=ONEXEC sys.sp_addsrvrolemember @loginame = N'johnny', @rolename = N'sysadmin'ALTER LOGIN [@username] DISABLEENDWhen I pass the parameter it looks like this:CREATE PROCEDURE dbo.Create_Login ( @username varchar(50) )ASBEGIN SET NOCOUNT ONCREATE LOGIN @username WITH PASSWORD = '12345', DEFAULT_DATABASE=[dbname], DEFAULT_LANGUAGE=[British], CHECK_EXPIRATION=OFF, CHECK_POLICY=ONEXEC sys.sp_addsrvrolemember @loginame = @username, @rolename = N'sysadmin'ALTER LOGIN @username DISABLEENDPlease can someone help me to get this right. I have searched but nowhere any site says anything about passing a parameterThanksManie VersterFri, 09 May 2008 00:52:30 GMTManie Verster