InstantForum.NET v2.9.0SQLServerCentralhttp://www.sqlservercentral.com/Forums/notifications@sqlservercentral.comSat, 18 May 2013 06:02:03 GMT20http://www.sqlservercentral.com/Forums/Topic1408114-1292-1.aspx[code="sql"]-- you only need to read the SalesGLLink table once:INSERT INTO #TempSalesGLLink( StoreId, LocId, SalesGLLinkUniqueNum, SalesTypeCd, LineCd, VehSaleAcct, VehSaleDept, TradeACVAcct, TradeACVDept, OverAllowAcct, OverAllowDept, LoanDiscountAcct, LoanDiscountDept, DueFromFinAcct, DueFromFinDept, CashDownAcct, CashDownDept, CostGoodsAcct, CostGoodsDept, InvSoldDept, OtherIncomeAcct, OtherIncomeDept, DueToCustAcct, DueToCustDept, NSFFeeAcct, NSFFeeDept, NSFRecAcct, NSFRecDept, CostofSalesSubAcct, CostofSalesSubDept, AHInsRevenueAcct, AHInsRevenueDept, AHInsCostAcct, AHInsCostDept, CLInsRevenueAcct, CLInsRevenueDept, CLInsCostAcct, CLInsCostDept)SELECT StoreId, LocId, cj.SalesGLLinkUniqueNum, SalesTypeCd, cj.LineCd, VehSaleAcct, VehSaleDept, TradeACVAcct, TradeACVDept, OverAllowAcct, OverAllowDept, LoanDiscountAcct, LoanDiscountDept, DueFromFinAcct, DueFromFinDept, CashDownAcct, CashDownDept, CostGoodsAcct, CostGoodsDept, InvSoldDept, OtherIncomeAcct, OtherIncomeDept, DueToCustAcct, DueToCustDept, NSFFeeAcct, NSFFeeDept, NSFRecAcct, NSFRecDept, CostofSalesSubAcct, CostofSalesSubDept, AHInsRevenueAcct, AHInsRevenueDept, AHInsCostAcct, AHInsCostDept, CLInsRevenueAcct, CLInsRevenueDept, CLInsCostAcct, CLInsCostDept FROM SalesGLLink sCROSS JOIN (SELECT SalesGLLinkUniqueNum = 6, LineCd = '4' UNION ALL SELECT 7, '5') cj WHERE s.salestypecd = 'r' AND s.linecd = '3' [/code]Thu, 17 Jan 2013 08:27:27 GMTChrisM@Workhttp://www.sqlservercentral.com/Forums/Topic1408114-1292-1.aspxNo problem!Thu, 17 Jan 2013 08:17:21 GMTGazarethhttp://www.sqlservercentral.com/Forums/Topic1408114-1292-1.aspxThank you Gazareth. I looked again and realized I didn't even need the loop.All I need is and really I don't even need the temp table just need to do the insert on the permanent table. I think my brain was on vacation yesterday.create table #TempSalesGLLink( AHInsCostAcct varchar(10), AHInsCostDept varchar(10), AHInsRevenueAcct varchar(10), AHInsRevenueDept varchar(10), CashDownAcct varchar(10), CashDownDept varchar(3), CLInsCostAcct varchar(10), CLInsCostDept varchar(10), CLInsRevenueAcct varchar(10), CLInsRevenueDept varchar(10), CostGoodsAcct varchar(10), CostGoodsDept varchar(3), CostofSalesSubAcct varchar(10), CostofSalesSubDept varchar(10), DueFromFinAcct varchar(10), DueFromFinDept varchar(3), DueToCustAcct varchar(10), DueToCustDept varchar(3), InvSoldAcct varchar(10), InvSoldDept varchar(3), LineCd char(2), LoanDiscountAcct varchar(10), LoanDiscountDept varchar(3), LocId varchar(10), NSFFeeAcct varchar(10), NSFFeeDept varchar(3), NSFRecAcct varchar(10), NSFRecDept varchar(10), OtherIncomeAcct varchar(10), OtherIncomeDept varchar(3), OverAllowAcct varchar(10), OverAllowDept varchar(3), SalesGLLinkUniqueNum int, SalesTypeCd varchar(5), StoreId varchar(10), TradeACVAcct varchar(10), TradeACVDept varchar(3), VehSaleAcct varchar(5), VehSaleDept varchar(3))--CONSTRAINT [PK_SalesGLLink] PRIMARY KEY --(-- [StoreId] ASC,-- [LocId] ASC,-- [SalesGLLinkUniqueNum] ASC--)WITH (PAD_INDEX = OFF, STATISTICS_NORECOMPUTE = OFF, IGNORE_DUP_KEY = OFF, ALLOW_ROW_LOCKS = ON, ALLOW_PAGE_LOCKS = ON, FILLFACTOR = 80) ON [PRIMARY]--) ON [PRIMARY]SET NOCOUNT ONInsert Into #TempSalesGLLink(StoreId, LocId, SalesGLLinkUniqueNum, SalesTypeCd, LineCd, VehSaleAcct, VehSaleDept, TradeACVAcct, TradeACVDept, OverAllowAcct, OverAllowDept, LoanDiscountAcct, LoanDiscountDept,DueFromFinAcct, DueFromFinDept, CashDownAcct, CashDownDept, CostGoodsAcct, CostGoodsDept, InvSoldDept, OtherIncomeAcct, OtherIncomeDept, DueToCustAcct, DueToCustDept, NSFFeeAcct, NSFFeeDept, NSFRecAcct,NSFRecDept, CostofSalesSubAcct, CostofSalesSubDept, AHInsRevenueAcct, AHInsRevenueDept, AHInsCostAcct, AHInsCostDept, CLInsRevenueAcct, CLInsRevenueDept, CLInsCostAcct, CLInsCostDept)select StoreId, LocId, 6, SalesTypeCd, '4' as LineCd, VehSaleAcct, VehSaleDept, TradeACVAcct, TradeACVDept, OverAllowAcct, OverAllowDept, LoanDiscountAcct, LoanDiscountDept,DueFromFinAcct, DueFromFinDept, CashDownAcct, CashDownDept, CostGoodsAcct, CostGoodsDept, InvSoldDept, OtherIncomeAcct, OtherIncomeDept, DueToCustAcct, DueToCustDept, NSFFeeAcct, NSFFeeDept, NSFRecAcct,NSFRecDept, CostofSalesSubAcct, CostofSalesSubDept, AHInsRevenueAcct, AHInsRevenueDept, AHInsCostAcct, AHInsCostDept, CLInsRevenueAcct, CLInsRevenueDept, CLInsCostAcct, CLInsCostDept from SalesGLLink where salestypecd = 'r' and linecd = '3' Insert Into #TempSalesGLLink(StoreId, LocId, SalesGLLinkUniqueNum, SalesTypeCd, LineCd, VehSaleAcct, VehSaleDept, TradeACVAcct, TradeACVDept, OverAllowAcct, OverAllowDept, LoanDiscountAcct, LoanDiscountDept,DueFromFinAcct, DueFromFinDept, CashDownAcct, CashDownDept, CostGoodsAcct, CostGoodsDept, InvSoldDept, OtherIncomeAcct, OtherIncomeDept, DueToCustAcct, DueToCustDept, NSFFeeAcct, NSFFeeDept, NSFRecAcct,NSFRecDept, CostofSalesSubAcct, CostofSalesSubDept, AHInsRevenueAcct, AHInsRevenueDept, AHInsCostAcct, AHInsCostDept, CLInsRevenueAcct, CLInsRevenueDept, CLInsCostAcct, CLInsCostDept)select StoreId, LocId, 7, SalesTypeCd, '5' as LineCd, VehSaleAcct, VehSaleDept, TradeACVAcct, TradeACVDept, OverAllowAcct, OverAllowDept, LoanDiscountAcct, LoanDiscountDept,DueFromFinAcct, DueFromFinDept, CashDownAcct, CashDownDept, CostGoodsAcct, CostGoodsDept, InvSoldDept, OtherIncomeAcct, OtherIncomeDept, DueToCustAcct, DueToCustDept, NSFFeeAcct, NSFFeeDept, NSFRecAcct,NSFRecDept, CostofSalesSubAcct, CostofSalesSubDept, AHInsRevenueAcct, AHInsRevenueDept, AHInsCostAcct, AHInsCostDept, CLInsRevenueAcct, CLInsRevenueDept, CLInsCostAcct, CLInsCostDept from SalesGLLink where salestypecd = 'r' and linecd = '3'Thu, 17 Jan 2013 05:46:35 GMTcdub11532http://www.sqlservercentral.com/Forums/Topic1408114-1292-1.aspx[quote][b]cdub11532 (1/17/2013)[/b][hr]Thanks for the reply. I know what the error means. I'm trying to figure out why when performing the loop it keeps putting in the same records multiple times. That's why I added the primary key to the temp table.[/quote]Because your select statement is the same in each loop :-)Thu, 17 Jan 2013 04:08:16 GMTGazarethhttp://www.sqlservercentral.com/Forums/Topic1408114-1292-1.aspxOn that PK violation - As far as I can tell, each loop just inserts the same data, so you will get the PK violation on the second iteration?Thu, 17 Jan 2013 04:07:14 GMTGazarethhttp://www.sqlservercentral.com/Forums/Topic1408114-1292-1.aspxThanks for the reply. I know what the error means. I'm trying to figure out why when performing the loop it keeps putting in the same records multiple times. That's why I added the primary key to the temp table.Thu, 17 Jan 2013 04:03:34 GMTcdub11532http://www.sqlservercentral.com/Forums/Topic1408114-1292-1.aspxJust like the error said...you have a primary key on the table and primary keys don't accept duplicatesWed, 16 Jan 2013 22:34:32 GMTTochihttp://www.sqlservercentral.com/Forums/Topic1408114-1292-1.aspxI'm trying to insert multiple records in while loop but I keep getting cannot insert duplicate into primary key error. I'm trying to insert same information into temp table except for linecd should be 4 or 5. Issue seems to be with while loop.create table #TempSalesGLLink(AHInsCostAcct varchar(10), AHInsCostDept varchar(10), AHInsRevenueAcct varchar(10), AHInsRevenueDept varchar(10), CashDownAcct varchar(10), CashDownDept varchar(3), CLInsCostAcct varchar(10), CLInsCostDept varchar(10), CLInsRevenueAcct varchar(10), CLInsRevenueDept varchar(10), CostGoodsAcct varchar(10), CostGoodsDept varchar(3), CostofSalesSubAcct varchar(10), CostofSalesSubDept varchar(10), DueFromFinAcct varchar(10), DueFromFinDept varchar(3), DueToCustAcct varchar(10), DueToCustDept varchar(3), InvSoldAcct varchar(10), InvSoldDept varchar(3), LineCd char(2), LoanDiscountAcct varchar(10), LoanDiscountDept varchar(3), LocId varchar(10), NSFFeeAcct varchar(10), NSFFeeDept varchar(3), NSFRecAcct varchar(10), NSFRecDept varchar(10), OtherIncomeAcct varchar(10), OtherIncomeDept varchar(3), OverAllowAcct varchar(10), OverAllowDept varchar(3), SalesGLLinkUniqueNum int, SalesTypeCd varchar(5), StoreId varchar(10), TradeACVAcct varchar(10), TradeACVDept varchar(3), VehSaleAcct varchar(5), VehSaleDept varchar(3),CONSTRAINT [PK_SalesGLLink] PRIMARY KEY ([StoreId] ASC,[LocId] ASC,[SalesGLLinkUniqueNum] ASC)WITH (PAD_INDEX = OFF, STATISTICS_NORECOMPUTE = OFF, IGNORE_DUP_KEY = OFF, ALLOW_ROW_LOCKS = ON, ALLOW_PAGE_LOCKS = ON, FILLFACTOR = 80) ON [PRIMARY]) ON [PRIMARY]SET NOCOUNT ON--Insert Into #TempSalesGLLink(AHInsCostAcct, AHInsCostDept, AHInsRevenueAcct, AHInsRevenueDept, CashDownAcct, CashDownDept, CLInsCostAcct, CLInsCostDept, CLInsRevenueAcct, CLInsRevenueDept, CostGoodsAcct, --CostGoodsDept, CostofSalesSubAcct, CostofSalesSubDept, DueFromFinAcct, DueFromFinDept, DueToCustAcct, DueToCustDept, InvSoldAcct, InvSoldDept, LineCd, LoanDiscountAcct, LoanDiscountDept, LocId --, NSFFeeAcct, NSFFeeDept, NSFRecAcct, NSFRecDept, OtherIncomeAcct, OtherIncomeDept, OverAllowAcct, OverAllowDept, SalesGLLinkUniqueNum , SalesTypeCd, StoreId --, TradeACVAcct, TradeACVDept, VehSaleAcct, VehSaleDept --)--/* Gets the Product Description, MembershipNo, DateAdded, LastName and FirstName, and BranchName for New Members */-- select AHInsCostAcct, AHInsCostDept, AHInsRevenueAcct, AHInsRevenueDept, CashDownAcct, CashDownDept, CLInsCostAcct, CLInsCostDept, CLInsRevenueAcct, CLInsRevenueDept, CostGoodsAcct, -- CostGoodsDept, CostofSalesSubAcct, CostofSalesSubDept, DueFromFinAcct, DueFromFinDept, DueToCustAcct, DueToCustDept, InvSoldAcct, InvSoldDept, LineCd, LoanDiscountAcct, LoanDiscountDept, LocId,-- NSFFeeAcct, NSFFeeDept, NSFRecAcct, NSFRecDept, OtherIncomeAcct, OtherIncomeDept, OverAllowAcct, OverAllowDept, SalesGLLinkUniqueNum , SalesTypeCd, StoreId,-- TradeACVAcct, TradeACVDept, VehSaleAcct, VehSaleDept from SalesGLLink where salestypecd = 'r' and linecd = '3'declare @rowCount intselect @rowCount = count(*) from SalesGLLink where salestypecd = 'r' and linecd = '3'Print @rowCountdeclare @counter intselect @counter = 0[color=#FF4040]while @counter < @rowCount[/color]beginInsert Into #TempSalesGLLink(StoreId, LocId, SalesGLLinkUniqueNum, SalesTypeCd, LineCd, VehSaleAcct, VehSaleDept, TradeACVAcct, TradeACVDept, OverAllowAcct, OverAllowDept, LoanDiscountAcct, LoanDiscountDept,DueFromFinAcct, DueFromFinDept, CashDownAcct, CashDownDept, CostGoodsAcct, CostGoodsDept, InvSoldDept, OtherIncomeAcct, OtherIncomeDept, DueToCustAcct, DueToCustDept, NSFFeeAcct, NSFFeeDept, NSFRecAcct,NSFRecDept, CostofSalesSubAcct, CostofSalesSubDept, AHInsRevenueAcct, AHInsRevenueDept, AHInsCostAcct, AHInsCostDept, CLInsRevenueAcct, CLInsRevenueDept, CLInsCostAcct, CLInsCostDept)select StoreId, LocId, SalesGLLinkUniqueNum, SalesTypeCd, '4' as LineCd, VehSaleAcct, VehSaleDept, TradeACVAcct, TradeACVDept, OverAllowAcct, OverAllowDept, LoanDiscountAcct, LoanDiscountDept,DueFromFinAcct, DueFromFinDept, CashDownAcct, CashDownDept, CostGoodsAcct, CostGoodsDept, InvSoldDept, OtherIncomeAcct, OtherIncomeDept, DueToCustAcct, DueToCustDept, NSFFeeAcct, NSFFeeDept, NSFRecAcct,NSFRecDept, CostofSalesSubAcct, CostofSalesSubDept, AHInsRevenueAcct, AHInsRevenueDept, AHInsCostAcct, AHInsCostDept, CLInsRevenueAcct, CLInsRevenueDept, CLInsCostAcct, CLInsCostDept from SalesGLLink where salestypecd = 'r' and linecd = '3' Insert Into #TempSalesGLLink(StoreId, LocId, SalesGLLinkUniqueNum, SalesTypeCd, LineCd, VehSaleAcct, VehSaleDept, TradeACVAcct, TradeACVDept, OverAllowAcct, OverAllowDept, LoanDiscountAcct, LoanDiscountDept,DueFromFinAcct, DueFromFinDept, CashDownAcct, CashDownDept, CostGoodsAcct, CostGoodsDept, InvSoldDept, OtherIncomeAcct, OtherIncomeDept, DueToCustAcct, DueToCustDept, NSFFeeAcct, NSFFeeDept, NSFRecAcct,NSFRecDept, CostofSalesSubAcct, CostofSalesSubDept, AHInsRevenueAcct, AHInsRevenueDept, AHInsCostAcct, AHInsCostDept, CLInsRevenueAcct, CLInsRevenueDept, CLInsCostAcct, CLInsCostDept )select StoreId, LocId, SalesGLLinkUniqueNum, SalesTypeCd, '5' as LineCd, VehSaleAcct, VehSaleDept, TradeACVAcct, TradeACVDept, OverAllowAcct, OverAllowDept, LoanDiscountAcct, LoanDiscountDept,DueFromFinAcct, DueFromFinDept, CashDownAcct, CashDownDept, CostGoodsAcct, CostGoodsDept, InvSoldDept, OtherIncomeAcct, OtherIncomeDept, DueToCustAcct, DueToCustDept, NSFFeeAcct, NSFFeeDept, NSFRecAcct,NSFRecDept, CostofSalesSubAcct, CostofSalesSubDept, AHInsRevenueAcct, AHInsRevenueDept, AHInsCostAcct, AHInsCostDept, CLInsRevenueAcct, CLInsRevenueDept, CLInsCostAcct, CLInsCostDept from SalesGLLink where salestypecd = 'r' and linecd = '3' select @counter = @counter + 1 Print @Counter end select StoreId, LocId, SalesGLLinkUniqueNum, SalesTypeCd, LineCd, VehSaleAcct, VehSaleDept, TradeACVAcct, TradeACVDept, OverAllowAcct, OverAllowDept, LoanDiscountAcct, LoanDiscountDept,DueFromFinAcct, DueFromFinDept, CashDownAcct, CashDownDept, CostGoodsAcct, CostGoodsDept, InvSoldDept, OtherIncomeAcct, OtherIncomeDept, DueToCustAcct, DueToCustDept, NSFFeeAcct, NSFFeeDept, NSFRecAcct,NSFRecDept, CostofSalesSubAcct, CostofSalesSubDept, AHInsRevenueAcct, AHInsRevenueDept, AHInsCostAcct, AHInsCostDept, CLInsRevenueAcct, CLInsRevenueDept, CLInsCostAcct, CLInsCostDept from #TempSalesGLLink where LineCd = '4' or LineCd = '5'--drop table #TempSalesGLLinkWed, 16 Jan 2013 18:06:03 GMTcdub11532