Best method for coding stored proc SQL to get next key to avoid DUPs

  • Developer called.   She need best practice to accommodate the following:
    TableXYZ has a numeric KEY value, 1,2,3,4,5, etc...
    Application needs to grab next available KEY then update the row to increment that key value for next insert
    Problem is:  2 Users access table at same time and grab idnetical KEY value (eg. 6) and they're having issues...
    What is best practice to obtain the next key value, update the row and set KEY to next value?
    thx in advance

    BT
  • Express12 - Friday, September 29, 2017 12:28 PM

    Developer called.   She need best practice to accommodate the following:
    TableXYZ has a numeric KEY value, 1,2,3,4,5, etc...
    Application needs to grab next available KEY then update the row to increment that key value for next insert
    Problem is:  2 Users access table at same time and grab idnetical KEY value (eg. 6) and they're having issues...
    What is best practice to obtain the next key value, update the row and set KEY to next value?
    thx in advance

    An IDENTITY column should do it. Otherwise you could define a SEQUENCE and use that instead.

    If you haven't even tried to resolve your issue, please don't expect the hard-working volunteers here to waste their time providing links to answers which you could easily have found yourself.

  • As Phil mentioned IDENTITY and SEQUENCE are the most common and easier to work with .

    If not feasible something like this will be the next best thing e.g. you update and output the desired value in a single operation.

    if object_id('tempdb..#t1') is not null
    drop table #t1
    create table #t1
    (id int)

    insert into #t1 select 1

    declare @out table
    (lastid int)

    update t1
    set id = id + 1
    output deleted.id -- could be inserted.id if new ID is the desired value
    into @Out
    from #t1 t1 with (rowlock)

    select * from @Out
    Similar to a sequence you could also setup a table that contains numbers in sequence - 100k or 1million
    then do something similar to (will need to get exact code one of my clients uses on 2008 R2 for this.

    with topx as
    (select top 1 *
    from #t1 with (updlock, readpast)
    order by id
    )
    delete topx
    output deleted.id
    into @Out

  • Express12 - Friday, September 29, 2017 12:28 PM

    Developer called.   She need best practice to accommodate the following:
    TableXYZ has a numeric KEY value, 1,2,3,4,5, etc...
    Application needs to grab next available KEY then update the row to increment that key value for next insert
    Problem is:  2 Users access table at same time and grab idnetical KEY value (eg. 6) and they're having issues...
    What is best practice to obtain the next key value, update the row and set KEY to next value?
    thx in advance

    As the others have stated, either IDENTITY or SEQUENCE is the best way to go. 

    I know this is going to sound a bit nasty and I apologize for that but this if really basic knowledge that's missing and I'm thinking only of the success of your project, whatever it is.  I strongly recommend that you get someone on the project that knows something about databases and SQL other than them just being a place and method to store data.  If you think that will cost too much, remember what "Red" Adair is famous for saying; "If you think it's expensive to hire a professional to do the job, wait until you hire an amateur".

    --Jeff Moden


    RBAR is pronounced "ree-bar" and is a "Modenism" for Row-By-Agonizing-Row.
    First step towards the paradigm shift of writing Set Based code:
    ________Stop thinking about what you want to do to a ROW... think, instead, of what you want to do to a COLUMN.

    Change is inevitable... Change for the better is not.


    Helpful Links:
    How to post code problems
    How to Post Performance Problems
    Create a Tally Function (fnTally)

Viewing 4 posts - 1 through 3 (of 3 total)

You must be logged in to reply to this topic. Login to reply